Price::defaultProperties() - Code Metrics - Inspection of "refactor" - carono/php-commerceml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b47dcf...3f2121 )

by Aleksandr

created 2019-03-01 12:07 UTC

Price::defaultProperties() A

↳ Parent: Price

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	9
ccs	0
cts	9
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php


namespace Zenwalker\CommerceML\Model;


/**
 * Class Price
 *
 * @package Zenwalker\CommerceML\Model
 * @property string performance
 * @property string cost
 * @property string currency
 * @property string unit
 * @property string rate
 * @property Simple type
 */
class Price extends Simple
{
    protected $type;

    public function __get($name)
    {
        if ($result = parent::__get($name)) {
            if ($this->type && ($value = $this->type->{$name})) {
                return $value;
            }
        }
        return $result;
    }

    public function propertyAliases()
    {
        return [
            'Представление' => 'performance',
            'ИдТипаЦены' => 'id',
            'ЦенаЗаЕдиницу' => 'cost',
            'Валюта' => 'currency',
            'Единица' => 'unit',
            'Коэффициент' => 'rate',
        ];
    }

    public function getType()
    {
        if (!$this->type && ($id = $this->id)) {
            if ($type = $this->owner->offerPackage->xpath("//c:ТипЦены[c:Ид = '{$id}']")) {
                $this->type = new Simple($this->owner, $type[0]);
            }
        }
        return $this->type;
    }

    public function init()
    {
        if ($this->xml && $this->xml->Цена) {
            foreach ($this->xml->Цена as $price) {
                $this->append(new self($this->owner, $price));
            }
            $this->getType();
        }
        parent::init();
    }
}

1		<?php
2
3
4		namespace Zenwalker\CommerceML\Model;
5
6
7		/**
8		* Class Price
9		*
10		* @package Zenwalker\CommerceML\Model
11		* @property string performance
12		* @property string cost
13		* @property string currency
14		* @property string unit
15		* @property string rate
16		* @property Simple type
17		*/
18		class Price extends Simple
19		{
20		protected $type;
21
22	1	public function __get($name)
23		{
24	1	if ($result = parent::__get($name)) {
25	1	if ($this->type && ($value = $this->type->{$name})) {
26		return $value;
27		}
28		}
29	1	return $result;
30		}
31
32	1	public function propertyAliases()
33		{
34		return [
35	1	'Представление' => 'performance',
36		'ИдТипаЦены' => 'id',
37		'ЦенаЗаЕдиницу' => 'cost',
38		'Валюта' => 'currency',
39		'Единица' => 'unit',
40		'Коэффициент' => 'rate',
41		];
42		}
43
44	1	public function getType()
45		{
46	1	if (!$this->type && ($id = $this->id)) {
47	1	if ($type = $this->owner->offerPackage->xpath("//c:ТипЦены[c:Ид = '{$id}']")) {
48	1	$this->type = new Simple($this->owner, $type[0]);
49		}
50		}
51	1	return $this->type;
52		}
53
54	1	public function init()
55		{
56	1	if ($this->xml && $this->xml->Цена) {
57	1	foreach ($this->xml->Цена as $price) {
58	1	$this->append(new self($this->owner, $price));
59		}
60	1	$this->getType();
61		}
62	1	parent::init();
63		}
64		}

carono / php-commerceml

Push — master ( b47dcf...3f2121 )

Price::defaultProperties() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like