Property::getValueModel() - Code Metrics - Inspection of "Добавлено сохранение путей исходных файдов загрузк..." - carono/php-commerceml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1cde7b...7c9c8d )

by Aleksandr

created 2023-07-30 12:35 UTC

Property::getValueModel() A

↳ Parent: Project

Complexity

Conditions	5
Paths	3

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	13
ccs	9
cts	9
cp	1
rs	9.6111
c	0
b	0
f	0
cc	5
nc	3
nop	0
crap	5

<?php namespace Zenwalker\CommerceML\Model;

/**
 * Class Property
 *
 * @package Zenwalker\CommerceML\Model
 * @property \SimpleXMLElement[] availableValues
 * @property Simple valueModel
 * @property mixed value
 */
class Property extends Simple
{
    public $productId;
    protected $_value;

    /**
     * @return \SimpleXMLElement[]
     */
    public function getAvailableValues()
    {
        return $this->owner->classifier->getReferenceBookById($this->id);
    }

    /**
     * @return Simple|null
     */
    public function getValueModel()
    {
        if ($this->productId && !$this->_value && ($product = $this->owner->catalog->getById($this->productId))) {
            $xpath = "c:ЗначенияСвойств/c:ЗначенияСвойства[c:Ид = '{$this->id}']";
            $valueXml = $product->xpath($xpath)[0];
            $value = $this->_value = (string)$valueXml->Значение;

            if ($property = $this->owner->classifier->getReferenceBookValueById($value)) {
                $this->_value = new Simple($this->owner, $property);
            } else {
                $this->_value = new Simple($this->owner, $valueXml);
            }
        }
        return $this->_value;
    }

    public function getValue()
    {
        return $this->getValueModel() ? (string)$this->getValueModel()->value : null;
    }
}

1		<?php namespace Zenwalker\CommerceML\Model;
2
3		/**
4		* Class Property
5		*
6		* @package Zenwalker\CommerceML\Model
7		* @property \SimpleXMLElement[] availableValues
8		* @property Simple valueModel
9		* @property mixed value
10		*/
11		class Property extends Simple
12		{
13		public $productId;
14		protected $_value;
15
16		/**
17		* @return \SimpleXMLElement[]
18		*/
19	1	public function getAvailableValues()
20		{
21	1	return $this->owner->classifier->getReferenceBookById($this->id);
22		}
23
24		/**
25		* @return Simple\|null
26		*/
27	2	public function getValueModel()
28		{
29	2	if ($this->productId && !$this->_value && ($product = $this->owner->catalog->getById($this->productId))) {
30	2	$xpath = "c:ЗначенияСвойств/c:ЗначенияСвойства[c:Ид = '{$this->id}']";
31	2	$valueXml = $product->xpath($xpath)[0];
32	2	$value = $this->_value = (string)$valueXml->Значение;
		0 ignored issues – show Bug introduced 2023-07-30 12:44 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_LNUMBER, expecting T_STRING or T_VARIABLE or '{' or '$' on line 32 at column 56 Loading history...
33	2	if ($property = $this->owner->classifier->getReferenceBookValueById($value)) {
34	1	$this->_value = new Simple($this->owner, $property);
35		} else {
36	1	$this->_value = new Simple($this->owner, $valueXml);
37		}
38		}
39	2	return $this->_value;
40		}
41
42	2	public function getValue()
43		{
44	2	return $this->getValueModel() ? (string)$this->getValueModel()->value : null;
45		}
46		}

carono / php-commerceml

Push — master ( 1cde7b...7c9c8d )

Property::getValueModel() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like