Group::getChildById() - Code Metrics - Inspection of "Добавлено сохранение путей исходных файдов загрузк..." - carono/php-commerceml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1cde7b...7c9c8d )

by Aleksandr

created 2023-07-30 12:35 UTC

Group::getChildById() A

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4.0466

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	12
ccs	6
cts	7
cp	0.8571
rs	10
cc	4
nc	4
nop	1
crap	4.0466

<?php


namespace Zenwalker\CommerceML\Model;


/**
 * Class Group
 *
 * @package Zenwalker\CommerceML\Model
 * @property Group parent
 * @property Group[] children
 */
class Group extends Simple
{
    /**
     * @var Group[]
     */
    protected $children = [];

    /**
     * @var Group
     */
    protected $parent;

    /**
     * @return Group[]
     */
    public function getChildren()
    {
        if (empty($this->children) && $this->xml->Группы) {

            foreach ($this->xml->Группы->Группа as $group) {
                $this->children[] = new Group($this->owner, $group);
            }
        }
        return $this->children;
    }

    /**
     * @return Group
     */
    public function getParent()
    {
        if (!$this->parent) {
            $parent = $this->xpath('../..')[0];
            if ($parent->getName() === 'Группа') {
                $this->parent = new Group($this->owner, $parent);
            }
        }
        return $this->parent;
    }

    /**
     * @param string $id
     * @return null|Group
     */
    public function getChildById($id)
    {
        foreach ($this->getChildren() as $child) {
            if ($child->id === $id) {
                return $child;
            }

            if ($subChild = $child->getChildById($id)) {
                return $subChild;
            }
        }
        return null;
    }
}

1		<?php
2
3
4		namespace Zenwalker\CommerceML\Model;
5
6
7		/**
8		* Class Group
9		*
10		* @package Zenwalker\CommerceML\Model
11		* @property Group parent
12		* @property Group[] children
13		*/
14		class Group extends Simple
15		{
16		/**
17		* @var Group[]
18		*/
19		protected $children = [];
20
21		/**
22		* @var Group
23		*/
24		protected $parent;
25
26		/**
27		* @return Group[]
28		*/
29	5	public function getChildren()
30		{
31	5	if (empty($this->children) && $this->xml->Группы) {
		0 ignored issues – show Bug introduced 2023-07-30 12:44 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_LNUMBER, expecting T_STRING or T_VARIABLE or '{' or '$' on line 31 at column 50 Loading history...
32	4	foreach ($this->xml->Группы->Группа as $group) {
33	4	$this->children[] = new Group($this->owner, $group);
34		}
35		}
36	5	return $this->children;
37		}
38
39		/**
40		* @return Group
41		*/
42	1	public function getParent()
43		{
44	1	if (!$this->parent) {
45	1	$parent = $this->xpath('../..')[0];
46	1	if ($parent->getName() === 'Группа') {
47	1	$this->parent = new Group($this->owner, $parent);
48		}
49		}
50	1	return $this->parent;
51		}
52
53		/**
54		* @param string $id
55		* @return null\|Group
56		*/
57	5	public function getChildById($id)
58		{
59	5	foreach ($this->getChildren() as $child) {
60	4	if ($child->id === $id) {
61	2	return $child;
62		}
63
64	3	if ($subChild = $child->getChildById($id)) {
65		return $subChild;
66		}
67		}
68	5	return null;
69		}
70		}

carono / php-commerceml

Push — master ( 1cde7b...7c9c8d )

Group::getChildById() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like