PropertyCollection::loadPropertiesValue() - Code Metrics - Inspection of "Добавлено сохранение путей исходных файдов загрузк..." - carono/php-commerceml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1cde7b...7c9c8d )

by Aleksandr

created 2023-07-30 12:35 UTC

PropertyCollection::loadPropertiesValue() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
eloc	6
dl	0
loc	8
ccs	7
cts	7
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php


namespace Zenwalker\CommerceML\Collections;


use Zenwalker\CommerceML\Model\Property;
use Zenwalker\CommerceML\Model\Simple;

/**
 * Class ValueProperties
 *
 * @package Zenwalker\CommerceML\Model
 */
class PropertyCollection extends Simple
{
    /**
     * @param $id
     * @return Property|null
     */
    public function getById($id)
    {
        foreach ($this as $property) {
            if ($property->id === (string)$id) {
                return $property;
            }
        }
        return null;
    }

    protected function loadPropertiesValue()
    {
        foreach ($this->xml->ЗначенияСвойства as $property) {

            $properties = $this->owner->classifier->getProperties();
            $object = clone $properties->getById((string)$property->Ид);
            $object->productId = (string)$this->xpath('..')[0]->Ид;
            $object->init();
            $this->append($object);
        }
    }

    protected function loadProperties()
    {
        foreach ($this->xml->Свойство as $property) {
            $this->append(new Property($this->owner, $property));
        }
    }

    public function init()
    {
        if (isset($this->xml->ЗначенияСвойства)) {
            $this->loadPropertiesValue();
        }
        if (isset($this->xml->Свойство)) {
            $this->loadProperties();
        }
        parent::init();
    }
}

1		<?php
2
3
4		namespace Zenwalker\CommerceML\Collections;
5
6
7		use Zenwalker\CommerceML\Model\Property;
8		use Zenwalker\CommerceML\Model\Simple;
9
10		/**
11		* Class ValueProperties
12		*
13		* @package Zenwalker\CommerceML\Model
14		*/
15		class PropertyCollection extends Simple
16		{
17		/**
18		* @param $id
19		* @return Property\|null
20		*/
21	2	public function getById($id)
22		{
23	2	foreach ($this as $property) {
24	2	if ($property->id === (string)$id) {
25	2	return $property;
26		}
27		}
28	1	return null;
29		}
30
31	2	protected function loadPropertiesValue()
32		{
33	2	foreach ($this->xml->ЗначенияСвойства as $property) {
		0 ignored issues – show Bug introduced 2023-07-30 12:44 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_LNUMBER, expecting T_STRING or T_VARIABLE or '{' or '$' on line 33 at column 29 Loading history...
34	2	$properties = $this->owner->classifier->getProperties();
35	2	$object = clone $properties->getById((string)$property->Ид);
36	2	$object->productId = (string)$this->xpath('..')[0]->Ид;
37	2	$object->init();
38	2	$this->append($object);
39		}
40	2	}
41
42	2	protected function loadProperties()
43		{
44	2	foreach ($this->xml->Свойство as $property) {
45	2	$this->append(new Property($this->owner, $property));
46		}
47	2	}
48
49	2	public function init()
50		{
51	2	if (isset($this->xml->ЗначенияСвойства)) {
52	2	$this->loadPropertiesValue();
53		}
54	2	if (isset($this->xml->Свойство)) {
55	2	$this->loadProperties();
56		}
57	2	parent::init();
58		}
59		}

carono / php-commerceml

Push — master ( 1cde7b...7c9c8d )

PropertyCollection::loadPropertiesValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like