PropertyCollection::loadPropertiesValue() - Code Metrics - Inspection of "scrutinizer" - carono/php-commerceml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c5cd13...f014ea )

by Aleksandr

created 2018-03-10 20:02 UTC

PropertyCollection::loadPropertiesValue() A

↳ Parent: PropertyCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	0

<?php


namespace Zenwalker\CommerceML\Model;


/**
 * Class ValueProperties
 *
 * @package Zenwalker\CommerceML\Model
 */
class PropertyCollection extends Simple
{
    /**
     * @param $id
     * @return Product|null
     */
    public function getById($id)
    {
        foreach ($this as $property) {
            if ($property->id == (string)$id) {
                return $property;
            }
        }
        return null;
    }

    protected function loadPropertiesValue()
    {
        foreach ($this->xml->ЗначенияСвойства as $property) {
            $properties = $this->owner->classifier->getProperties();
            $object = clone $properties->getById($property->Ид);
            $object->productId = (string)$this->xpath('..')[0]->Ид;

            $object->init();
            $this->append($object);
        }
    }

    protected function loadProperties()
    {
        foreach ($this->xml->Свойство as $property) {
            $this->append(new Property($this->owner, $property));
        }
    }

    public function init()
    {
        if ($this->xml && $this->xml->ЗначенияСвойства) {
            $this->loadPropertiesValue();
        }
        if ($this->xml && $this->xml->Свойство) {
            $this->loadProperties();
        }
        parent::init();
    }
}

1			<?php
2
3
4			namespace Zenwalker\CommerceML\Model;
5
6
7			/**
8			* Class ValueProperties
9			*
10			* @package Zenwalker\CommerceML\Model
11			*/
12			class PropertyCollection extends Simple
13			{
14			/**
15			* @param $id
16			* @return Product\|null
17			*/
18			public function getById($id)
19			{
20			foreach ($this as $property) {
21			if ($property->id == (string)$id) {
22			return $property;
23			}
24			}
25			return null;
26			}
27
28			protected function loadPropertiesValue()
29			{
30			foreach ($this->xml->ЗначенияСвойства as $property) {
31			$properties = $this->owner->classifier->getProperties();
32			$object = clone $properties->getById($property->Ид);
33			$object->productId = (string)$this->xpath('..')[0]->Ид;
			0 ignored issues – show Bug introduced 2018-02-08 09:01 UTC by Report Bug Copy Issue Report The property `productId` does not seem to exist on `Zenwalker\CommerceML\Model\Product`. Loading history...
34			$object->init();
35			$this->append($object);
36			}
37			}
38
39			protected function loadProperties()
40			{
41			foreach ($this->xml->Свойство as $property) {
42			$this->append(new Property($this->owner, $property));
43			}
44			}
45
46			public function init()
47			{
48			if ($this->xml && $this->xml->ЗначенияСвойства) {
49			$this->loadPropertiesValue();
50			}
51			if ($this->xml && $this->xml->Свойство) {
52			$this->loadProperties();
53			}
54			parent::init();
55			}
56			}

carono / php-commerceml

Push — master ( c5cd13...f014ea )

PropertyCollection::loadPropertiesValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like