Zenwalker\CommerceML\Model\OfferPackage

Complexity

Total Complexity

17

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Test Coverage

Coverage

56%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	loadXml()	0	7	2
A	getPriceTypes()	0	8	4
A	getOffersById()	0	9	3
A	getOffers()	0	8	5
A	getOfferById()	0	8	3

<?php


namespace Zenwalker\CommerceML\Model;


/**
 * Class OfferPackage
 *
 * @package Zenwalker\CommerceML\Model
 * @property Offer[] offers
 */
class OfferPackage extends Simple
{
    /**
     * @var Offer[]
     */
    protected $offers = [];

    /**
     * @var Simple[] array
     */
    protected $priceTypes = [];

    public function loadXml()
    {
        if ($this->owner->offersXml) {
            return $this->owner->offersXml->ПакетПредложений;
        }

        return null;
    }

    /**
     * @return Offer[]
     */
    public function getOffers()
    {
        if (!$this->offers && $this->xml && $this->xml->Предложения) {

The expression $this->offers of type Zenwalker\CommerceML\Model\Offer[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->xml->Предложения->Предложение as $offer) {
                $this->offers[] = new Offer($this->owner, $offer);
            }
        }
        return $this->offers;
    }

    /**
     * @return Simple[]
     */
    public function getPriceTypes()
    {
        if (!$this->priceTypes && $this->xml) {

The expression $this->priceTypes of type Zenwalker\CommerceML\Model\Simple[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->xpath('//c:ТипыЦен/c:ТипЦены') as $type) {
                $this->priceTypes[] = new Simple($this->owner, $type);
            }
        }
        return $this->priceTypes;
    }

    /**
     * @param $id
     * @return null|Offer
     * @deprecated will removed in 0.3.0
     */
    public function getOfferById($id)
    {
        foreach ($this->getOffers() as $offer) {
            if ($offer->getClearId() == $id) {
                return $offer;
            }
        }
        return null;
    }

    /**
     * @param $id
     * @return Offer[]
     */
    public function getOffersById($id)
    {
        $result = [];
        foreach ($this->getOffers() as $offer) {
            if ($offer->getClearId() === $id) {
                $result[] = $offer;
            }
        }
        return $result;
    }
}