Catalog::getById() - Code Metrics - Inspection of "unit test" - carono/php-commerceml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 01a1a8...191f59 )

by Aleksandr

created 2019-01-09 17:36 UTC

Catalog::getById() A

↳ Parent: Catalog

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	3

<?php


namespace Zenwalker\CommerceML\Model;

/**
 * import.xml -> Каталог
 *
 * Class Catalog
 *
 * @package Zenwalker\CommerceML\Model
 * @property Product[] $products
 */
class Catalog extends Simple
{
    /**
     * @var Product[]
     */
    protected $products = [];

    /**
     * @param $id
     * @return null|Product
     */
    public function getById($id)
    {
        foreach ($this->getProducts() as $product) {
            if ($product->id == $id) {
                return $product;
            }
        }
        return null;
    }

    /**
     * @return Product[]
     */
    public function getProducts()
    {
        if (empty($this->products) && $this->xml && $this->xml->Товары) {
            foreach ($this->xml->Товары->Товар as $product) {
                $this->products[] = new Product($this->owner, $product);
            }
        }
        return $this->products;
    }

    /**
     * @return \SimpleXMLElement
     */
    public function loadXml()
    {
        if ($this->owner->importXml) {
            return $this->owner->importXml->Каталог;
        } else {
            return null;
        }
    }
}

1		<?php
2
3
4		namespace Zenwalker\CommerceML\Model;
5
6		/**
7		* import.xml -> Каталог
8		*
9		* Class Catalog
10		*
11		* @package Zenwalker\CommerceML\Model
12		* @property Product[] $products
13		*/
14		class Catalog extends Simple
15		{
16		/**
17		* @var Product[]
18		*/
19		protected $products = [];
20
21		/**
22		* @param $id
23		* @return null\|Product
24		*/
25	1	public function getById($id)
26		{
27	1	foreach ($this->getProducts() as $product) {
28	1	if ($product->id == $id) {
29	1	return $product;
30		}
31		}
32	1	return null;
33		}
34
35		/**
36		* @return Product[]
37		*/
38	1	public function getProducts()
39		{
40	1	if (empty($this->products) && $this->xml && $this->xml->Товары) {
41	1	foreach ($this->xml->Товары->Товар as $product) {
42	1	$this->products[] = new Product($this->owner, $product);
43		}
44		}
45	1	return $this->products;
46		}
47
48		/**
49		* @return \SimpleXMLElement
50		*/
51	9	public function loadXml()
52		{
53	9	if ($this->owner->importXml) {
54	9	return $this->owner->importXml->Каталог;
55		} else {
56		return null;
57		}
58		}
59		}

carono / php-commerceml

Push — master ( 01a1a8...191f59 )

Catalog::getById() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like