CORS::process() - Code Metrics - Inspection of "add cors handler" - carno-php/web - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 79f846...b59e9f )

by Shiyu

created 2019-01-09 03:23 UTC

CORS::process() B

↳ Parent: CORS

Complexity

Conditions	9
Paths	64

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	9
nc	64
nop	2
dl	0
loc	16
rs	8.0555
c	0
b	0
f	0

<?php
/**
 * Rule of CORS
 * User: moyo
 * Date: 2019-01-08
 * Time: 15:22
 */

namespace Carno\Web\Policy\Rules;

use Carno\HTTP\Standard\Response;
use Carno\HTTP\Standard\ServerRequest;

class CORS
{
    /**
     * @var string
     */
    private $origin = '*';

    /**
     * @var array
     */
    private $methods = [];

    /**
     * @var array
     */
    private $headers = [];

    /**
     * @var array
     */
    private $exposes = [];

    /**
     * @var bool
     */
    private $credentials = false;

    /**
     * @var int
     */
    private $expired = 0;

    /**
     * CORS constructor.
     * @param string $origin
     */
    public function __construct(string $origin)
    {
        $this->origin = $origin;
    }

    /**
     * @param string ...$methods
     * @return static
     */
    public function methods(string ...$methods) : self
    {
        $this->methods = array_map('strtoupper', $methods);
        return $this;
    }

    /**
     * @param string ...$headers
     * @return static
     */
    public function headers(string ...$headers) : self
    {
        $this->headers = $headers;
        return $this;
    }

    /**
     * @param string ...$headers
     * @return static
     */
    public function exposes(string ...$headers) : self
    {
        $this->exposes = $headers;
        return $this;
    }

    /**
     * @param bool $yes
     * @return static
     */
    public function credentials(bool $yes) : self
    {
        $this->credentials = $yes;
        return $this;
    }

    /**
     * @param int $seconds
     * @return static
     */
    public function expired(int $seconds) : self
    {
        $this->expired = $seconds;
        return $this;
    }

    /**
     * @param ServerRequest $sr
     * @param Response $respond
     * @return Response
     */
    final public function process(ServerRequest $sr, Response $respond) : Response
    {
        if ($this->origin === '*' && $this->credentials) {
            $origin = $sr->getHeaderLine('Origin') ?: '*';
        }

        $respond->withHeader('Access-Control-Allow-Origin', $origin ?? $this->origin);

        $this->methods && $respond->withHeader('Access-Control-Allow-Methods', $this->methods);

        $this->headers && $respond->withHeader('Access-Control-Allow-Headers', $this->headers);

        $this->exposes && $respond->withHeader('Access-Control-Expose-Headers', $this->exposes);


        $this->credentials && $respond->withHeader('Access-Control-Allow-Credentials', 'true');
        $this->expired > 0 && $respond->withHeader('Access-Control-Max-Age', $this->expired);

        return $respond;
    }
}


1			<?php
2			/**
3			* Rule of CORS
4			* User: moyo
5			* Date: 2019-01-08
6			* Time: 15:22
7			*/
8
9			namespace Carno\Web\Policy\Rules;
10
11			use Carno\HTTP\Standard\Response;
12			use Carno\HTTP\Standard\ServerRequest;
13
14			class CORS
15			{
16			/**
17			* @var string
18			*/
19			private $origin = '*';
20
21			/**
22			* @var array
23			*/
24			private $methods = [];
25
26			/**
27			* @var array
28			*/
29			private $headers = [];
30
31			/**
32			* @var array
33			*/
34			private $exposes = [];
35
36			/**
37			* @var bool
38			*/
39			private $credentials = false;
40
41			/**
42			* @var int
43			*/
44			private $expired = 0;
45
46			/**
47			* CORS constructor.
48			* @param string $origin
49			*/
50			public function __construct(string $origin)
51			{
52			$this->origin = $origin;
53			}
54
55			/**
56			* @param string ...$methods
57			* @return static
58			*/
59			public function methods(string ...$methods) : self
60			{
61			$this->methods = array_map('strtoupper', $methods);
62			return $this;
63			}
64
65			/**
66			* @param string ...$headers
67			* @return static
68			*/
69			public function headers(string ...$headers) : self
70			{
71			$this->headers = $headers;
72			return $this;
73			}
74
75			/**
76			* @param string ...$headers
77			* @return static
78			*/
79			public function exposes(string ...$headers) : self
80			{
81			$this->exposes = $headers;
82			return $this;
83			}
84
85			/**
86			* @param bool $yes
87			* @return static
88			*/
89			public function credentials(bool $yes) : self
90			{
91			$this->credentials = $yes;
92			return $this;
93			}
94
95			/**
96			* @param int $seconds
97			* @return static
98			*/
99			public function expired(int $seconds) : self
100			{
101			$this->expired = $seconds;
102			return $this;
103			}
104
105			/**
106			* @param ServerRequest $sr
107			* @param Response $respond
108			* @return Response
109			*/
110			final public function process(ServerRequest $sr, Response $respond) : Response
111			{
112			if ($this->origin === '*' && $this->credentials) {
113			$origin = $sr->getHeaderLine('Origin') ?: '*';
114			}
115
116			$respond->withHeader('Access-Control-Allow-Origin', $origin ?? $this->origin);
117
118			$this->methods && $respond->withHeader('Access-Control-Allow-Methods', $this->methods);
			0 ignored issues – show Bug Best Practice introduced 2019-01-09 03:25 UTC by Report Bug Copy Issue Report The expression `$this->methods` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
119			$this->headers && $respond->withHeader('Access-Control-Allow-Headers', $this->headers);
			0 ignored issues – show Bug Best Practice introduced 2019-01-09 03:25 UTC by Report Bug Copy Issue Report The expression `$this->headers` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
120			$this->exposes && $respond->withHeader('Access-Control-Expose-Headers', $this->exposes);
			0 ignored issues – show Bug Best Practice introduced 2019-01-09 03:25 UTC by Report Bug Copy Issue Report The expression `$this->exposes` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
121
122			$this->credentials && $respond->withHeader('Access-Control-Allow-Credentials', 'true');
123			$this->expired > 0 && $respond->withHeader('Access-Control-Max-Age', $this->expired);
124
125			return $respond;
126			}
127			}
128

carno-php / web

Push — master ( 79f846...b59e9f )

CORS::process() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like