carno-php / rpc

src/Chips/NamedKit.php

<?php
/**
 * Named kit
 * User: moyo
 * Date: 30/10/2017
 * Time: 10:51 AM
 */

namespace Carno\RPC\Chips;

use Carno\RPC\Service\Scanner;

trait NamedKit
{
    /**
     * @param string $class
     * @return string
     */
    private function namedServer(string $class) : string
    {
        $segments = array_map(static function ($p) {
            return lcfirst($p);
        }, explode('\\', $class));

        while ($segments) {

The expression $segments of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            if (Scanner::CLIENTS_NAME === $pop = array_pop($segments)) {

The assignment to $pop is dead and can be removed.

                break;
            }
        }

        return implode('.', $segments);
    }
}