Binary::short() - Code Metrics - carno-php/nsq - Measure and Improve Code Quality continuously with Scrutinizer

Binary::short() A
last analyzed 2019-04-04 16:41 UTC

↳ Parent: Binary

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
/**
 * Binary ops
 * User: moyo
 * Date: 27/02/2018
 * Time: 2:14 PM
 */

namespace Carno\NSQ\Protocol;

class Binary
{
    /**
     * Read and unpack short (2 bytes) from buffer
     * @param Buffer $buffer
     * @return int
     */
    public static function short(Buffer $buffer) : ?int
    {
        return unpack('n', $buffer->read(2))[1] ?? null;
    }

    /**
     * Read and unpack integer (4 bytes) from buffer
     * @param Buffer $buffer
     * @return int
     */
    public static function int(Buffer $buffer) : ?int
    {
        return ($up = unpack('N', $buffer->read(4))[1] ?? null) ? sprintf('%u', $up) : null;

    }

    /**
     * Read and unpack long (8 bytes) from buffer
     * @param Buffer $buffer
     * @return string
     */
    public static function long(Buffer $buffer) : ?string
    {
        return is_array($hi = unpack('N', $buffer->read(4))) && is_array($lo = unpack('N', $buffer->read(4)))
            ? bcadd(bcmul(sprintf('%u', $hi[1]), '4294967296'), sprintf('%u', $lo[1]))
            : null
        ;
    }

    /**
     * Read raw string from buffer
     * @param Buffer $buffer
     * @param int $size
     * @return string
     */
    public static function string(Buffer $buffer, int $size) : string
    {
        return $buffer->read($size);
    }
}


1			<?php
2			/**
3			* Binary ops
4			* User: moyo
5			* Date: 27/02/2018
6			* Time: 2:14 PM
7			*/
8
9			namespace Carno\NSQ\Protocol;
10
11			class Binary
12			{
13			/**
14			* Read and unpack short (2 bytes) from buffer
15			* @param Buffer $buffer
16			* @return int
17			*/
18			public static function short(Buffer $buffer) : ?int
19			{
20			return unpack('n', $buffer->read(2))[1] ?? null;
21			}
22
23			/**
24			* Read and unpack integer (4 bytes) from buffer
25			* @param Buffer $buffer
26			* @return int
27			*/
28			public static function int(Buffer $buffer) : ?int
29			{
30			return ($up = unpack('N', $buffer->read(4))[1] ?? null) ? sprintf('%u', $up) : null;
			0 ignored issues – show Bug Best Practice introduced 2019-04-04 16:41 UTC by Report Bug Copy Issue Report The expression `return $up = unpack('N',...rintf('%u', $up) : null` could return the type `string` which is incompatible with the type-hinted return `integer\|null`. Consider adding an additional type-check to rule them out. Loading history...
31			}
32
33			/**
34			* Read and unpack long (8 bytes) from buffer
35			* @param Buffer $buffer
36			* @return string
37			*/
38			public static function long(Buffer $buffer) : ?string
39			{
40			return is_array($hi = unpack('N', $buffer->read(4))) && is_array($lo = unpack('N', $buffer->read(4)))
41			? bcadd(bcmul(sprintf('%u', $hi[1]), '4294967296'), sprintf('%u', $lo[1]))
42			: null
43			;
44			}
45
46			/**
47			* Read raw string from buffer
48			* @param Buffer $buffer
49			* @param int $size
50			* @return string
51			*/
52			public static function string(Buffer $buffer, int $size) : string
53			{
54			return $buffer->read($size);
55			}
56			}
57

carno-php / nsq

Binary::short() A last analyzed 2019-04-04 16:41 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Binary::short() A
last analyzed 2019-04-04 16:41 UTC