carno-php / mysql

src/Paginator/Paged.php

<?php
/**
 * Paged builder
 * User: moyo
 * Date: 2018/4/19
 * Time: 2:34 PM
 */

namespace Carno\Database\SQL\Paginator;

trait Paged
{
    /**
     * default page size
     * @var int
     */
    private $pSize = 20;

    /**
     * @param mixed ...$input
     * @return Pagination
     */
    public function paged(...$input)
    {
        list($page, $size) =
            count($input) === 1 && is_object($input[0])
                ? $this->import($input[0])
                : [$input[0] ?? 1, $input[1] ?? $this->pSize]
        ;

        $total = yield $this->count();

The expression yield $this->count() returns the type Generator which is incompatible with the documented return type Carno\Database\SQL\Paginator\Pagination.

It seems like count() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $last = ceil($total / $size);

        $next = min($page + 1, $last);
        $prev = max($page - 1, 1);

        $this->limit(($page - 1) * $size, $size);

It seems like limit() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return new Pagination($total, $size, $prev, $page, $next, $last, yield $this->list());

It seems like list() must be provided by classes using this trait. How about adding it as abstract method to this trait?

$last of type double is incompatible with the type integer expected by parameter $last of Carno\Database\SQL\Paginator\Pagination::__construct().

    }

    /**
     * @param object $source
     * @return array
     */
    private function import(object $source) : array
    {
        $page = $size = null;

        if (method_exists($source, 'getPage')) {
            $page = (int)$source->getPage();
        }

        if (method_exists($source, 'getSize')) {
            $size = (int)$source->getSize();
        }

        return [$page ?: 1, $size ?: $this->pSize];
    }
}