carno-php / mysql

src/Kit.php

<?php
/**
 * Database/SQL kit
 * User: moyo
 * Date: 22/12/2017
 * Time: 3:37 PM
 */

namespace Carno\Database\SQL;

use Carno\Database\Contracts\Executable;

trait Kit
{
    /**
     * available features
     * @var array
     */
    private $features = [
        'timestamps',
    ];

    /**
     * loaded chips
     * @var array
     */
    private $chips = [];

    /**
     * @param string $name
     * @param Executable $executable
     * @return Builder
     */
    final public function table(string $name, Executable $executable = null) : Builder
    {
        return new Builder($name, $executable ?: $this, $this->fcInjectors());

It seems like $executable ?: $this can also be of type Carno\Database\SQL\Kit; however, parameter $executor of Carno\Database\SQL\Builder::__construct() does only seem to accept Carno\Database\Contracts\Executable, maybe add an additional type check?

    }

    /**
     * @return array
     */
    final private function fcInjectors() : array
    {
        if ($this->chips) {

The expression $this->chips of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->chips;
        }

        foreach ($this->features as $feature) {
            if (method_exists($this, $chip = sprintf('%sChip', $feature))) {
                $observers = $this->$chip();
                foreach ($observers as $observer) {
                    list($action, $program) = $observer;
                    $this->chips[$action][] = $program;
                }
            }
        }

        return $this->chips;
    }
}