carno-php / mysql

src/Actions/Update.php

<?php
/**
 * Update data
 * User: moyo
 * Date: 25/12/2017
 * Time: 3:24 PM
 */

namespace Carno\Database\SQL\Actions;

use Carno\Database\Results\Updated;
use Carno\Database\SQL\Action;

trait Update
{
    /**
     * @param array ...$maps
     * @return int
     */
    public function update(...$maps)
    {
        $this->actTrigger(Action::UPDATE, $this);

It seems like actTrigger() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $maps && $this->data(...$maps);

It seems like data() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The expression $maps of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        /**
         * @var Updated $result
         */
        $result = yield $this->exec($this->sql(Action::UPDATE));

The expression yield $this->exec($this->sql(Carno\Database\SQL\Action::UPDATE)) returns the type Generator which is incompatible with the documented return type integer.

It seems like sql() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like exec() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $result->rows();
    }
}