carno-php / mysql

src/Actions/Observer.php

<?php
/**
 * Action observer
 * User: moyo
 * Date: 25/12/2017
 * Time: 5:56 PM
 */

namespace Carno\Database\SQL\Actions;

use Carno\Database\SQL\Builder;
use Closure;

trait Observer
{
    /**
     * @var Closure[]
     */
    private $actWatchers = [];

    /**
     * @var Closure[]
     */
    private $rsWatchers = [];

    /**
     * @param int $action
     * @param Closure ...$programs
     */
    protected function actWatching(int $action, Closure ...$programs) : void
    {
        $this->actWatchers[$action] = array_merge($this->actWatchers[$action] ?? [], $programs);

It seems like $this->actWatchers[$action] ?? array() can also be of type Closure; however, parameter $array1 of array_merge() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param int $action
     * @param Builder $instance
     */
    protected function actTrigger(int $action, Builder $instance) : void
    {
        foreach ($this->actWatchers[$action] ?? [] as $watcher) {
            $watcher($instance);
        }
    }

    /**
     * @param Closure ...$programs
     */
    protected function rsWatching(Closure ...$programs) : void
    {
        $this->rsWatchers = array_merge($this->rsWatchers, $programs);
    }

    /**
     * @param array $rows
     * @return array
     */
    protected function rsTrigger(array $rows)
    {
        foreach ($this->rsWatchers as $watcher) {
            $rows = yield $watcher($rows);

The expression yield $watcher($rows) returns the type Generator which is incompatible with the documented return type array.

        }

        return $rows;
    }
}