carno-php / mysql

src/Actions/Getter.php

<?php
/**
 * Get data
 * User: moyo
 * Date: 22/12/2017
 * Time: 4:45 PM
 */

namespace Carno\Database\SQL\Actions;

use Carno\Database\Results\Selected;
use Carno\Database\SQL\Action;

trait Getter
{
    /**
     * @return array
     */
    public function get()
    {
        $this->actTrigger(Action::SELECT, $this);

It seems like actTrigger() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->limit(1);

It seems like limit() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        /**
         * @var Selected $rows
         */
        $rows = yield $this->exec($this->sql(Action::SELECT));

The expression yield $this->exec($this->sql(Carno\Database\SQL\Action::SELECT)) returns the type Generator which is incompatible with the documented return type array.

It seems like sql() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like exec() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($rows->count() > 0) {
            return (yield $this->rsTrigger((array)$rows))[0];

It seems like rsTrigger() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return [];
    }

    /**
     * @return array
     */
    public function list()
    {
        $this->actTrigger(Action::SELECT, $this);

        /**
         * @var Selected $rows
         */
        $rows = yield $this->exec($this->sql(Action::SELECT));

The expression yield $this->exec($this->sql(Carno\Database\SQL\Action::SELECT)) returns the type Generator which is incompatible with the documented return type array.

        if ($rows->count() > 0) {
            return yield $this->rsTrigger((array)$rows);
        }

        return [];
    }
}