carno-php / mysql

src/Actions/Delete.php

<?php
/**
 * Delete data
 * User: moyo
 * Date: 25/12/2017
 * Time: 3:27 PM
 */

namespace Carno\Database\SQL\Actions;

use Carno\Database\Results\Updated;
use Carno\Database\SQL\Action;

trait Delete
{
    /**
     * @param array ...$conditions
     * @return int
     */
    public function delete(...$conditions)
    {
        $this->actTrigger(Action::DELETE, $this);

It seems like actTrigger() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $conditions && $this->where(...$conditions);

The expression $conditions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

It seems like where() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        /**
         * @var Updated $result
         */
        $result = yield $this->exec($this->sql(Action::DELETE));

It seems like sql() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The expression yield $this->exec($this->sql(Carno\Database\SQL\Action::DELETE)) returns the type Generator which is incompatible with the documented return type integer.

It seems like exec() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $result->rows();
    }
}