carno-php / mysql

src/Actions/Aggregate.php

<?php
/**
 * Aggregate functions
 * User: moyo
 * Date: 2018/4/19
 * Time: 11:13 AM
 */

namespace Carno\Database\SQL\Actions;

trait Aggregate
{
    /**
     * @var string
     */
    private $ark = 'A_R_K';

    /**
     * @param mixed ...$conditions
     * @return bool
     */
    public function exists(...$conditions)
    {
        $conditions && $this->where(...$conditions);

The expression $conditions of type array<integer,mixed> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

It seems like where() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return (yield $this->count()) > 0 ? true : false;

The expression yield $this->count() returns the type Generator which is incompatible with the documented return type boolean.

    }

    /**
     * @param string $expr
     * @return int
     */
    public function count(string $expr = '1')
    {
        return (int) yield $this->calc(sprintf('COUNT(%s)', $expr));

The expression yield $this->calc(sprintf('COUNT(%s)', $expr)) returns the type Generator which is incompatible with the documented return type integer.

    }

    /**
     * @param string $expr
     * @return float
     */
    public function sum(string $expr)
    {
        return (float) yield $this->calc(sprintf('SUM(%s)', $expr));

The expression yield $this->calc(sprintf('SUM(%s)', $expr)) returns the type Generator which is incompatible with the documented return type double.

    }

    /**
     * @param string $expr
     * @return float
     */
    public function max(string $expr)
    {
        return (float) yield $this->calc(sprintf('MAX(%s)', $expr));

The expression yield $this->calc(sprintf('MAX(%s)', $expr)) returns the type Generator which is incompatible with the documented return type double.

    }

    /**
     * @param string $expr
     * @return float
     */
    public function min(string $expr)
    {
        return (float) yield $this->calc(sprintf('MIN(%s)', $expr));

The expression yield $this->calc(sprintf('MIN(%s)', $expr)) returns the type Generator which is incompatible with the documented return type double.

    }

    /**
     * @param string $expr
     * @return float
     */
    public function avg(string $expr)
    {
        return (float) yield $this->calc(sprintf('AVG(%s)', $expr));

The expression yield $this->calc(sprintf('AVG(%s)', $expr)) returns the type Generator which is incompatible with the documented return type double.

    }

    /**
     * @param string $expr
     * @return float
     */
    private function calc(string $expr)
    {
        $stmt = $this->backup('select', 'orders');

        $this->select(sprintf('%s AS %s', $expr, $this->ark));

It seems like select() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $result = (yield $this->get())[$this->ark] ?? 0;

The expression yield $this->get() returns the type Generator which is incompatible with the documented return type double.

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->restore($stmt);

        return $result;
    }

    /**
     * @param string ...$builds
     * @return array
     */
    private function backup(string ...$builds) : array
    {
        $saved = [];

        foreach ($builds as $build) {
            if (property_exists($this, $pt = sprintf('b%s', ucfirst($build)))) {
                $saved[$build] = $this->$pt;
                $this->$pt = null;
            }
        }

        return $saved;
    }

    /**
     * @param array $previous
     */
    private function restore(array $previous) : void
    {
        foreach ($previous as $build => $saved) {
            if (property_exists($this, $pt = sprintf('b%s', ucfirst($build)))) {
                $this->$pt = $saved;
            }
        }
    }
}