Carno\Monitor\Chips\Metrical\Reporting

Complexity

Total Complexity

5

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	3	1
A	deregister()	0	3	1
A	reporting()	0	9	2
A	typed()	0	8	1

<?php
/**
 * As reporter
 * User: moyo
 * Date: 2018/5/18
 * Time: 5:54 PM
 */

namespace Carno\Monitor\Chips\Metrical;

use Carno\Monitor\Contracts\Metrical;
use Carno\Monitor\Harvester;
use Carno\Monitor\Metrics\Counter;
use Carno\Monitor\Metrics\Gauge;
use Carno\Monitor\Metrics\Histogram;
use Carno\Monitor\Metrics\Summary;

trait Reporting
{
    /**
     * @param int $period
     * @return static
     */
    public function register(int $period = 5) : self
    {
        return Harvester::join($this, $period);

The expression return Carno\Monitor\Harvester::join($this, $period) returns the type Carno\Monitor\Contracts\Telemetry which is incompatible with the type-hinted return Carno\Monitor\Chips\Metrical\Reporting.

$this of type Carno\Monitor\Chips\Metrical\Reporting is incompatible with the type Carno\Monitor\Contracts\Telemetry expected by parameter $source of Carno\Monitor\Harvester::join().

    }

    /**
     */
    public function deregister() : void
    {
        Harvester::forget($this);

$this of type Carno\Monitor\Chips\Metrical\Reporting is incompatible with the type Carno\Monitor\Contracts\Telemetry expected by parameter $source of Carno\Monitor\Harvester::forget().

    }

    /**
     * @return array
     */
    public function reporting() : array
    {
        return empty($this->name) ? [] : [
            $this->typed(),
            $this->name,
            $this->grouped,
            $this->description,
            $this->labels,
            $this->data()

It seems like data() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        ];
    }

    /**
     * @return string
     */
    private function typed() : string
    {
        return [
            Counter::class => Metrical::COUNTER,
            Gauge::class => Metrical::GAUGE,
            Histogram::class => Metrical::HISTOGRAM,
            Summary::class => Metrical::SUMMARY,
        ][static::class];
    }
}