Carno\Monitor\Chips\Metrical\HBuckets

Complexity

Total Complexity

7

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	fixed()	0	3	1
A	bucketing()	0	9	2
A	linear()	0	10	2
A	exponential()	0	10	2

<?php
/**
 * Histogram buckets
 * User: moyo
 * Date: 2018/5/18
 * Time: 11:49 AM
 */

namespace Carno\Monitor\Chips\Metrical;

trait HBuckets
{
    /**
     * @var array
     */
    private $bounds = [];

    /**
     * @param float ...$bounds
     * @return static
     */
    public function fixed(float ...$bounds) : self
    {
        return $this->bucketing($bounds);
    }

    /**
     * @param float $start
     * @param float $width
     * @param int $count
     * @return static
     */
    public function linear(float $start, float $width, int $count) : self
    {
        $bounds = [];

        for ($i = 0; $i < $count; $i ++) {
            $bounds[] = $start;
            $start += $width;
        }

        return $this->bucketing($bounds);
    }

    /**
     * @param float $start
     * @param float $factor
     * @param int $count
     * @return static
     */
    public function exponential(float $start, float $factor, int $count) : self
    {
        $bounds = [];

        for ($i = 0; $i < $count; $i ++) {
            $bounds[] = $start;
            $start *= $factor;
        }

        return $this->bucketing($bounds);
    }

    /**
     * @param array $bounds
     * @return static
     */
    private function bucketing(array $bounds) : self
    {
        $this->bounds = $bounds;

        foreach ($bounds as $idx => $bound) {
            $this->buckets[$idx] = 0;

The property buckets does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        return $this;
    }
}