Responding::makeResponse() - Code Metrics - carno-php/http - Measure and Improve Code Quality continuously with Scrutinizer

Responding::makeResponse() A
last analyzed 2019-03-25 02:29 UTC

↳ Parent: Responding

Complexity

Conditions	4
Paths	8

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	12
dl	0
loc	21
c	0
b	0
f	0
rs	9.8666
cc	4
nc	8
nop	1

<?php
/**
 * HTTP Encoder
 * User: moyo
 * Date: 08/01/2018
 * Time: 4:04 PM
 */

namespace Carno\HTTP\Powered\Native\Parser;

use Psr\Http\Message\ResponseInterface;

class Responding
{
    private const LENGTH = 'Content-length';

    /**
     * @var string
     */
    private $socket = null;

    /**
     * Encoder constructor.
     * @param Protocol $socket
     */
    public function __construct(Protocol $socket)
    {
        $this->socket = $socket;

    }

    /**
     * @param ResponseInterface $response
     */
    public function makeResponse(ResponseInterface $response) : void
    {
        $lines[] = sprintf(

            'HTTP/%s %d %s',
            $response->getProtocolVersion(),
            $response->getStatusCode(),
            $response->getReasonPhrase()
        );

        if (!$response->hasHeader(self::LENGTH)) {
            $response->withHeader(self::LENGTH, $response->getBody()->getSize());
        }

        foreach ($response->getHeaders() as $name => $values) {
            $lines[] = sprintf('%s: %s', $name, implode(',', $values));
        }

        $this->socket->write(implode(Protocol::CRLF, $lines).Protocol::SPLIT);

        if ($response->getBody()->getSize() > 0) {
            $this->socket->write((string)$response->getBody());
        }
    }
}


1			<?php
2			/**
3			* HTTP Encoder
4			* User: moyo
5			* Date: 08/01/2018
6			* Time: 4:04 PM
7			*/
8
9			namespace Carno\HTTP\Powered\Native\Parser;
10
11			use Psr\Http\Message\ResponseInterface;
12
13			class Responding
14			{
15			private const LENGTH = 'Content-length';
16
17			/**
18			* @var string
19			*/
20			private $socket = null;
21
22			/**
23			* Encoder constructor.
24			* @param Protocol $socket
25			*/
26			public function __construct(Protocol $socket)
27			{
28			$this->socket = $socket;
			0 ignored issues – show Documentation Bug introduced 2018-09-19 15:58 UTC by Report Bug Copy Issue Report It seems like `$socket` of type `Carno\HTTP\Powered\Native\Parser\Protocol` is incompatible with the declared type `string` of property `$socket`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29			}
30
31			/**
32			* @param ResponseInterface $response
33			*/
34			public function makeResponse(ResponseInterface $response) : void
35			{
36			$lines[] = sprintf(
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-09-19 15:58 UTC by Report Bug Copy Issue Report `$lines` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$lines = array();` before regardless. Loading history...
37			'HTTP/%s %d %s',
38			$response->getProtocolVersion(),
39			$response->getStatusCode(),
40			$response->getReasonPhrase()
41			);
42
43			if (!$response->hasHeader(self::LENGTH)) {
44			$response->withHeader(self::LENGTH, $response->getBody()->getSize());
45			}
46
47			foreach ($response->getHeaders() as $name => $values) {
48			$lines[] = sprintf('%s: %s', $name, implode(',', $values));
49			}
50
51			$this->socket->write(implode(Protocol::CRLF, $lines).Protocol::SPLIT);
52
53			if ($response->getBody()->getSize() > 0) {
54			$this->socket->write((string)$response->getBody());
55			}
56			}
57			}
58

carno-php / http

Responding::makeResponse() A last analyzed 2019-03-25 02:29 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Responding::makeResponse() A
last analyzed 2019-03-25 02:29 UTC