Issues (19)

src/Components/Context.php (1 issue)

Labels
Severity
1
<?php
2
/**
3
 * HTTP RPC context sharing
4
 * User: moyo
5
 * Date: 19/03/2018
6
 * Time: 9:43 PM
7
 */
8
9
namespace Carno\HRPC\Client\Components;
10
11
use Carno\Console\Component;
12
use Carno\Console\Contracts\Application;
13
use Carno\Console\Contracts\Bootable;
14
use Carno\Container\DI;
15
use Carno\HRPC\Client\Handlers\ContextPacking;
16
use Carno\RPC\Client;
17
use Carno\RPC\Contracts\Client\Invoker;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Carno\HRPC\Client\Components\Invoker. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
18
19
class Context extends Component implements Bootable
20
{
21
    private const CONF_KEY = 'ctx.trans.allowed';
22
23
    /**
24
     * @var array
25
     */
26
    protected $dependencies = [Invoker::class];
27
28
    /**
29
     * @param Application $app
30
     */
31
    public function starting(Application $app) : void
32
    {
33
        $handler = static function ($value) {
34
            if (is_null($value)) {
35
                Client::layers()->remove(ContextPacking::class);
36
                return;
37
            }
38
39
            $keys = explode('|', $value);
40
41
            if (empty($keys)) {
42
                return;
43
            }
44
45
            /**
46
             * @var ContextPacking $client
47
             */
48
49
            $client = DI::has(ContextPacking::class)
50
                ? DI::get(ContextPacking::class)
51
                : DI::set(ContextPacking::class, new ContextPacking())
52
            ;
53
54
            $client->keys(...$keys);
55
56
            Client::layers()->has(ContextPacking::class)
57
                || Client::layers()->prepend(Invoker::class, $client);
58
        };
59
60
        $app->starting()->add(static function () use ($app, $handler) {
61
            $app->conf()->watching(self::CONF_KEY, $handler);
62
        });
63
    }
64
}
65