Carno\HRPC\Accel\Marking

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	commTCP()	0	10	3
A	viaTCP()	0	3	1

<?php
/**
 * Feature marking for service discovery
 * User: moyo
 * Date: 2018/8/1
 * Time: 11:13 AM
 */

namespace Carno\HRPC\Accel;

use Carno\Cluster\Contracts\Tags;
use Carno\HRPC\Accel\Contracts\Named;

class Marking
{
    /**
     * @param int $port
     * @return string
     */
    public static function viaTCP(int $port) : string
    {
        return Tags::CMD . sprintf('%s:%s::%d', Named::KEY, Named::TCP, $port);
    }

    /**
     * @param string $tagging
     * @return int
     */
    public static function commTCP(string $tagging) : int
    {
        if (substr($tagging, 0, strlen(Named::KEY)) === Named::KEY) {
            [1 => $proto, 3 => $port] = explode(':', $tagging);
            switch ($proto) {
                case Named::TCP:
                    return $port;

The expression return $port returns the type string which is incompatible with the type-hinted return integer.

            }
        }
        return 0;
    }
}