carno-php / database

src/Programs/Transaction.php

<?php
/**
 * Transaction program
 * User: moyo
 * Date: 03/11/2017
 * Time: 11:43 AM
 */

namespace Carno\Database\Programs;

use Carno\Database\Contracts\Executable;
use Carno\Database\Contracts\Transaction as TransAPI;
use Carno\Promise\Promised;

class Transaction implements TransAPI, Executable
{
    /**
     * @var TransAPI|Executable
     */
    private $link = null;

    /**
     * @var Promised
     */
    private $wStart = null;

    /**
     * @var Promised
     */
    private $wCommit = null;

    /**
     * @var Promised
     */
    private $wRollback = null;

    /**
     * Transaction constructor.
     * @param TransAPI $link
     * @param Promised $start
     * @param Promised $commit
     * @param Promised $rollback
     */
    public function __construct(
        TransAPI $link,
        Promised $start,
        Promised $commit,
        Promised $rollback
    ) {
        $this->link = $link;

        $this->wStart = $start;
        $this->wCommit = $commit;
        $this->wRollback = $rollback;
    }

    /**
     * @return Executable
     */
    public function link() : Executable
    {
        return $this->link;

The expression return $this->link could return the type Carno\Database\Contracts\Transaction which is incompatible with the type-hinted return Carno\Database\Contracts\Executable. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param string $sql
     * @param array $bind
     * @return Promised
     */
    public function execute(string $sql, array $bind = [])
    {
        return $this->link->execute($sql, $bind);

The expression return $this->link->execute($sql, $bind) also could return the type Carno\Database\Results\Created|Carno\Database\Results\Selected|Carno\Database\Results\Updated which is incompatible with the documented return type Carno\Promise\Promised.

The method execute() does not exist on Carno\Database\Contracts\Transaction. Since it exists in all sub-types, consider adding an abstract or default implementation to Carno\Database\Contracts\Transaction.

    }

    /**
     * @deprecated
     * @param string $data
     * @return string
     */
    public function escape(string $data) : string
    {
        return $this->link->escape($data);

The function Carno\Database\Contracts\Executable::escape() has been deprecated.

The method escape() does not exist on Carno\Database\Contracts\Transaction. Since it exists in all sub-types, consider adding an abstract or default implementation to Carno\Database\Contracts\Transaction.

    }

    /**
     * @return Promised
     */
    public function begin()
    {
        yield $this->link->begin();

The method begin() does not exist on Carno\Database\Contracts\Executable. It seems like you code against a sub-type of Carno\Database\Contracts\Executable such as Carno\Database\Connectors\MySQL or Carno\Database\Programs\Transaction.

The expression yield $this->link->begin() returns the type Generator which is incompatible with the documented return type Carno\Promise\Promised.

        $this->wStart->resolve();
        return $this->wStart;
    }

    /**
     * @return Promised
     */
    public function commit()
    {
        yield $this->link->commit();

The expression yield $this->link->commit() returns the type Generator which is incompatible with the documented return type Carno\Promise\Promised.

The method commit() does not exist on Carno\Database\Contracts\Executable. It seems like you code against a sub-type of Carno\Database\Contracts\Executable such as Carno\Database\Connectors\MySQL or Carno\Database\Programs\Transaction.

        $this->wCommit->resolve();
        return $this->wCommit;
    }

    /**
     * @return Promised
     */
    public function rollback()
    {
        yield $this->link->rollback();

The method rollback() does not exist on Carno\Database\Contracts\Executable. It seems like you code against a sub-type of Carno\Database\Contracts\Executable such as Carno\Database\Connectors\MySQL or Carno\Database\Programs\Transaction.

The expression yield $this->link->rollback() returns the type Generator which is incompatible with the documented return type Carno\Promise\Promised.

        $this->wRollback->resolve();
        return $this->wRollback;
    }
}