Carno\Consul\Chips\WRouter::routing()

Complexity

Conditions	5
Paths	6

Size

Total Lines	31
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function routing(Service $service) : array
    {
        $commands = [];

        $newEndpoints = [];

        foreach ($service->getEndpoints() as $endpoint) {
            $epn = $endpoint->id();

            $newEndpoints[$epn] = $endpoint;

            if (isset($this->prevEndpoints[$epn])) {
                // exists
                unset($this->prevEndpoints[$epn]);
                continue;
            } else {
                // join
                $commands[] = new Router(Router::JOIN, $endpoint);
            }
        }

        if ($this->prevEndpoints) {

The expression $this->prevEndpoints of type Carno\Net\Endpoint[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->prevEndpoints as $endpoint) {
                // leave
                $commands[] = new Router(Router::LEAVE, $endpoint);
            }
        }

        $this->prevEndpoints = $newEndpoints;

        return $commands;
    }