carno-php / cluster

src/Resources.php

<?php
/**
 * Cluster resources manager
 * User: moyo
 * Date: 27/10/2017
 * Time: 2:48 PM
 */

namespace Carno\Cluster;

use Carno\Cluster\Chips\InitializeTips;
use Carno\Cluster\Classify\Classified;
use function Carno\Coroutine\all;
use Carno\Promise\Promise;
use Carno\Promise\Promised;

class Resources
{
    use InitializeTips;

    /**
     * @var Classified
     */
    private $classify = null;

    /**
     * @var bool
     */
    private $started = false;

    /**
     * @var array
     */
    private $paused = [];

    /**
     * @var array
     */
    private $loaded = [];

    /**
     * @var Promised[]
     */
    private $waits = [];

    /**
     * Resources constructor.
     * @param Classified $classify
     */
    public function __construct(Classified $classify)
    {
        $this->classify = $classify;
    }

    /**
     * @return static
     */
    public function startup() : self
    {
        $this->started = true;
        while ($this->paused) {

The expression $this->paused of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->initialize(...array_shift($this->paused));
        }
        return $this;
    }

    /**
     * @param string $scene
     * @param string $group
     * @param string $server
     * @param Managed $managed
     */
    public function initialize(string $scene, string $group, string $server, Managed $managed) : void
    {
        if (!$this->started) {
            $this->paused[] = func_get_args();
            return;
        }

        if (isset($this->loaded[$sk = $this->sk($group, $server)])) {
            return;
        }

        $this->waits[$sk] = $wait = $this->classify->discovery($scene)->attach($group, $server, $managed);

        $wait->then(function () use ($sk) {
            unset($this->waits[$sk]);
        });

        $this->loaded[$sk] = [$scene, $group, $server];

        $this->waiting($sk, $managed);
    }

    /**
     * @return Promised
     */
    public function ready() : Promised
    {
        return all(...array_values($this->waits));
    }

    /**
     * @param string $group
     * @param string $server
     * @return Promised
     */
    public function forget(string $group, string $server) : Promised
    {
        if (is_null($gss = $this->loaded[$sk = $this->sk($group, $server)] ?? null)) {
            return Promise::rejected();
        }

        unset($this->loaded[$sk]);

        return $this->classify->discovery(array_shift($gss))->detach(...$gss);

The call to Carno\Cluster\Discovery\Discovered::detach() has too few arguments starting with server.

    }

    /**
     * @return Promised
     */
    public function release() : Promised
    {
        $pending = [];

        foreach ($this->loaded as $sk => $gss) {
            unset($this->loaded[$sk]);
            $pending[] = $this->classify->discovery(array_shift($gss))->detach(...$gss);

The call to Carno\Cluster\Discovery\Discovered::detach() has too few arguments starting with server.

        }

        return all(...$pending);
    }

    /**
     * @param string $group
     * @param string $server
     * @return string
     */
    private function sk(string $group, string $server) : string
    {
        return sprintf('%s:%s', $group ?: 'service', $server);
    }
}