Issues in Setup.php (master) - Issues in master - carnage/doctrine-encrypted-column - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Setup.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Carnage\EncryptedColumn;

use Carnage\EncryptedColumn\Container\KeyContainer;
use Carnage\EncryptedColumn\Container\VersionedContainer;
use Carnage\EncryptedColumn\Dbal\EncryptedColumn;
use Carnage\EncryptedColumn\Dbal\EncryptedColumnLegacySupport;
use Carnage\EncryptedColumn\Encryptor\HaliteEncryptor;
use Carnage\EncryptedColumn\Encryptor\LegacyEncryptor;
use Carnage\EncryptedColumn\Serializer\LegacySerializer;
use Carnage\EncryptedColumn\Serializer\PhpSerializer;
use Carnage\EncryptedColumn\Service\EncryptionService;
use Carnage\EncryptedColumn\ValueObject\Key;
use Carnage\EncryptedColumn\ValueObject\KeyIdentity;
use Doctrine\ORM\EntityManagerInterface;

final class Setup
{
    private $keyPath;
    private $enableLegacy = false;
    private $legacyKey;
    private $keyContainer;

    public function __construct()
    {
        $this->keyContainer = new KeyContainer();
    }

    public function register(EntityManagerInterface $em)
    {
        if ($this->enableLegacy) {
            $this->doRegisterLegacy($em);
        } else {
            $this->doRegister($em);
        }
    }

    public function enableLegacy(string $legacyKey)
    {
        $this->enableLegacy = true;
        $this->legacyKey = $legacyKey;

        $key = new Key($legacyKey);
        $this->keyContainer->addKey($key);
        $this->keyContainer->tagKey('legacy', $key->getIdentifier()->toString());

        return $this;
    }

    public function withKeyPath(string $keypath)
    {
        $this->keyPath = $keypath;

        $key = new Key($keypath);
        $this->keyContainer->addKey($key);
        $this->keyContainer->tagKey('default', $key->getIdentifier()->toString());

        return $this;
    }

    public function withKey(string $key, array $tags = [])
    {
        $key = new Key($key);
        $keyId = $key->getIdentifier()->toString();
        $this->keyContainer->addKey($key);

        foreach ($tags as $tag) {
            $this->keyContainer->tagKey($tag, $keyId);
        }

        return $this;
    }

    private function buildEncryptionService(): EncryptionService
    {
        $encryptors = self::buildEncryptorsContainer();
        $serializers = self::buildSerilaizerContainer();
        return new EncryptionService(
            $encryptors->get(HaliteEncryptor::IDENTITY),

            $serializers->get(PhpSerializer::IDENTITY),

            $encryptors,
            $serializers,
            $this->keyContainer
        );
    }

    private function buildEncryptorsContainer(): VersionedContainer
    {
        $services = [new HaliteEncryptor($this->keyPath)];
        if ($this->enableLegacy) {
            $services[] = new LegacyEncryptor($this->legacyKey);
        }
        //@TODO add legacy encryptor, throw exceptions if required keys aren't specified
        return new VersionedContainer(...$services);
    }

    private function buildSerilaizerContainer(): VersionedContainer
    {
        $services = [new PhpSerializer()];
        if ($this->enableLegacy) {
            $services[] = new LegacySerializer();
        }
        return new VersionedContainer(...$services);
    }

    /**
     * @param EntityManagerInterface $em
     */
    private function doRegister(EntityManagerInterface $em)
    {
        EncryptedColumn::create($this->buildEncryptionService());
        $conn = $em->getConnection();
        $conn->getDatabasePlatform()->registerDoctrineTypeMapping(
            EncryptedColumn::ENCRYPTED,
            EncryptedColumn::ENCRYPTED
        );
    }

    /**
     * @param EntityManagerInterface $em
     */
    private function doRegisterLegacy(EntityManagerInterface $em)
    {
        EncryptedColumnLegacySupport::create($this->buildEncryptionService());
        $conn = $em->getConnection();
        $conn->getDatabasePlatform()->registerDoctrineTypeMapping(
            EncryptedColumnLegacySupport::ENCRYPTED,
            EncryptedColumnLegacySupport::ENCRYPTED
        );
    }
}

1			<?php
2
3			namespace Carnage\EncryptedColumn;
4
5			use Carnage\EncryptedColumn\Container\KeyContainer;
6			use Carnage\EncryptedColumn\Container\VersionedContainer;
7			use Carnage\EncryptedColumn\Dbal\EncryptedColumn;
8			use Carnage\EncryptedColumn\Dbal\EncryptedColumnLegacySupport;
9			use Carnage\EncryptedColumn\Encryptor\HaliteEncryptor;
10			use Carnage\EncryptedColumn\Encryptor\LegacyEncryptor;
11			use Carnage\EncryptedColumn\Serializer\LegacySerializer;
12			use Carnage\EncryptedColumn\Serializer\PhpSerializer;
13			use Carnage\EncryptedColumn\Service\EncryptionService;
14			use Carnage\EncryptedColumn\ValueObject\Key;
15			use Carnage\EncryptedColumn\ValueObject\KeyIdentity;
16			use Doctrine\ORM\EntityManagerInterface;
17
18			final class Setup
19			{
20			private $keyPath;
21	1		private $enableLegacy = false;
22			private $legacyKey;
23	1		private $keyContainer;
24	1
25			public function __construct()
26			{
27			$this->keyContainer = new KeyContainer();
28	1		}
29
30	1		public function register(EntityManagerInterface $em)
31			{
32	1		if ($this->enableLegacy) {
33	1		$this->doRegisterLegacy($em);
34	1		} else {
35			$this->doRegister($em);
36			}
37	1		}
38
39	1	View Code Duplication	public function enableLegacy(string $legacyKey)
40	1		{
41			$this->enableLegacy = true;
42			$this->legacyKey = $legacyKey;
43	1
44			$key = new Key($legacyKey);
45	1		$this->keyContainer->addKey($key);
46	1		$this->keyContainer->tagKey('legacy', $key->getIdentifier()->toString());
47	1
48	1		return $this;
49	1		}
50
51		View Code Duplication	public function withKeyPath(string $keypath)
52			{
53			$this->keyPath = $keypath;
54
55	1		$key = new Key($keypath);
56			$this->keyContainer->addKey($key);
57	1		$this->keyContainer->tagKey('default', $key->getIdentifier()->toString());
58	1
59	1		return $this;
60			}
61
62	1		public function withKey(string $key, array $tags = [])
63			{
64			$key = new Key($key);
65	1		$keyId = $key->getIdentifier()->toString();
66			$this->keyContainer->addKey($key);
67	1
68	1		foreach ($tags as $tag) {
69	1		$this->keyContainer->tagKey($tag, $keyId);
70			}
71	1
72			return $this;
73			}
74
75			private function buildEncryptionService(): EncryptionService
76			{
77			$encryptors = self::buildEncryptorsContainer();
78			$serializers = self::buildSerilaizerContainer();
79			return new EncryptionService(
80			$encryptors->get(HaliteEncryptor::IDENTITY),
			0 ignored issues – show Compatibility introduced 2017-04-15 17:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$encryptors->get(\Carnag...iteEncryptor::IDENTITY)` of type `object<Carnage\Encrypted...ner\VersionedInterface>` is not a sub-type of `object<Carnage\Encrypted...tor\EncryptorInterface>`. It seems like you assume a child interface of the interface `Carnage\EncryptedColumn\...iner\VersionedInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
81			$serializers->get(PhpSerializer::IDENTITY),
			0 ignored issues – show Compatibility introduced 2017-04-15 17:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$serializers->get(\Carna...hpSerializer::IDENTITY)` of type `object<Carnage\Encrypted...ner\VersionedInterface>` is not a sub-type of `object<Carnage\Encrypted...er\SerializerInterface>`. It seems like you assume a child interface of the interface `Carnage\EncryptedColumn\...iner\VersionedInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
82			$encryptors,
83			$serializers,
84			$this->keyContainer
85			);
86			}
87
88			private function buildEncryptorsContainer(): VersionedContainer
89			{
90	1		$services = [new HaliteEncryptor($this->keyPath)];
91			if ($this->enableLegacy) {
92	1		$services[] = new LegacyEncryptor($this->legacyKey);
93	1		}
94	1		//@TODO add legacy encryptor, throw exceptions if required keys aren't specified
95	1		return new VersionedContainer(...$services);
96	1		}
97
98	1		private function buildSerilaizerContainer(): VersionedContainer
99			{
100			$services = [new PhpSerializer()];
101			if ($this->enableLegacy) {
102			$services[] = new LegacySerializer();
103			}
104			return new VersionedContainer(...$services);
105			}
106
107			/**
108			* @param EntityManagerInterface $em
109			*/
110		View Code Duplication	private function doRegister(EntityManagerInterface $em)
111			{
112			EncryptedColumn::create($this->buildEncryptionService());
113			$conn = $em->getConnection();
114			$conn->getDatabasePlatform()->registerDoctrineTypeMapping(
115			EncryptedColumn::ENCRYPTED,
116			EncryptedColumn::ENCRYPTED
117			);
118			}
119
120			/**
121			* @param EntityManagerInterface $em
122			*/
123		View Code Duplication	private function doRegisterLegacy(EntityManagerInterface $em)
124			{
125			EncryptedColumnLegacySupport::create($this->buildEncryptionService());
126			$conn = $em->getConnection();
127			$conn->getDatabasePlatform()->registerDoctrineTypeMapping(
128			EncryptedColumnLegacySupport::ENCRYPTED,
129			EncryptedColumnLegacySupport::ENCRYPTED
130			);
131			}
132			}

carnage / doctrine-encrypted-column

Issues (18)

Security Analysis no request data

src/Setup.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like