Issues in Client.php (master) - Issues in master - carlosbuenosvinos/php-geckoboard-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/CarlosIO/Geckoboard/Client.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace CarlosIO\Geckoboard;

use Guzzle\Http\Client as Guzzle;
use CarlosIO\Geckoboard\Widgets\Widget;

/**
 * Class Client.
 */
class Client
{
    const URI = 'https://push.geckoboard.com';

    /**
     * @var \Guzzle\Http\Client
     */
    protected $client;

    /**
     * @var string
     */
    protected $api;

    /**
     * Construct a new Geckoboard Client.
     */
    public function __construct()
    {
        $this->api = '';
        $this->client = new Guzzle(self::URI);
    }

    /**
     * @param array|\Guzzle\Common\Collection $config
     *
     * @return Client $this
     */
    public function setGuzzleConfig($config)
    {
        $this->client->setConfig($config);

        return $this;
    }

    /**
     * @param string|bool $key
     *
     * @return \Guzzle\Common\Collection|mixed
     */
    public function getGuzzleConfig($key = false)
    {
        return $this->client->getConfig($key);

    }

    /**
     * Set Geckoboard API key.
     *
     * @param $apiKey
     *
     * @return $this
     */
    public function setApiKey($apiKey)
    {
        $this->api = $apiKey;

        return $this;
    }

    /**
     * Get Geckoboard API key.
     *
     * @return string
     */
    public function getApiKey()
    {
        return $this->api;
    }

    /**
     * Send the widget info to Geckboard.
     *
     * @param $widget
     *
     * @return $this
     */
    public function push($widget)
    {
        $this->pushWidgets(
            $this->getWidgetsArray($widget)
        );

        return $this;
    }

    /**
     * @param $widget
     *
     * @return array
     */
    private function getWidgetsArray($widget)
    {
        $widgets = $widget;
        if (!is_array($widget)) {
            $widgets = array($widget);
        }

        return $widgets;
    }

    /**
     * @param $widgets
     */
    private function pushWidgets($widgets)
    {
        foreach ($widgets as $widget) {
            $this->pushWidget($widget);
        }
    }

    /**
     * @param $widget
     */
    private function pushWidget(Widget $widget)
    {
        $this->client->post(
            '/v1/send/'.$widget->getId(),
            null,
            json_encode(
                array(
                    'api_key' => $this->getApiKey(),
                    'data' => $widget->getData(),
                )
            ))->send();
    }
}


1		<?php
2
3		namespace CarlosIO\Geckoboard;
4
5		use Guzzle\Http\Client as Guzzle;
6		use CarlosIO\Geckoboard\Widgets\Widget;
7
8		/**
9		* Class Client.
10		*/
11		class Client
12		{
13		const URI = 'https://push.geckoboard.com';
14
15		/**
16		* @var \Guzzle\Http\Client
17		*/
18		protected $client;
19
20		/**
21		* @var string
22		*/
23		protected $api;
24
25		/**
26		* Construct a new Geckoboard Client.
27		*/
28	2	public function __construct()
29		{
30	2	$this->api = '';
31	2	$this->client = new Guzzle(self::URI);
32	2	}
33
34		/**
35		* @param array\|\Guzzle\Common\Collection $config
36		*
37		* @return Client $this
38		*/
39	1	public function setGuzzleConfig($config)
40		{
41	1	$this->client->setConfig($config);
42
43	1	return $this;
44		}
45
46		/**
47		* @param string\|bool $key
48		*
49		* @return \Guzzle\Common\Collection\|mixed
50		*/
51	1	public function getGuzzleConfig($key = false)
52		{
53	1	return $this->client->getConfig($key);
		0 ignored issues – show Bug introduced 2016-05-09 13:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$key` defined by parameter `$key` on line 51 can also be of type `string`; however, `Guzzle\Http\Client::getConfig()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
54		}
55
56		/**
57		* Set Geckoboard API key.
58		*
59		* @param $apiKey
60		*
61		* @return $this
62		*/
63	1	public function setApiKey($apiKey)
64		{
65	1	$this->api = $apiKey;
66
67	1	return $this;
68		}
69
70		/**
71		* Get Geckoboard API key.
72		*
73		* @return string
74		*/
75	2	public function getApiKey()
76		{
77	2	return $this->api;
78		}
79
80		/**
81		* Send the widget info to Geckboard.
82		*
83		* @param $widget
84		*
85		* @return $this
86		*/
87	1	public function push($widget)
88		{
89	1	$this->pushWidgets(
90	1	$this->getWidgetsArray($widget)
91	1	);
92
93	1	return $this;
94		}
95
96		/**
97		* @param $widget
98		*
99		* @return array
100		*/
101	1	private function getWidgetsArray($widget)
102		{
103	1	$widgets = $widget;
104	1	if (!is_array($widget)) {
105	1	$widgets = array($widget);
106	1	}
107
108	1	return $widgets;
109		}
110
111		/**
112		* @param $widgets
113		*/
114	1	private function pushWidgets($widgets)
115		{
116	1	foreach ($widgets as $widget) {
117	1	$this->pushWidget($widget);
118	1	}
119	1	}
120
121		/**
122		* @param $widget
123		*/
124	1	private function pushWidget(Widget $widget)
125		{
126	1	$this->client->post(
127	1	'/v1/send/'.$widget->getId(),
128	1	null,
129	1	json_encode(
130		array(
131	1	'api_key' => $this->getApiKey(),
132	1	'data' => $widget->getData(),
133		)
134	1	))->send();
135	1	}
136		}
137

carlosbuenosvinos / php-geckoboard-api

Issues (18)

Security Analysis no request data

src/CarlosIO/Geckoboard/Client.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like