SrvResourceRecord::__construct() - Code Metrics - Inspection of "Refactor code to model each resource record type a..." - carlosafonso/php-dns-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a21f6f...b758b2 )

by Carlos

created 2020-04-19 19:27 UTC

SrvResourceRecord::__construct() A

↳ Parent: SrvResourceRecord

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
c	1
b	0
f	0
nc	1
nop	6
dl	0
loc	13
ccs	6
cts	6
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

namespace Afonso\Dns;

/**
 * This class represents a DNS Resource Record of type SRV.
 */
class SrvResourceRecord extends ResourceRecord
{
    /**
     * @var int
     */
    protected $priority;

    /**
     * @var int
     */
    protected $weight;

    /**
     * @var int
     */
    protected $port;

    /**
     * @var string
     */
    protected $target;

    public function __construct(
        string $name,
        int $ttl,
        int $priority,
        int $weight,
        int $port,
        string $target
    ) {
        parent::__construct($name, $ttl);
        $this->priority = $priority;
        $this->weight = $weight;
        $this->port = $port;
        $this->target = $target;
    }

    public function getType(): int
    {
        return ResourceRecord::TYPE_SRV;
    }

    public function __toString(): string
    {
        return "{$this->priority}"
            . " {$this->weight}"
            . " {$this->port}"
            . " {$this->target}";
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Afonso\Dns;
6
7		/**
8		* This class represents a DNS Resource Record of type SRV.
9		*/
10		class SrvResourceRecord extends ResourceRecord
11		{
12		/**
13		* @var int
14		*/
15		protected $priority;
16
17		/**
18		* @var int
19		*/
20		protected $weight;
21
22		/**
23		* @var int
24		*/
25		protected $port;
26
27		/**
28		* @var string
29		*/
30		protected $target;
31
32	9	public function __construct(
33		string $name,
34		int $ttl,
35		int $priority,
36		int $weight,
37		int $port,
38		string $target
39		) {
40	9	parent::__construct($name, $ttl);
41	9	$this->priority = $priority;
42	9	$this->weight = $weight;
43	9	$this->port = $port;
44	9	$this->target = $target;
45	9	}
46
47	3	public function getType(): int
48		{
49	3	return ResourceRecord::TYPE_SRV;
50		}
51
52	6	public function __toString(): string
53		{
54	6	return "{$this->priority}"
55	6	. " {$this->weight}"
56	6	. " {$this->port}"
57	6	. " {$this->target}";
58		}
59		}
60

carlosafonso / php-dns-client

Push — master ( a21f6f...b758b2 )

SrvResourceRecord::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like