Afonso\Dns\Client

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	query()	0	11	1
A	__construct()	0	6	2

<?php

declare(strict_types=1);

namespace Afonso\Dns;

class Client
{
    /**
     * @var \Afonso\Dns\SerializerInterface
     */
    protected $serializer;

    public function __construct(SerializerInterface $serializer = null)
    {
        if ($serializer === null) {
            $serializer = new Serializer();
        }
        $this->serializer = $serializer;

It seems like $serializer can also be of type Afonso\Dns\Serializer. However, the property $serializer is declared as type Afonso\Dns\SerializerInterface. Maybe add an additional type check?

    }

    /**
     * Queries the specified name server with data from the given request.
     *
     * @param \Afonso\Dns\Request $request
     * @param string $nameserver The IP address of the resolver
     * @return \Afonso\Dns\Response
     */
    public function query(Request $request, string $nameserver): Response
    {
        $serialized = $this->serializer->serializeRequest($request);

        $socket = socket_create(AF_INET, SOCK_DGRAM, SOL_UDP);
        socket_sendto($socket, $serialized, strlen($serialized), 0, $nameserver, 53);
        $assembled = '';
        $received = socket_recv($socket, $assembled, 2048, MSG_WAITALL);

The assignment to $received is dead and can be removed.

        socket_close($socket);

        return $this->serializer->deserializeResponse($assembled);
    }
}