Cardinity\Method\ResultObjectMapper

Complexity

Total Complexity

14

Size/Duplication

Total Lines	112
Duplicated Lines	7.14 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	mapCollection()	0	10	2
B	map()	0	23	6
A	getSetterName()	8	8	1
A	transformPaymentInstrumentValue()	0	14	3
A	transformAuthorizationInformationValue()	0	7	1
A	transformThreeDS2DataValue()	0	6	1

<?php

namespace Cardinity\Method;

use Cardinity\Exception;
use Cardinity\Method\Payment\AuthorizationInformation;
use Cardinity\Method\Payment\PaymentInstrumentCard;
use Cardinity\Method\Payment\PaymentInstrumentRecurring;
use Cardinity\Method\Payment\ThreeDS2AuthorizationInformation;

class ResultObjectMapper implements ResultObjectMapperInterface
{
    /**
     * Map each item in response data to instance of ResultObjectInterface
     * @param array $response
     * @param MethodResultCollectionInterface $method
     *
     * @return array
     */
    public function mapCollection(array $response, MethodResultCollectionInterface $method)
    {
        $return = [];

        foreach ($response as $item) {
            $return[] = $this->map($item, $method->createResultObject());
        }

        return $return;
    }

    /**
     * Map response data to instance of ResultObjectInterface
     * @param array $response
     * @param ResultObjectInterface $result
     *
     * @return ResultObjectInterface
     */
    public function map(array $response, ResultObjectInterface $result)
    {
        foreach ($response as $field => $value) {
            $method = $this->getSetterName($field);

            if (!method_exists($result, $method)) {
                continue;
            }

            if ($field == 'payment_instrument') {
                $value = $this->transformPaymentInstrumentValue($value, $response['payment_method']);
            } elseif ($field == 'authorization_information') {
                $value = $this->transformAuthorizationInformationValue($value);
            } elseif ($field == 'threeds2_data') {
                $result->setThreeDS2AuthorizationInformation($this->transformThreeDS2DataValue($value));

It seems like you code against a concrete implementation and not the interface Cardinity\Method\ResultObjectInterface as the method setThreeDS2AuthorizationInformation() does only exist in the following implementations of said interface: Cardinity\Method\Payment\Payment.

                continue;
            }

            $result->$method($value);
        }

        return $result;
    }

    /**
     * Extracts camelCased setter name from underscore notation.
     * Eg. my_field_name => myFieldName
     * @param string $field
     * @return string
     */
    private function getSetterName($field)

This method seems to be duplicated in your project.

    {
        $parts = explode('_', $field);
        array_map('ucfirst', $parts);
        $name = 'set' . implode('', $parts);

        return $name;
    }

    /**
     * Transform PaymentInstrument result array to object
     * @param array $data
     * @param string $method
     * @return PaymentInstrumentCard|PaymentInstrumentRecurring
     * @throws Exception\Runtime for unsupported methods
     */
    private function transformPaymentInstrumentValue(array $data, $method)
    {
        if ($method == 'card') {
            $instrument = new PaymentInstrumentCard();
        } elseif ($method == 'recurring') {
            $instrument = new PaymentInstrumentRecurring();
        } else {
            throw new Exception\Runtime(sprintf('Method "%s" is not supported', $method));
        }

        $this->map($data, $instrument);

        return $instrument;
    }

    /**
     * Transform AuthorizationInformation result array to object
     * @param array $data
     * @return AuthorizationInformation
     */
    private function transformAuthorizationInformationValue($data)
    {
        $info = new AuthorizationInformation();
        $this->map($data, $info);

        return $info;
    }

    /**
     * @param ARRAY $data
     * @return ThreeDS2AuthorizationInformation
     */
    private function transformThreeDS2DataValue($data)
    {
        $threeds2 = new ThreeDS2AuthorizationInformation();
        $this->map($data, $threeds2);
        return $threeds2;
    }
}