Create::getAdressConstraints() - Code Metrics - Inspection of "Merge pull request #14 from cardinity/bugfix/creat..." - cardinity/cardinity-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( f122f8...33fb6e )

unknown

created 2020-11-16 13:53 UTC

Create::getAdressConstraints() A

↳ Parent: Create

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Cardinity\Method\Payment;

use Cardinity\Method\MethodInterface;
use Symfony\Component\Validator\Constraints as Assert;


class Create implements MethodInterface
{
    const CARD = 'card';
    const RECURRING = 'recurring';

    private $attributes;


    public function __construct(array $attributes)
    {
        $this->attributes = $attributes;
    }

    public function getAction()
    {
        return 'payments';
    }

    public function getMethod()
    {
        return MethodInterface::POST;
    }

    public function getAttributes()
    {
        return $this->attributes;
    }

    public function createResultObject()
    {
        return new Payment();
    }

    public function getValidationConstraints()
    {
        return new Assert\Collection([
            'amount' =>  $this->buildElement('float', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'currency' => $this->buildElement('string', 1, ['min' => 3,'max' => 3]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'settle' => $this->buildElement('bool'),
            'order_id' => $this->buildElement('string', 0, ['min' => 2,'max' => 50]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'description' => $this->buildElement('string', 0, ['max' => 255]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'country' => $this->buildElement('string', 1, ['min' => 2,'max' => 2]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'payment_method' => new Assert\Required([
                new Assert\Type([
                    'type' => 'string',
                    'message' => 'The value {{ value }} is not a valid {{ type }}.'
                ]),
                new Assert\Choice([
                    'choices' => [
                        self::CARD,
                        self::RECURRING
                    ]
                ])
            ]),
            'payment_instrument' => $this->getPaymentInstrumentConstraints(
                $this->getAttributes()['payment_method']
            ),
            'threeds2_data' => new Assert\Optional(
                $this->getThreeDS2DataConstraints()
            )
        ]);
    }

    private function getPaymentInstrumentConstraints($method)
    {
        switch ($method) {
            case self::CARD:
                return new Assert\Collection([
                    'pan' => new Assert\Required([
                        new Assert\NotBlank(),
                        new Assert\Luhn()
                    ]),
                    'exp_year' => $this->buildElement(
                        'integer', 1, 
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        ['min' => 4,'max' => 4],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        new Assert\Range(['min' => date('Y')])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    ),
                    'exp_month' => $this->buildElement('integer', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'cvc' => $this->buildElement('string', 1, ['min' => 3, 'max' => 4]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'holder' => $this->buildElement('string', 1, ['max' => 32]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ]);
            case self::RECURRING:
                return new Assert\Collection([
                    'payment_id' => $this->buildElement('string', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ]);
        }

        throw new \InvalidArgumentException(
            sprintf(
                'Payment instrument for payment method "%s" is not expected',
                $method
            )
        );
    }

    private function getThreeDS2DataConstraints()
    {
        return new Assert\Collection([
            'notification_url' => $this->buildElement('string', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'browser_info' => $this->getBrowserInfoConstraints(),
            'billing_address' => new Assert\Optional(
                $this->getAdressConstraints()
            ),
            'delivery_address' => new Assert\Optional(
                $this->getAdressConstraints()
            ),
            'cardholder_info' => new Assert\Optional(
                $this->getCardHolderInfoConstraints()
            ),
        ]);
    }

    private function getBrowserInfoConstraints()
    {
        return new Assert\Collection([
            'accept_header' => $this->buildElement('string', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'browser_language' => $this->buildElement('string', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'screen_width' => $this->buildElement('integer', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'screen_height' => $this->buildElement('integer', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'challenge_window_size' => $this->buildElement('string', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'user_agent' => $this->buildElement('string', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'color_depth' => $this->buildElement('integer', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'time_zone' => $this->buildElement('integer', 1),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'ip_address' => new Assert\Optional($this->buildElement('string')),
            'javascript_enabled' => new Assert\Optional($this->buildElement('bool')),
            'java_enabled' => new Assert\Optional($this->buildElement('bool')),
        ]);
    }

    private function getAdressConstraints()
    {
        return new Assert\Collection([
            'address_line1' => $this->buildElement('string', 1, ['max'=>50]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'address_line2' => new Assert\Optional(
                $this->buildElement('string', 1, ['max'=>50])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ),
            'address_line3' => new Assert\Optional(
                $this->buildElement('string', 0, ['max'=>50])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ),
            'city' => $this->buildElement('string', 1, ['max'=>50]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'country' => $this->buildElement('string', 1, ['max'=>10]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'postal_code' => $this->buildElement('string', 1, ['max'=>16]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'state' => new Assert\Optional(
                $this->buildElement('string', 0, ['max'=>14])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ),
        ]);
    }

    private function getCardHolderInfoConstraints()
    {
        return new Assert\Collection([
            'email_address' => new Assert\Optional(
                new Assert\Email(['mode'=>'loose'])
            ),
            'mobile_phone_number' => new Assert\Optional($this->buildElement('string')),
            'work_phone_number' => new Assert\Optional($this->buildElement('string')),
            'home_phone_number' => new Assert\Optional($this->buildElement('string')),
        ]); 
    }

    private function buildElement($typeValue, bool $isRequired=false, $length=0, $args=0)
    {
        $inside_array = [
            new Assert\Type([
                'type' => $typeValue,
                'message' => 'The value {{ value }} is not a valid {{ type }}.'
            ]),
        ];
        if ($isRequired) array_unshift($inside_array, new Assert\NotBlank());
        if ($length) array_push($inside_array, new Assert\Length($length));
        if ($args) array_push($inside_array, $args);
        
        return $isRequired 
            ? new Assert\Required($inside_array)
            : new Assert\Optional($inside_array)
        ;
    }
}


1			<?php
2
3			namespace Cardinity\Method\Payment;
4
5			use Cardinity\Method\MethodInterface;
6			use Symfony\Component\Validator\Constraints as Assert;
7
8
9			class Create implements MethodInterface
10			{
11			const CARD = 'card';
12			const RECURRING = 'recurring';
13
14			private $attributes;
15
16
17			public function __construct(array $attributes)
18			{
19			$this->attributes = $attributes;
20			}
21
22			public function getAction()
23			{
24			return 'payments';
25			}
26
27			public function getMethod()
28			{
29			return MethodInterface::POST;
30			}
31
32			public function getAttributes()
33			{
34			return $this->attributes;
35			}
36
37			public function createResultObject()
38			{
39			return new Payment();
40			}

cardinity / cardinity-sdk-php

Push — master ( f122f8...33fb6e )

Create::getAdressConstraints() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like