Create::getPaymentInstrumentConstraints() - Code Metrics - Inspection of "3Ds v2" - cardinity/cardinity-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#12)

unknown

created 2020-11-05 07:07 UTC

Create::getPaymentInstrumentConstraints() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	56
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	56
rs	9.7251
c	0
b	0
f	0
cc	3
eloc	38
nc	3
nop	1

How to fix Long Method

<?php

namespace Cardinity\Method\Payment;

use Cardinity\Method\MethodInterface;
use Symfony\Component\Validator\Constraints as Assert;


class Create implements MethodInterface
{
    const CARD = 'card';
    const RECURRING = 'recurring';

    private $attributes;


    public function __construct(array $attributes)
    {
        $this->attributes = $attributes;
    }

    public function getAction()
    {
        return 'payments';
    }

    public function getMethod()
    {
        return MethodInterface::POST;
    }

    public function getAttributes()
    {
        return $this->attributes;
    }

    public function createResultObject()
    {
        return new Payment();
    }

    public function getValidationConstraints()
    {
        return new Assert\Collection([
            'amount' =>  $this->buildElement('float', 1),
            'currency' => $this->buildElement('string', 1, ['min' => 3,'max' => 3]),
            'settle' => $this->buildElement('bool'),
            'order_id' => $this->buildElement('string', 0, ['min' => 2,'max' => 50]),
            'description' => $this->buildElement('string', 0, ['max' => 255]),
            'country' => $this->buildElement('string', 1, ['min' => 2,'max' => 2]),
            'payment_method' => new Assert\Required([
                new Assert\Type([
                    'type' => 'string',
                    'message' => 'The value {{ value }} is not a valid {{ type }}.'
                ]),
                new Assert\Choice([
                    'choices' => [
                        self::CARD,
                        self::RECURRING
                    ]
                ])
            ]),
            'payment_instrument' => $this->getPaymentInstrumentConstraints(
                $this->getAttributes()['payment_method']
            ),
            'threeds2_data' => new Assert\Optional(
                $this->getThreeDS2DataConstraints()
            )
        ]);
    }

    private function getPaymentInstrumentConstraints($method)
    {
        switch ($method) {
            case self::CARD:
                return new Assert\Collection([
                    'pan' => new Assert\Required([
                        new Assert\NotBlank(),
                        new Assert\Luhn()
                    ]),
                    'exp_year' => $this->buildElement(
                        'integer', 1, 
                        ['min' => 4,'max' => 4],
                        new Assert\Range(['min' => date('Y')]),
                    ),

                    'exp_month' => $this->buildElement('integer', 1),
                    'cvc' => $this->buildElement('string', 1, ['min' => 3, 'max' => 4]),
                    'holder' => $this->buildElement('string', 1, ['max' => 32]),
                ]);
            case self::RECURRING:
                return new Assert\Collection([
                    'payment_id' => $this->buildElement('string', 1),
                ]);
        }

        throw new \InvalidArgumentException(
            sprintf(
                'Payment instrument for payment method "%s" is not expected',
                $method
            )
        );
    }

    private function getThreeDS2DataConstraints()
    {
        return new Assert\Collection([
            'notification_url' => $this->buildElement('string', 1),
            'browser_info' => $this->getBrowserInfoConstraints(),
            'billing_address' => new Assert\Optional(
                $this->getAdressConstraints()
            ),
            'delivery_address' => new Assert\Optional(
                $this->getAdressConstraints()
            ),
            'cardholder_info' => new Assert\Optional(
                $this->getCardHolderInfoConstraints()
            ),
        ]);
    }

    private function getBrowserInfoConstraints()
    {
        return new Assert\Collection([
            'accept_header' => $this->buildElement('string', 1),
            'browser_language' => $this->buildElement('string', 1),
            'screen_width' => $this->buildElement('integer', 1),
            'screen_height' => $this->buildElement('integer', 1),
            'challenge_window_size' => $this->buildElement('string', 1),
            'user_agent' => $this->buildElement('string', 1),
            'color_depth' => $this->buildElement('integer', 1),
            'time_zone' => $this->buildElement('integer', 1),
            'ip_address' => new Assert\Optional($this->buildElement('string')),
            'javascript_enabled' => new Assert\Optional($this->buildElement('bool')),
            'java_enabled' => new Assert\Optional($this->buildElement('bool')),
        ]);
    }

    private function getAdressConstraints()
    {
        return new Assert\Collection([
            'address_line1' => $this->buildElement('string', 1, ['max'=>50]),
            'address_line2' => new Assert\Optional(
                $this->buildElement('string', 1, ['max'=>50])
            ),
            'address_line3' => new Assert\Optional(
                $this->buildElement('string', 0, ['max'=>50])
            ),
            'city' => $this->buildElement('string', 1, ['max'=>50]),
            'country' => $this->buildElement('string', 1, ['max'=>10]),
            'postal_code' => $this->buildElement('string', 1, ['max'=>16]),
            'state' => new Assert\Optional(
                $this->buildElement('string', 0, ['max'=>14])
            ),
        ]);
    }

    private function getCardHolderInfoConstraints()
    {
        return new Assert\Collection([
            'email_address' => new Assert\Optional(
                new Assert\Email(['mode'=>'loose'])
            ),
            'mobile_phone_number' => new Assert\Optional($this->buildElement('string')),
            'work_phone_number' => new Assert\Optional($this->buildElement('string')),
            'home_phone_number' => new Assert\Optional($this->buildElement('string')),
        ]); 
    }

    private function buildElement($typeValue, bool $isRequired=false, $length=0, $args=0)
    {
        $inside_array = [
            new Assert\Type([
                'type' => $typeValue,
                'message' => 'The value {{ value }} is not a valid {{ type }}.'
            ]),
        ];
        if ($isRequired) array_unshift($inside_array, new Assert\NotBlank());
        if ($length) array_push($inside_array, new Assert\Length($length));
        if ($args) array_push($inside_array, $args);
        
        return $isRequired 
            ? new Assert\Required($inside_array)
            : new Assert\Optional($inside_array)
        ;
    }
}


1			<?php
2
3			namespace Cardinity\Method\Payment;
4
5			use Cardinity\Method\MethodInterface;
6			use Symfony\Component\Validator\Constraints as Assert;
7
8
9			class Create implements MethodInterface
10			{
11			const CARD = 'card';
12			const RECURRING = 'recurring';
13
14			private $attributes;
15
16
17			public function __construct(array $attributes)
18			{
19			$this->attributes = $attributes;
20			}
21
22			public function getAction()
23			{
24			return 'payments';
25			}
26
27			public function getMethod()
28			{
29			return MethodInterface::POST;
30			}
31
32			public function getAttributes()
33			{
34			return $this->attributes;
35			}
36
37			public function createResultObject()
38			{
39			return new Payment();
40			}
41
42			public function getValidationConstraints()
43			{
44			return new Assert\Collection([
45			'amount' => $this->buildElement('float', 1),
46			'currency' => $this->buildElement('string', 1, ['min' => 3,'max' => 3]),
47			'settle' => $this->buildElement('bool'),
48			'order_id' => $this->buildElement('string', 0, ['min' => 2,'max' => 50]),
49			'description' => $this->buildElement('string', 0, ['max' => 255]),
50			'country' => $this->buildElement('string', 1, ['min' => 2,'max' => 2]),
51			'payment_method' => new Assert\Required([
52			new Assert\Type([
53			'type' => 'string',
54			'message' => 'The value {{ value }} is not a valid {{ type }}.'
55			]),
56			new Assert\Choice([
57			'choices' => [
58			self::CARD,
59			self::RECURRING
60			]
61			])
62			]),
63			'payment_instrument' => $this->getPaymentInstrumentConstraints(
64			$this->getAttributes()['payment_method']
65			),
66			'threeds2_data' => new Assert\Optional(
67			$this->getThreeDS2DataConstraints()
68			)
69			]);
70			}
71
72			private function getPaymentInstrumentConstraints($method)
73			{
74			switch ($method) {
75			case self::CARD:
76			return new Assert\Collection([
77			'pan' => new Assert\Required([
78			new Assert\NotBlank(),
79			new Assert\Luhn()
80			]),
81			'exp_year' => $this->buildElement(
82			'integer', 1,
83			['min' => 4,'max' => 4],
84			new Assert\Range(['min' => date('Y')]),
85			),
			0 ignored issues – show Bug introduced 2020-10-23 08:54 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ')' Loading history...
86			'exp_month' => $this->buildElement('integer', 1),
87			'cvc' => $this->buildElement('string', 1, ['min' => 3, 'max' => 4]),
88			'holder' => $this->buildElement('string', 1, ['max' => 32]),
89			]);
90			case self::RECURRING:
91			return new Assert\Collection([
92			'payment_id' => $this->buildElement('string', 1),
93			]);
94			}
95
96			throw new \InvalidArgumentException(
97			sprintf(
98			'Payment instrument for payment method "%s" is not expected',
99			$method
100			)
101			);
102			}
103
104			private function getThreeDS2DataConstraints()
105			{
106			return new Assert\Collection([
107			'notification_url' => $this->buildElement('string', 1),
108			'browser_info' => $this->getBrowserInfoConstraints(),
109			'billing_address' => new Assert\Optional(
110			$this->getAdressConstraints()
111			),
112			'delivery_address' => new Assert\Optional(
113			$this->getAdressConstraints()
114			),
115			'cardholder_info' => new Assert\Optional(
116			$this->getCardHolderInfoConstraints()
117			),
118			]);
119			}
120
121			private function getBrowserInfoConstraints()
122			{
123			return new Assert\Collection([
124			'accept_header' => $this->buildElement('string', 1),
125			'browser_language' => $this->buildElement('string', 1),
126			'screen_width' => $this->buildElement('integer', 1),
127			'screen_height' => $this->buildElement('integer', 1),
128			'challenge_window_size' => $this->buildElement('string', 1),
129			'user_agent' => $this->buildElement('string', 1),
130			'color_depth' => $this->buildElement('integer', 1),
131			'time_zone' => $this->buildElement('integer', 1),
132			'ip_address' => new Assert\Optional($this->buildElement('string')),
133			'javascript_enabled' => new Assert\Optional($this->buildElement('bool')),
134			'java_enabled' => new Assert\Optional($this->buildElement('bool')),
135			]);
136			}
137
138			private function getAdressConstraints()
139			{
140			return new Assert\Collection([
141			'address_line1' => $this->buildElement('string', 1, ['max'=>50]),
142			'address_line2' => new Assert\Optional(
143			$this->buildElement('string', 1, ['max'=>50])
144			),
145			'address_line3' => new Assert\Optional(
146			$this->buildElement('string', 0, ['max'=>50])
147			),
148			'city' => $this->buildElement('string', 1, ['max'=>50]),
149			'country' => $this->buildElement('string', 1, ['max'=>10]),
150			'postal_code' => $this->buildElement('string', 1, ['max'=>16]),
151			'state' => new Assert\Optional(
152			$this->buildElement('string', 0, ['max'=>14])
153			),
154			]);
155			}
156
157			private function getCardHolderInfoConstraints()
158			{
159			return new Assert\Collection([
160			'email_address' => new Assert\Optional(
161			new Assert\Email(['mode'=>'loose'])
162			),
163			'mobile_phone_number' => new Assert\Optional($this->buildElement('string')),
164			'work_phone_number' => new Assert\Optional($this->buildElement('string')),
165			'home_phone_number' => new Assert\Optional($this->buildElement('string')),
166			]);
167			}
168
169			private function buildElement($typeValue, bool $isRequired=false, $length=0, $args=0)
170			{
171			$inside_array = [
172			new Assert\Type([
173			'type' => $typeValue,
174			'message' => 'The value {{ value }} is not a valid {{ type }}.'
175			]),
176			];
177			if ($isRequired) array_unshift($inside_array, new Assert\NotBlank());
178			if ($length) array_push($inside_array, new Assert\Length($length));
179			if ($args) array_push($inside_array, $args);
180
181			return $isRequired
182			? new Assert\Required($inside_array)
183			: new Assert\Optional($inside_array)
184			;
185			}
186			}
187

cardinity / cardinity-sdk-php

Pull Request — master (#12)

Create::getPaymentInstrumentConstraints() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like