Create::getValidationConstraints() - Code Metrics - Inspection of "3Ds v2" - cardinity/cardinity-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#12)

unknown

created 2020-10-23 08:48 UTC

Create::getValidationConstraints() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
rs	9.4929
c	0
b	0
f	0
cc	1
eloc	35
nc	1
nop	0

How to fix Long Method

<?php

namespace Cardinity\Method\Payment;

use Cardinity\Method\MethodInterface;
use Symfony\Component\Validator\Constraints as Assert;

class Create implements MethodInterface
{
    const CARD = 'card';
    const RECURRING = 'recurring';

    private $attributes;

    public function __construct(array $attributes)
    {
        $this->attributes = $attributes;
    }

    public function getAction()
    {
        return 'payments';
    }

    public function getMethod()
    {
        return MethodInterface::POST;
    }

    public function getAttributes()
    {
        return $this->attributes;
    }

    public function createResultObject()
    {
        return new Payment();
    }

    public function getValidationConstraints()
    {
        return new Assert\Collection([
            'amount' =>  $this->buildElement('float', 1),
            'currency' => $this->buildElement('string', 1, ['min' => 3,'max' => 3]),
            'settle' => $this->buildElement('bool'),
            'order_id' => $this->buildElement('string', 0, ['min' => 2,'max' => 50]),
            'description' => $this->buildElement('string', 0, ['max' => 255]),
            'country' => $this->buildElement('string', 1, ['min' => 2,'max' => 2]),
            'payment_method' => new Assert\Required([
                new Assert\Type(['type' => 'string']),
                new Assert\Choice([
                    'choices' => [
                        self::CARD,
                        self::RECURRING
                    ]
                ])
            ]),
            'payment_instrument' => $this->getPaymentInstrumentConstraints(
                $this->getAttributes()['payment_method']
            ),
            'threeDS2Data' => new Assert\Optional([$this->getTrheeDS2DataConstraints()])
        ]);
    }

    private function getPaymentInstrumentConstraints($method)
    {
        switch ($method) {
            case self::CARD:
                return new Assert\Collection([
                    'pan' => new Assert\Required([
                        new Assert\NotBlank(),
                        new Assert\Luhn()
                    ]),
                    'exp_year' => $this->buildElement(
                        'integer', 1, 
                        ['min' => 4,'max' => 4],
                        new Assert\Range(['min' => date('Y')]),
                    ),

                    'exp_month' => $this->buildElement('integer', 1),
                    'cvc' => $this->buildElement('string', 1, ['min' => 3, 'max' => 4]),
                    'holder' => $this->buildElement('string', 1, ['max' => 32]),
                ]);
            case self::RECURRING:
                return new Assert\Collection([
                    'payment_id' => $this->buildElement('string', 1),
                ]);
        }

        throw new \InvalidArgumentException(
            sprintf(
                'Payment instrument for payment method "%s" is not expected',
                $method
            )
        );
    }

    private function getTrheeDS2DataConstraints()
    {
        return new Assert\Collection([
            'notificationUrl' => $this->buildElement('string', 1),
            'browserInfo' => $this->getBrowserInfoConstraints(),
            'billingAddress' => $this->getAdressConstraints('billingAddress'),
            'deliveryAddress' => $this->getAdressConstraints('deliveryAddress'),
            'cardHolderInfo' => $this->getCardHolderInfoConstraints(),
        ]);
    }

    private function getBrowserInfoConstraints()
    {
        return new Assert\Collection([
            'acceptHeader' => $this->buildElement('string', 1),
            'browserLanguage' => $this->buildElement('string', 1), // TODO should implement standard IETF BCP 47 (https://tools.ietf.org/html/bcp47)
            'screenWidth' => $this->buildElement('integer', 1),
            'screenHeight' => $this->buildElement('integer', 1),
            'challengeWindowSize' => $this->buildElement('string', 1),
            'userAgent' => $this->buildElement('string', 1),
            'colorDepth' => $this->buildElement('integer', 1),
            'timeZone' => $this->buildElement('integer', 1),
            'ipAddress' => $this->buildElement('string'),
            'javaEnabled' => $this->buildElement('bool'),
            'javascriptEnabled' => $this->buildElement('bool'),
        ]);
    }

    private function getAdressConstraints()
    {
        return new Assert\Collection([
            'address_line1' => $this->buildElement('string', 1, ['max'=>50]),
            'address_line2' => $this->buildElement('string', 1, ['max'=>50]),
            'address_line3' => $this->buildElement('string', 0, ['max'=>50]),
            'city' => $this->buildElement('string', 1, ['max'=>50]),
            'country' => $this->buildElement('string', 1, ['max'=>10]), // TODO ISO 3166-1 alpha-2 country code.
            'postal_code' => $this->buildElement('string', 1, ['max'=>16]),
            'state' => $this->buildElement('string', 0, ['max'=>14]), // TODO  country subdivision code defined in ISO 3166-2
        ]);
    }

    private function getCardHolderInfoConstraints()
    {
        return new Assert\Collection([
            'email_address' => new Assert\Optional([
                new Assert\Email(['mode'=>'loose'])
            ]),
            'mobile_phone_number' => $this->buildElement('string'),
            'work_phone_number' => $this->buildElement('string'),
            'home_phone_number' => $this->buildElement('string'),
        ]); 
    }

    private function buildElement($typeValue, $isRequired=0, $length=0, $args=0)
    {
        $inside_array = [
            new Assert\Type(['type', $typeValue]),
        ];
        if ($isRequired) array_unshift($inside_array, new Assert\NotBlank());
        if ($length) array_push($inside_array, new Assert\Length($length));
        if ($args) array_push($inside_array, $args);
        
        return $isRequired 
            ? new Assert\Required($inside_array)
            : new Assert\Optional($inside_array)
        ;
    }
}


1			<?php
2
3			namespace Cardinity\Method\Payment;
4
5			use Cardinity\Method\MethodInterface;
6			use Symfony\Component\Validator\Constraints as Assert;
7
8			class Create implements MethodInterface
9			{
10			const CARD = 'card';
11			const RECURRING = 'recurring';
12
13			private $attributes;
14
15			public function __construct(array $attributes)
16			{
17			$this->attributes = $attributes;
18			}
19
20			public function getAction()
21			{
22			return 'payments';
23			}
24
25			public function getMethod()
26			{
27			return MethodInterface::POST;
28			}
29
30			public function getAttributes()
31			{
32			return $this->attributes;
33			}
34
35			public function createResultObject()
36			{
37			return new Payment();
38			}
39
40			public function getValidationConstraints()
41			{
42			return new Assert\Collection([
43			'amount' => $this->buildElement('float', 1),
44			'currency' => $this->buildElement('string', 1, ['min' => 3,'max' => 3]),
45			'settle' => $this->buildElement('bool'),
46			'order_id' => $this->buildElement('string', 0, ['min' => 2,'max' => 50]),
47			'description' => $this->buildElement('string', 0, ['max' => 255]),
48			'country' => $this->buildElement('string', 1, ['min' => 2,'max' => 2]),
49			'payment_method' => new Assert\Required([
50			new Assert\Type(['type' => 'string']),
51			new Assert\Choice([
52			'choices' => [
53			self::CARD,
54			self::RECURRING
55			]
56			])
57			]),
58			'payment_instrument' => $this->getPaymentInstrumentConstraints(
59			$this->getAttributes()['payment_method']
60			),
61			'threeDS2Data' => new Assert\Optional([$this->getTrheeDS2DataConstraints()])
62			]);
63			}
64
65			private function getPaymentInstrumentConstraints($method)
66			{
67			switch ($method) {
68			case self::CARD:
69			return new Assert\Collection([
70			'pan' => new Assert\Required([
71			new Assert\NotBlank(),
72			new Assert\Luhn()
73			]),
74			'exp_year' => $this->buildElement(
75			'integer', 1,
76			['min' => 4,'max' => 4],
77			new Assert\Range(['min' => date('Y')]),
78			),
			0 ignored issues – show Bug introduced 2020-10-23 08:54 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ')' Loading history...
79			'exp_month' => $this->buildElement('integer', 1),
80			'cvc' => $this->buildElement('string', 1, ['min' => 3, 'max' => 4]),
81			'holder' => $this->buildElement('string', 1, ['max' => 32]),
82			]);
83			case self::RECURRING:
84			return new Assert\Collection([
85			'payment_id' => $this->buildElement('string', 1),
86			]);
87			}
88
89			throw new \InvalidArgumentException(
90			sprintf(
91			'Payment instrument for payment method "%s" is not expected',
92			$method
93			)
94			);
95			}
96
97			private function getTrheeDS2DataConstraints()
98			{
99			return new Assert\Collection([
100			'notificationUrl' => $this->buildElement('string', 1),
101			'browserInfo' => $this->getBrowserInfoConstraints(),
102			'billingAddress' => $this->getAdressConstraints('billingAddress'),
103			'deliveryAddress' => $this->getAdressConstraints('deliveryAddress'),
104			'cardHolderInfo' => $this->getCardHolderInfoConstraints(),
105			]);
106			}
107
108			private function getBrowserInfoConstraints()
109			{
110			return new Assert\Collection([
111			'acceptHeader' => $this->buildElement('string', 1),
112			'browserLanguage' => $this->buildElement('string', 1), // TODO should implement standard IETF BCP 47 (https://tools.ietf.org/html/bcp47)
113			'screenWidth' => $this->buildElement('integer', 1),
114			'screenHeight' => $this->buildElement('integer', 1),
115			'challengeWindowSize' => $this->buildElement('string', 1),
116			'userAgent' => $this->buildElement('string', 1),
117			'colorDepth' => $this->buildElement('integer', 1),
118			'timeZone' => $this->buildElement('integer', 1),
119			'ipAddress' => $this->buildElement('string'),
120			'javaEnabled' => $this->buildElement('bool'),
121			'javascriptEnabled' => $this->buildElement('bool'),
122			]);
123			}
124
125			private function getAdressConstraints()
126			{
127			return new Assert\Collection([
128			'address_line1' => $this->buildElement('string', 1, ['max'=>50]),
129			'address_line2' => $this->buildElement('string', 1, ['max'=>50]),
130			'address_line3' => $this->buildElement('string', 0, ['max'=>50]),
131			'city' => $this->buildElement('string', 1, ['max'=>50]),
132			'country' => $this->buildElement('string', 1, ['max'=>10]), // TODO ISO 3166-1 alpha-2 country code.
133			'postal_code' => $this->buildElement('string', 1, ['max'=>16]),
134			'state' => $this->buildElement('string', 0, ['max'=>14]), // TODO country subdivision code defined in ISO 3166-2
135			]);
136			}
137
138			private function getCardHolderInfoConstraints()
139			{
140			return new Assert\Collection([
141			'email_address' => new Assert\Optional([
142			new Assert\Email(['mode'=>'loose'])
143			]),
144			'mobile_phone_number' => $this->buildElement('string'),
145			'work_phone_number' => $this->buildElement('string'),
146			'home_phone_number' => $this->buildElement('string'),
147			]);
148			}
149
150			private function buildElement($typeValue, $isRequired=0, $length=0, $args=0)
151			{
152			$inside_array = [
153			new Assert\Type(['type', $typeValue]),
154			];
155			if ($isRequired) array_unshift($inside_array, new Assert\NotBlank());
156			if ($length) array_push($inside_array, new Assert\Length($length));
157			if ($args) array_push($inside_array, $args);
158
159			return $isRequired
160			? new Assert\Required($inside_array)
161			: new Assert\Optional($inside_array)
162			;
163			}
164			}
165

cardinity / cardinity-sdk-php

Pull Request — master (#12)

Create::getValidationConstraints() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like