Inspection of "Add action and condition shorthands to simplify th..." - captainhook-git/captainhook - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#277)

by Sebastian

created 2025-10-17 20:19 UTC

Status

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -29,11 +29,11 @@
 block discarded – undo
         $config       = $this->createConfigMock();
         $config->expects($this->exactly(2))->method('getHookConfig')->willReturn($this->createHookConfigMock());
         $io->expects($invokedCount)
-           ->method('ask')
-           ->willReturnCallback(function ($parameters) use ($invokedCount) {
-               $results = ['y', 'y', 'y', 'phpunit', 'y', 'phpcs'];
-               return $results[$invokedCount->numberOfInvocations() - 1] ?? '';
-           });
+            ->method('ask')
+            ->willReturnCallback(function ($parameters) use ($invokedCount) {
+                $results = ['y', 'y', 'y', 'phpunit', 'y', 'phpcs'];
+                return $results[$invokedCount->numberOfInvocations() - 1] ?? '';
+            });
 
         $setup  = new Express($io);
         $setup->configureHooks($config);

Please login to merge, or discard this patch.

tests/unit/Runner/Config/Setup/AdvancedTest.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -29,11 +29,11 @@  discard block
 block discarded – undo
         $config      = $this->createConfigMock();
         $config->expects($this->exactly(9))->method('getHookConfig')->willReturn($this->createHookConfigMock());
         $io->expects($invocations)
-           ->method('ask')
-           ->willReturnCallback(function ($parameters) use ($invocations) {
-               $results = ['y', 'y', 'echo \'foo\'', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
-               return $results[$invocations->numberOfInvocations() - 1] ?? '';
-           });
+            ->method('ask')
+            ->willReturnCallback(function ($parameters) use ($invocations) {
+                $results = ['y', 'y', 'echo \'foo\'', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
+                return $results[$invocations->numberOfInvocations() - 1] ?? '';
+            });
 
         $setup  = new Advanced($io);
         $setup->configureHooks($config);
@@ -46,11 +46,11 @@  discard block
 block discarded – undo
         $config      = $this->createConfigMock();
         $config->method('getHookConfig')->willReturn($this->createHookConfigMock());
         $io->expects($invocations)
-           ->method('ask')
-           ->willReturnCallback(function ($parameters) use ($invocations) {
-               $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
-               return $results[$invocations->numberOfInvocations() - 1] ?? '';
-           });
+            ->method('ask')
+            ->willReturnCallback(function ($parameters) use ($invocations) {
+                $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
+                return $results[$invocations->numberOfInvocations() - 1] ?? '';
+            });
 
         $io->expects($this->once())->method('askAndValidate')->willReturn('foo:bar');
 

Please login to merge, or discard this patch.

tests/unit/Runner/Config/CreatorTest.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -33,15 +33,15 @@  discard block
 block discarded – undo
         $config      = $this->createConfigMock(true);
         $io          = $this->createIOMock();
         $io->expects($invocations)
-           ->method('ask')
-           ->willReturnCallback(function ($parameters) use ($invocations) {
-               $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
-               return $results[$invocations->numberOfInvocations() - 1] ?? '';
-           });
+            ->method('ask')
+            ->willReturnCallback(function ($parameters) use ($invocations) {
+                $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
+                return $results[$invocations->numberOfInvocations() - 1] ?? '';
+            });
 
         $runner = new Creator($io, $config);
         $runner->advanced(true)
-               ->run();
+                ->run();
     }
 
     /**
@@ -61,17 +61,17 @@  discard block
 block discarded – undo
 
         $io = $this->createIOMock();
         $io->expects($invocations)
-           ->method('ask')
-           ->willReturnCallback(function ($parameters) use ($invocations) {
-               $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
-               return $results[$invocations->numberOfInvocations() - 1] ?? '';
-           });
+            ->method('ask')
+            ->willReturnCallback(function ($parameters) use ($invocations) {
+                $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
+                return $results[$invocations->numberOfInvocations() - 1] ?? '';
+            });
         $io->expects($this->once())->method('askAndValidate')->willReturn('foo:bar');
 
         $runner = new Creator($io, $config);
         $runner->extend(true)
-               ->advanced(true)
-               ->run();
+                ->advanced(true)
+                ->run();
 
         $configFileContentAfter = $configDir->getChild('captainhook.json')->getContent();
         $this->assertFileExists($configFile);

Please login to merge, or discard this patch.

tests/unit/Runner/InstallerTest.php 1 patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -131,9 +131,9 @@  discard block
 block discarded – undo
         $template = $this->createTemplateMock();
 
         $template->expects($this->once())
-                 ->method('getCode')
-                 ->with('pre-commit')
-                 ->willReturn('');
+                    ->method('getCode')
+                    ->with('pre-commit')
+                    ->willReturn('');
 
         $runner = new Installer($io, $config, $repo, $template);
         $runner->setHook('pre-commit');
@@ -168,8 +168,8 @@  discard block
 block discarded – undo
         $template = $this->createTemplateMock();
 
         $file = $this->getMockBuilder(File::class)
-                     ->disableOriginalConstructor()
-                     ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $runner = new FakeInstaller($io, $config, $repo, $template);
         $file->method('isLink')->willReturn(true);
@@ -189,8 +189,8 @@  discard block
 block discarded – undo
         $template = $this->createTemplateMock();
 
         $file = $this->getMockBuilder(File::class)
-                     ->disableOriginalConstructor()
-                     ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $runner = new FakeInstaller($io, $config, $repo, $template);
         $file->method('isLink')->willReturn(true);
@@ -260,14 +260,14 @@  discard block
 block discarded – undo
         $repo     = new Repository($fakeRepo->getRoot());
 
         $template->expects($this->once())
-                 ->method('getCode')
-                 ->with('pre-commit')
-                 ->willReturn('');
+                    ->method('getCode')
+                    ->with('pre-commit')
+                    ->willReturn('');
 
         $runner = new Installer($io, $config, $repo, $template);
         $runner->setHook('pre-commit')
-               ->setMoveExistingTo('foo/bar/')
-               ->run();
+                ->setMoveExistingTo('foo/bar/')
+                ->run();
 
         $this->assertFileExists($fakeRepo->getHookDir() . '/pre-commit');
         $this->assertFileExists($fakeRepo->getRoot() . '/foo/bar/pre-commit');
@@ -295,14 +295,14 @@  discard block
 block discarded – undo
         $repo     = new Repository($fakeRepo->getRoot());
 
         $template->expects($this->once())
-                 ->method('getCode')
-                 ->with('pre-commit')
-                 ->willReturn('');
+                    ->method('getCode')
+                    ->with('pre-commit')
+                    ->willReturn('');
 
         $runner = new Installer($io, $config, $repo, $template);
         $runner->setHook('pre-commit')
-               ->setMoveExistingTo('foo/bar/')
-               ->run();
+                ->setMoveExistingTo('foo/bar/')
+                ->run();
 
         $this->assertFileExists($fakeRepo->getHookDir() . '/pre-commit');
     }
@@ -333,8 +333,8 @@  discard block
 block discarded – undo
 
         $runner = new Installer($io, $config, $repo, $template);
         $runner->setHook('pre-commit')
-               ->setMoveExistingTo('foo')
-               ->run();
+                ->setMoveExistingTo('foo')
+                ->run();
     }
 
     public function testSkipExisting(): void

Please login to merge, or discard this patch.

		@@ -33,15 +33,15 @@ discard block
		block discarded – undo
33	33	$config = $this->createConfigMock(true);
34	34	$io = $this->createIOMock();
35	35	$io->expects($invocations)
36		- ->method('ask')
37		- ->willReturnCallback(function ($parameters) use ($invocations) {
38		- $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
39		- return $results[$invocations->numberOfInvocations() - 1] ?? '';
40		- });
	36	+ ->method('ask')
	37	+ ->willReturnCallback(function ($parameters) use ($invocations) {
	38	+ $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
	39	+ return $results[$invocations->numberOfInvocations() - 1] ?? '';
	40	+ });
41	41
42	42	$runner = new Creator($io, $config);
43	43	$runner->advanced(true)
44		- ->run();
	44	+ ->run();
45	45	}
46	46
47	47	/**
		@@ -61,17 +61,17 @@ discard block
		block discarded – undo
61	61
62	62	$io = $this->createIOMock();
63	63	$io->expects($invocations)
64		- ->method('ask')
65		- ->willReturnCallback(function ($parameters) use ($invocations) {
66		- $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
67		- return $results[$invocations->numberOfInvocations() - 1] ?? '';
68		- });
	64	+ ->method('ask')
	65	+ ->willReturnCallback(function ($parameters) use ($invocations) {
	66	+ $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
	67	+ return $results[$invocations->numberOfInvocations() - 1] ?? '';
	68	+ });
69	69	$io->expects($this->once())->method('askAndValidate')->willReturn('foo:bar');
70	70
71	71	$runner = new Creator($io, $config);
72	72	$runner->extend(true)
73		- ->advanced(true)
74		- ->run();
	73	+ ->advanced(true)
	74	+ ->run();
75	75
76	76	$configFileContentAfter = $configDir->getChild('captainhook.json')->getContent();
77	77	$this->assertFileExists($configFile);

		@@ -131,9 +131,9 @@ discard block
		block discarded – undo
131	131	$template = $this->createTemplateMock();
132	132
133	133	$template->expects($this->once())
134		- ->method('getCode')
135		- ->with('pre-commit')
136		- ->willReturn('');
	134	+ ->method('getCode')
	135	+ ->with('pre-commit')
	136	+ ->willReturn('');
137	137
138	138	$runner = new Installer($io, $config, $repo, $template);
139	139	$runner->setHook('pre-commit');
		@@ -168,8 +168,8 @@ discard block
		block discarded – undo
168	168	$template = $this->createTemplateMock();
169	169
170	170	$file = $this->getMockBuilder(File::class)
171		- ->disableOriginalConstructor()
172		- ->getMock();
	171	+ ->disableOriginalConstructor()
	172	+ ->getMock();
173	173
174	174	$runner = new FakeInstaller($io, $config, $repo, $template);
175	175	$file->method('isLink')->willReturn(true);
		@@ -189,8 +189,8 @@ discard block
		block discarded – undo
189	189	$template = $this->createTemplateMock();
190	190
191	191	$file = $this->getMockBuilder(File::class)
192		- ->disableOriginalConstructor()
193		- ->getMock();
	192	+ ->disableOriginalConstructor()
	193	+ ->getMock();
194	194
195	195	$runner = new FakeInstaller($io, $config, $repo, $template);
196	196	$file->method('isLink')->willReturn(true);
		@@ -260,14 +260,14 @@ discard block
		block discarded – undo
260	260	$repo = new Repository($fakeRepo->getRoot());
261	261
262	262	$template->expects($this->once())
263		- ->method('getCode')
264		- ->with('pre-commit')
265		- ->willReturn('');
	263	+ ->method('getCode')
	264	+ ->with('pre-commit')
	265	+ ->willReturn('');
266	266
267	267	$runner = new Installer($io, $config, $repo, $template);
268	268	$runner->setHook('pre-commit')
269		- ->setMoveExistingTo('foo/bar/')
270		- ->run();
	269	+ ->setMoveExistingTo('foo/bar/')
	270	+ ->run();
271	271
272	272	$this->assertFileExists($fakeRepo->getHookDir() . '/pre-commit');
273	273	$this->assertFileExists($fakeRepo->getRoot() . '/foo/bar/pre-commit');
		@@ -295,14 +295,14 @@ discard block
		block discarded – undo
295	295	$repo = new Repository($fakeRepo->getRoot());
296	296
297	297	$template->expects($this->once())
298		- ->method('getCode')
299		- ->with('pre-commit')
300		- ->willReturn('');
	298	+ ->method('getCode')
	299	+ ->with('pre-commit')
	300	+ ->willReturn('');
301	301
302	302	$runner = new Installer($io, $config, $repo, $template);
303	303	$runner->setHook('pre-commit')
304		- ->setMoveExistingTo('foo/bar/')
305		- ->run();
	304	+ ->setMoveExistingTo('foo/bar/')
	305	+ ->run();
306	306
307	307	$this->assertFileExists($fakeRepo->getHookDir() . '/pre-commit');
308	308	}
		@@ -333,8 +333,8 @@ discard block
		block discarded – undo
333	333
334	334	$runner = new Installer($io, $config, $repo, $template);
335	335	$runner->setHook('pre-commit')
336		- ->setMoveExistingTo('foo')
337		- ->run();
	336	+ ->setMoveExistingTo('foo')
	337	+ ->run();
338	338	}
339	339
340	340	public function testSkipExisting(): void

		@@ -29,11 +29,11 @@
		block discarded – undo
29	29	$config = $this->createConfigMock();
30	30	$config->expects($this->exactly(2))->method('getHookConfig')->willReturn($this->createHookConfigMock());
31	31	$io->expects($invokedCount)
32		- ->method('ask')
33		- ->willReturnCallback(function ($parameters) use ($invokedCount) {
34		- $results = ['y', 'y', 'y', 'phpunit', 'y', 'phpcs'];
35		- return $results[$invokedCount->numberOfInvocations() - 1] ?? '';
36		- });
	32	+ ->method('ask')
	33	+ ->willReturnCallback(function ($parameters) use ($invokedCount) {
	34	+ $results = ['y', 'y', 'y', 'phpunit', 'y', 'phpcs'];
	35	+ return $results[$invokedCount->numberOfInvocations() - 1] ?? '';
	36	+ });
37	37
38	38	$setup = new Express($io);
39	39	$setup->configureHooks($config);

		@@ -29,11 +29,11 @@ discard block
		block discarded – undo
29	29	$config = $this->createConfigMock();
30	30	$config->expects($this->exactly(9))->method('getHookConfig')->willReturn($this->createHookConfigMock());
31	31	$io->expects($invocations)
32		- ->method('ask')
33		- ->willReturnCallback(function ($parameters) use ($invocations) {
34		- $results = ['y', 'y', 'echo \'foo\'', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
35		- return $results[$invocations->numberOfInvocations() - 1] ?? '';
36		- });
	32	+ ->method('ask')
	33	+ ->willReturnCallback(function ($parameters) use ($invocations) {
	34	+ $results = ['y', 'y', 'echo \'foo\'', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
	35	+ return $results[$invocations->numberOfInvocations() - 1] ?? '';
	36	+ });
37	37
38	38	$setup = new Advanced($io);
39	39	$setup->configureHooks($config);
		@@ -46,11 +46,11 @@ discard block
		block discarded – undo
46	46	$config = $this->createConfigMock();
47	47	$config->method('getHookConfig')->willReturn($this->createHookConfigMock());
48	48	$io->expects($invocations)
49		- ->method('ask')
50		- ->willReturnCallback(function ($parameters) use ($invocations) {
51		- $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
52		- return $results[$invocations->numberOfInvocations() - 1] ?? '';
53		- });
	49	+ ->method('ask')
	50	+ ->willReturnCallback(function ($parameters) use ($invocations) {
	51	+ $results = ['y', 'y', '\\Foo\\Bar', 'y', 'foo:bar', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n', 'n'];
	52	+ return $results[$invocations->numberOfInvocations() - 1] ?? '';
	53	+ });
54	54
55	55	$io->expects($this->once())->method('askAndValidate')->willReturn('foo:bar');
56	56

captainhook-git / captainhook

Pull Request — main (#277)

Status

Category

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch