CaptainHook\App\Git\Diff\FilterUtil

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	filterFromConfigValue()	0	4	3
A	sanitize()	0	3	1

<?php

/**
 * This file is part of CaptainHook.
 *
 * (c) Sebastian Feldmann <sf@sebastian-feldmann.info>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace CaptainHook\App\Git\Diff;

abstract class FilterUtil
{
    /**
     * Converts a value into a valid diff filter array
     *
     * @param  mixed $value
     * @return array<int, string>
     */
    public static function filterFromConfigValue($value): array
    {
        return self::sanitize(
            is_array($value) ? $value : str_split((string) strtoupper($value === null ? '' : $value))

It seems like is_array($value) ? $value : str_split((string)strtoupper($value === null ? '' : $value)) can also be of type true; however, parameter $data of CaptainHook\App\Git\Diff\FilterUtil::sanitize() does only seem to accept array, maybe add an additional type check?

        );
    }

    /**
     * Remove all invalid filter options
     *
     * @param  array<int, string> $data
     * @return array<int, string>
     */
    public static function sanitize(array $data): array
    {
        return array_filter($data, fn($e) => in_array($e, ['A', 'C', 'D', 'M', 'R', 'T', 'U', 'X', 'B', '*']));
    }
}