Issues in ModelWithClass.php (master) - Issues in master - caoym/phpboot - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ORM/ModelWithClass.php (9 issues)

Labels

Severity

Minor 9

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PhpBoot\ORM;

use Doctrine\Common\Cache\Cache;
use PhpBoot\DB\DB;

class ModelWithClass
{
    /**
     * Model constructor.
     * @param DB $db
     * @param string $entityName
     * @param Cache $cache
     */
    public function __construct(DB $db, $entityName, Cache $cache)

    {
        $this->db = $db;
        $builder = $db->getApp()->get(ModelContainerBuilder::class);
        $this->entity = $builder->build($entityName);
    }

    /**
     * @param string $id
     * @return mixed|null
     */
    public function find($id)
    {
        $row = $this->db->select($this->getColumns())
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            ->from($this->entity->getTable())
            ->where("`{$this->entity->getPK()}` = ?", $id)
            ->getFirst();
        if($row){
            return $this->entity->make($row, false);
        }else{
            return null;
        }
    }

    /**
     * @return int rows deleted
     */
    public function delete($id)
    {
        return $this->db->deleteFrom($this->entity->getTable())
            ->where([$this->entity->getPK()=>$id])
            ->limit(1)
            ->exec()->rows;
    }

    /**
     * where 语法见 @see WhereRule
     * @param array|string $expr
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param mixed|null $_
     * @return \PhpBoot\DB\rules\basic\WhereRule
     */
    public function deleteWhere($conditions, $_=null)

    {
        $query = $this->db->deleteFrom($this->entity->getTable());
        return call_user_func_array([$query, 'where'], func_get_args());
    }

    /**
     * @return false|int
     */
    public function count()
    {
        return $this->db->select($this->getColumns())
            ->from($this->entity->getTable())
            ->count();
    }

    /**
     * where 语法见 @see WhereRule
     * @param array|string|callable|null $conditions
     * @param string $_
     * @return \PhpBoot\DB\rules\select\WhereRule
     */
    public function findWhere($conditions=null, $_=null)

    {
        $query =  $this->db->select($this->getColumns())
            ->from($this->entity->getTable());
        $query->context->resultHandler = function ($result){
            foreach ($result as &$i){
                $i = $this->entity->make($i, false);
            }
            return $result;
        };
        return call_user_func_array([$query, 'where'], func_get_args());
    }

    /**
     * @param int|string $id
     * @param array $values
     * @return int updated row count
     */
    public function update($id, $values)
    {
        return $this->db->update($this->entity->getTable())
            ->set($values)
            ->where([$this->entity->getPK()=>$id])
            ->exec();
    }

    /**
     * @param array $values
     * @param array|string|callable $conditions  where 语法见 @see WhereRule
     * @param string $_
     * @return \PhpBoot\DB\rules\basic\WhereRule
     */
    public function updateWhere($values, $conditions, $_=null)

    {
        $query =  $this->db->update($this->entity->getTable())->set($values);
        return call_user_func_array([$query, 'where'], array_slice(func_get_args(),1));
    }

    /**
     * set entity table name
     * @param string $tableName
     * @return $this
     */
    public function withTable($tableName)
    {
        $this->entity->setTable($tableName);
        return $this;
    }

    protected function getColumns()
    {
        $columns = [];
        foreach ($this->entity->getProperties() as $p){
            $columns[] = $p->name;
        }
        return $columns;
    }
    /**
     * @var ModelContainer
     */
    protected $entity;
    /**
     * @var DB
     */
    protected $db;
}

1		<?php
2		namespace PhpBoot\ORM;
3
4		use Doctrine\Common\Cache\Cache;
5		use PhpBoot\DB\DB;
6
7		class ModelWithClass
8		{
9		/**
10		* Model constructor.
11		* @param DB $db
12		* @param string $entityName
13		* @param Cache $cache
14		*/
15	7	public function __construct(DB $db, $entityName, Cache $cache)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$cache` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
16		{
17	7	$this->db = $db;
18	7	$builder = $db->getApp()->get(ModelContainerBuilder::class);
19	7	$this->entity = $builder->build($entityName);
20	7	}
21
22		/**
23		* @param string $id
24		* @return mixed\|null
25		*/
26	1	public function find($id)
27		{
28	1	$row = $this->db->select($this->getColumns())
		0 ignored issues – show Bug introduced 2017-08-04 16:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$row` is correct as `$this->db->select($this-... = ?", $id)->getFirst()` (which targets `PhpBoot\DB\rules\select\GetRule::getFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
29	1	->from($this->entity->getTable())
30	1	->where("`{$this->entity->getPK()}` = ?", $id)
31	1	->getFirst();
32	1	if($row){
33		return $this->entity->make($row, false);
34		}else{
35	1	return null;
36		}
37		}
38
39		/**
40		* @return int rows deleted
41		*/
42	1	public function delete($id)
43		{
44	1	return $this->db->deleteFrom($this->entity->getTable())
45	1	->where([$this->entity->getPK()=>$id])
46	1	->limit(1)
47	1	->exec()->rows;
48		}
49
50		/**
51		* where 语法见 @see WhereRule
52		* @param array\|string $expr
		0 ignored issues – show Bug introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$expr`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
53		* @param mixed\|null $_
54		* @return \PhpBoot\DB\rules\basic\WhereRule
55		*/
56	1	public function deleteWhere($conditions, $_=null)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$conditions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$_` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57		{
58	1	$query = $this->db->deleteFrom($this->entity->getTable());
59	1	return call_user_func_array([$query, 'where'], func_get_args());
60		}
61
62		/**
63		* @return false\|int
64		*/
65		public function count()
66		{
67		return $this->db->select($this->getColumns())
68		->from($this->entity->getTable())
69		->count();
70		}
71
72		/**
73		* where 语法见 @see WhereRule
74		* @param array\|string\|callable\|null $conditions
75		* @param string $_
76		* @return \PhpBoot\DB\rules\select\WhereRule
77		*/
78	2	public function findWhere($conditions=null, $_=null)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$conditions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-21 15:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$_` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
79		{
80	2	$query = $this->db->select($this->getColumns())
81	2	->from($this->entity->getTable());
82		$query->context->resultHandler = function ($result){
83		foreach ($result as &$i){
84		$i = $this->entity->make($i, false);
85		}
86		return $result;
87		};
88	2	return call_user_func_array([$query, 'where'], func_get_args());
89		}
90
91		/**
92		* @param int\|string $id
93		* @param array $values
94		* @return int updated row count
95		*/
96	1	public function update($id, $values)
97		{
98	1	return $this->db->update($this->entity->getTable())
99	1	->set($values)
100	1	->where([$this->entity->getPK()=>$id])
101	1	->exec();
102		}
103
104		/**
105		* @param array $values
106		* @param array\|string\|callable $conditions where 语法见 @see WhereRule
107		* @param string $_
108		* @return \PhpBoot\DB\rules\basic\WhereRule
109		*/
110	1	public function updateWhere($values, $conditions, $_=null)
		0 ignored issues – show Unused Code introduced 2017-08-10 10:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$conditions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-10 10:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$_` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
111		{
112	1	$query = $this->db->update($this->entity->getTable())->set($values);
113	1	return call_user_func_array([$query, 'where'], array_slice(func_get_args(),1));
114		}
115
116		/**
117		* set entity table name
118		* @param string $tableName
119		* @return $this
120		*/
121		public function withTable($tableName)
122		{
123		$this->entity->setTable($tableName);
124		return $this;
125		}
126
127	3	protected function getColumns()
128		{
129	3	$columns = [];
130	3	foreach ($this->entity->getProperties() as $p){
131	3	$columns[] = $p->name;
132	3	}
133	3	return $columns;
134		}
135		/**
136		* @var ModelContainer
137		*/
138		protected $entity;
139		/**
140		* @var DB
141		*/
142		protected $db;
143		}

GitHub Access Token became invalid

Issues (164)

Security Analysis not enabled

src/ORM/ModelWithClass.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

caoym / phpboot

GitHub Access Token became invalid

Issues (164)

Security Analysis not enabled

src/ORM/ModelWithClass.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like