PhpBoot\DB\impls\ValuesImpl

Complexity

Total Complexity

17

Size/Duplication

Total Lines	75
Duplicated Lines	22.67 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

98.15%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	values()	9	24	4
B	batchValues()	8	22	4
A	pick()	0	9	3
B	toSql()	0	16	6

<?php

namespace PhpBoot\DB\impls;
use PhpBoot\DB\DB;
use PhpBoot\DB\NestedStringCut;
use PhpBoot\DB\Raw;
use PhpBoot\DB\rules\basic\BasicRule;
use PhpBoot\DB\Context;

class ExecResult{
    public function __construct($success, $pdo, $st){
        $this->pdo = $pdo;
        $this->st = $st;
        $this->success = $success;
        $this->rows = $this->st->rowCount();
    }
    public function lastInsertId($name=null){
        return $this->pdo->lastInsertId($name);
    }
    /**
     * @var bool
     * true on success or false on failure.
     */
    public $success;
    /**
     * @var int
     * the number of rows.
     */
    public $rows;
    /**
     *
     * @var \PDO
     */
    public $pdo;

    /**
     * @var \PDOStatement
     */
    public $st;
}

class SelectImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static  public function select($context, $columns){

As per PSR2, the static declaration should come after the visibility declaration.

        $context->appendSql("SELECT $columns");
    }
}

class FromImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function from($context, $tables,$as=null){

As per PSR2, the static declaration should come after the visibility declaration.

        if($tables instanceof BasicRule){
            $context->appendSql("FROM (".$tables->context->sql.')');
            $context->params = array_merge($context->params,$tables->context->params);
        }else {
            $context->appendSql("FROM ".DB::wrap($tables));
        }
        if($as){
            $context->appendSql("AS ".DB::wrap($as));
        }
    }
}

class DeleteImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function deleteFrom($context, $from)

As per PSR2, the static declaration should come after the visibility declaration.

    {
        $context->appendSql("DELETE FROM ".DB::wrap($from));
    }
}

class JoinImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function join($context, $type, $table) {

As per PSR2, the static declaration should come after the visibility declaration.

        $table = DB::wrap($table);
        if($type){
            $context->appendSql("$type JOIN $table");
        }else{
            $context->appendSql("JOIN $table");
        }
    }
}

class JoinOnImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function on($context, $condition) {

As per PSR2, the static declaration should come after the visibility declaration.

        $context->appendSql("ON $condition");
    }
}

class ForUpdateImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function forUpdate($context){

As per PSR2, the static declaration should come after the visibility declaration.

        $context->appendSql("FOR UPDATE");
    }
}

class ForUpdateOfImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function of($context, $column){

As per PSR2, the static declaration should come after the visibility declaration.

        $column = DB::wrap($column);
        $context->appendSql("OF $column");
    }
}

class InsertImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function insertInto($context, $table) {

As per PSR2, the static declaration should come after the visibility declaration.

        $table = DB::wrap($table);
        $context->appendSql("INSERT INTO $table");
    }
}
class ReplaceImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function replaceInto($context, $table) {

As per PSR2, the static declaration should come after the visibility declaration.

        $table = DB::wrap($table);
        $context->appendSql("REPLACE INTO $table");
    }
}
class ValuesImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
     static public function values(Context $context, array $values){

As per PSR2, the static declaration should come after the visibility declaration.

        $params = [];
        $stubs = [];
        foreach ($values as $v){
            if(is_a($v, Raw::class)){//直接拼接sql，不需要转义
                $stubs[]=$v->get();
            }else{
                $stubs[]='?';
                $params[] = $v;
            }
        }
        $stubs = implode(',', $stubs);

        if(array_keys($values) === range(0, count($values) - 1)){

This code seems to be duplicated across your project.

            //VALUES(val0, val1, val2)

40% of this comment could be valid code. Did you maybe forget this after debugging?

            $context->appendSql("VALUES($stubs)");

        }else{
            //(col0, col1, col2) VALUES(val0, val1, val2)

40% of this comment could be valid code. Did you maybe forget this after debugging?

            $columns = implode(',', array_map(function($k){return DB::wrap($k);}, array_keys($values)));
            $context->appendSql("($columns) VALUES($stubs)",false);
        }
        $context->appendParams($params);
    }
    static public function batchValues(Context $context, array $values)

As per PSR2, the static declaration should come after the visibility declaration.

    {
        $count = count($values);
        if($count == 0){
            return;
        }
        $keys = array_keys($values[0]);
        $row = implode(',', self::toSql(array_values($values[0])));
        if($keys === range(0, count($keys) - 1)){

This code seems to be duplicated across your project.

            //VALUES(val0, val1, val2)

40% of this comment could be valid code. Did you maybe forget this after debugging?

            $context->appendSql("VALUES($row)");
        }else{
            //(col0, col1, col2) VALUES(val0, val1, val2)

40% of this comment could be valid code. Did you maybe forget this after debugging?

            $columns = implode(',', array_map(function($k){return DB::wrap($k);}, $keys));
            $context->appendSql("($columns) VALUES($row)",false);
        }
        for($i=1; $i<$count; $i++){
            $value = self::pick($keys, $values[$i]);
            $row = implode(',', self::toSql($value));
            $context->appendSql(", ($row)",false);
        }
    }

    static protected function pick(array $keys, array $values)

As per PSR2, the static declaration should come after the visibility declaration.

    {
        $res = [];
        foreach ($keys as $key){
            array_key_exists($key, $values) or \PhpBoot\abort("key $key not exist from the given array");

Using logical operators such as or instead of || is generally not recommended.

            $res[$key] = $values[$key];
        }
        return $res;
    }
    static protected function toSql(array $values)

As per PSR2, the static declaration should come after the visibility declaration.

    {
        foreach ($values as &$v){
            if($v instanceof Raw){
                $v = $v->get();
            }elseif(is_bool($v)){
                $v = $v?'true':'false';
            }elseif(!in_array(gettype($v), ['integer', 'boolean', 'double', 'float'])){
                $v = (string)$v;
                $v = str_replace("\\", "\\\\", $v);
                $v = str_replace("'", "\\'", $v);
                $v = "'$v'";
            }
        }
        return $values;
    }
}

class UpdateImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function update($context, $table){

As per PSR2, the static declaration should come after the visibility declaration.

        $table = DB::wrap($table);
        $context->appendSql("UPDATE $table");
    }
}

class UpdateSetImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function set(Context $context, $expr, $args){
        if(is_string($expr)){
            return $this->setExpr($context, $expr, $args);
        }else{
            return $this->setArgs($context, $expr);
        }
    }

    public function setExpr(Context $context, $expr, $args){
        if($this->first){
            $this->first = false;
            $prefix = 'SET ';
        }else{
            $prefix = ',';
        }

        $context->appendSql("$prefix$expr",$prefix == 'SET ');
        $context->appendParams($args);

    }
    public function setArgs(Context $context, $values){

This method seems to be duplicated in your project.

        $set = [];
        $params = [];
        foreach ($values as $k=>$v){
            $k = DB::wrap($k);
            if(is_a($v, Raw::class)){//直接拼接sql，不需要转义
                $set[]= "$k=".$v->get();
            }else{
                $set[]= "$k=?";
                $params[]=$v;
            }
        }
        if($this->first){
            $this->first = false;
            $context->appendSql('SET '.implode(',', $set));
            $context->appendParams($params);
        }else{
            $context->appendSql(','.implode(',', $set),false);
            $context->appendParams($params);
        }
    }
    private $first=true;
}
class OrderByImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function orderByArgs(Context $context, $orders){
        if(empty($orders)){
            return $this;
        }
        $params = array();
        foreach ($orders as $k=>$v){
            if(is_integer($k)){
                $params[] = DB::wrap($v);
            }else{
                $k = DB::wrap($k);

                $v = strtoupper($v);
                ($v =='DESC' || $v =='ASC') or \PhpBoot\abort( new \InvalidArgumentException("invalid params for orderBy(".json_encode($orders).")"));

Using logical operators such as or instead of || is generally not recommended.

                $params[] = "$k $v";
            }
        }
        if($this->first){
            $this->first = false;
            $context->appendSql('ORDER BY '.implode(',', $params));
        }else{
            $context->appendSql(','.implode(',', $params),false);
        }
        return $this;
    }
    public function orderBy(Context $context, $column, $order=null){
        if(is_string($column)){
            if($order === null){
                $column = [$column];
            }else{
                $column = [$column=>$order];
            }
        }
        return $this->orderByArgs($context, $column);


    }
    private $first=true;
}

class LimitImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    static public function limit(Context $context, $size){

As per PSR2, the static declaration should come after the visibility declaration.

        $intSize = intval($size);
        strval($intSize) == $size or \PhpBoot\abort(

Using logical operators such as or instead of || is generally not recommended.

            new \InvalidArgumentException("invalid params for limit($size)"));
        $context->appendSql("LIMIT $size");
    }
    static public function limitWithOffset(Context $context, $start, $size){

As per PSR2, the static declaration should come after the visibility declaration.

        $intStart = intval($start);
        $intSize = intval($size);
        strval($intStart) == $start && strval($intSize) == $size or \PhpBoot\abort(

Using logical operators such as or instead of || is generally not recommended.

            new \InvalidArgumentException("invalid params for limit($start, $size)"));
        $context->appendSql("LIMIT $start,$size");
    }
}

class WhereImpl{

PSR1 recommends that each class should be in its own file to aid autoloaders.

    static private function findQ($str,$offset = 0,$no=0){

As per PSR2, the static declaration should come after the visibility declaration.

        $found = strpos($str, '?', $offset);
        if($no == 0 || $found === false){
            return $found;
        }
        return self::findQ($str, $found+1, $no-1);
    }

    static public function where(Context $context, $prefix, $expr, $args){

As per PSR2, the static declaration should come after the visibility declaration.

        if(empty($expr)){
            return;
        }
        if(is_callable($expr)){
            self::conditionClosure($context,$prefix, $expr);
        }elseif (is_string($expr)){
            self::condition($context, $prefix, $expr, $args);
        }else{
            self::conditionArgs($context, $prefix, $expr);
        }

    }

    static public function conditionClosure(Context $context, $prefix, callable $callback){

As per PSR2, the static declaration should come after the visibility declaration.

        $context->appendSql($prefix.' (');
        $callback($context);
        $context->appendSql(')');
    }
    /**
     * find like Mongodb query glossary
     * whereArray(
     *      [
     *          'id'=>['>'=>1],
     *          'name'=>'cym',
     *      ]
     * )
     * 支持的操作符有
     * =    'id'=>['=' => 1]
     * >    'id'=>['>' => 1]
     * <    'id'=>['<' => 1]
     * <>   'id'=>['<>' => 1]
     * >=   'id'=>['>=' => 1]
     * <=   'id'=>['<=' => 1]
     * BETWEEN  'id'=>['BETWEEN' => [1 ,2]]
     * LIKE     'id'=>['LIKE' => '1%']
     * IN   'id'=>['IN' => [1,2,3]]
     * NOT IN   'id'=>['NOT IN' => [1,2,3]]
     * @return void
     */
    static public function conditionArgs(Context $context, $prefix, $args=[]){

As per PSR2, the static declaration should come after the visibility declaration.

        if($args ===null){
            return ;
        }
        $exprs = array();
        $params = array();
        foreach ($args as $k => $v){
            $k = DB::wrap($k);
            if(!is_array($v)){
                $v = ['='=>$v];
            }

            $ops = ['=', '>', '<', '<>', '>=', '<=', 'IN', 'NOT IN', 'BETWEEN', 'LIKE'];
            $op = array_keys($v)[0];
            $op = strtoupper($op);

            false !== array_search($op, $ops) or \PhpBoot\abort(

Using logical operators such as or instead of || is generally not recommended.

                new \InvalidArgumentException("invalid param $op for whereArgs"));

            $var = array_values($v)[0];
            if($op == 'IN' || $op == 'NOT IN'){
                $stubs = [];

                if($var instanceof BasicRule){
                    $stubs = "({$var->context->sql})";
                    $params = array_merge($params, $var->context->params);
                    $exprs[] = "$k $op $stubs";
                }else{
                    foreach ($var as $i){
                        if(is_a($i, Raw::class)){
                            $stubs[]=strval($i);
                        }elseif($i instanceof BasicRule){

This code seems to be duplicated across your project.

                            $stubs = "({$i->context->sql})";
                            $params = array_merge($params, $i->context->params);
                        }else{
                            $stubs[]='?';
                            $params[] = $i;
                        }
                    }
                    $stubs = implode(',', $stubs);
                    $exprs[] = "$k $op ($stubs)";
                }
            }else if($op == 'BETWEEN'){
                $cond = "$k BETWEEN";
                if(is_a($var[0], Raw::class)){

This code seems to be duplicated across your project.

                    $cond = "$cond ".strval($var[0]);
                }elseif($var[0] instanceof BasicRule){
                    $cond = "$cond ({$var[0]->context->sql})";
                    $params = array_merge($params, $var[0]->context->params);
                }else{
                    $cond = "$cond ?";
                    $params[] = $var[0];
                }
                if(is_a($var[1], Raw::class)){

This code seems to be duplicated across your project.

                    $cond = "$cond AND ".strval($var[1]);
                }elseif($var[1] instanceof BasicRule){
                    $cond = "$cond AND ({$var[1]->context->sql})";
                    $params = array_merge($params, $var[1]->context->params);
                }else{
                    $cond = "$cond AND ?";
                    $params[] = $var[1];
                }
                $exprs[] = $cond;
            }else{
                if(is_a($var, Raw::class)){
                    $exprs[] = "$k $op ".strval($var);
                }elseif($var instanceof BasicRule){
                    $exprs[] = "$k $op {$var->context->sql}";
                    $params = array_merge($params, $var->context->params);
                }else{
                    $exprs[] = "$k $op ?";
                    $params[] = $var;
                }
            }
        }

        self::condition($context, $prefix, implode(' AND ', $exprs), $params);
    }
    static public function condition(Context $context, $prefix, $expr, $args){

As per PSR2, the static declaration should come after the visibility declaration.

        if(!empty($expr)){
            $expr = "($expr)";
            if($args){
                //因为PDO不支持绑定数组变量, 这里需要手动展开数组
                //也就是说把 where("id IN(?)", [1,2])  展开成 where("id IN(?,?)", 1,2)

64% of this comment could be valid code. Did you maybe forget this after debugging?

                $cutted = null;
                $cut = null;
                $toReplace = array();

                $newArgs=array();
                //找到所有数组对应的?符位置
                foreach ($args as $k =>$arg){
                    if(is_array($arg) || is_a($arg, Raw::class) || is_a($arg, BasicRule::class)){

                        if(!$cutted){

The expression $cutted of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

                            $cut = new NestedStringCut($expr);
                            $cutted = $cut->getText();
                        }
                        //找到第$k个?符
                        $pos = self::findQ($cutted, 0, $k);
                        $pos = $cut->mapPos($pos);
                        $pos !== false or \PhpBoot\abort(

Using logical operators such as or instead of || is generally not recommended.

                            new \InvalidArgumentException("unmatched params and ? @ $expr"));

                        if(is_array($arg)){
                            $stubs = [];
                            foreach ($arg as $i){
                                if(is_a($i, Raw::class)){
                                    $stubs[] = strval($i);
                                }else{
                                    $stubs[] = '?';
                                    $newArgs[] = $i;
                                }
                            }
                            $stubs = implode(',', $stubs);
                        }elseif($arg instanceof BasicRule){

This code seems to be duplicated across your project.

                            $stubs = "({$arg->context->sql})";
                            $newArgs = array_merge($newArgs, $arg->context->params);
                        }else{
                            $stubs = strval($arg);
                        }
                        $toReplace[] = [$pos, $stubs];

                    }else{
                        $newArgs[]=$arg;
                    }
                }

                if(count($toReplace)){
                    $toReplace = array_reverse($toReplace);
                    foreach ($toReplace as $i){
                        list($pos, $v) = $i;
                        $expr = substr($expr, 0, $pos).$v.substr($expr, $pos+1);
                    }
                    $args = $newArgs;
                }
            }
            if($prefix){
                $context->appendSql($prefix.' '.$expr);
            }else{
                $context->appendSql($expr);
            }

            if($args){
                $context->appendParams($args);
            }
        }
    }
}

class GroupByImpl{

PSR1 recommends that each class should be in its own file to aid autoloaders.

    static public function groupBy(Context $context, $column){

As per PSR2, the static declaration should come after the visibility declaration.

        $column = DB::wrap($column);
        $context->appendSql("GROUP BY $column");
    }
}

class ExecImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    /**
     *
     * @param Context $context
     * @param $exceOnError boolean whether throw exceptions
     * @return ExecResult
     */
    static public function exec($context) {

As per PSR2, the static declaration should come after the visibility declaration.

        $st = $context->connection->prepare($context->sql);
        $success = $st->execute($context->params);
        return new ExecResult($success, $context->connection, $st);
    }
    /**
     *
     * @param Context $context
     * @param string|false $asDict return  as dict or array

There is no parameter named $asDict. Was it maybe removed?

     * @return false|array
     */
    static public function get($context, $dictAs=false){

As per PSR2, the static declaration should come after the visibility declaration.

        $st = $context->connection->prepare($context->sql);
        if($st->execute($context->params)){
            $res = $st->fetchAll(\PDO::FETCH_ASSOC);
            if ($dictAs){
                $dict= [];
                foreach ($res as $i){
                    $dict[$i[$dictAs]]=$i;
                }
                return $context->handleResult($dict);
            }
            return $context->handleResult($res);
        }else{
            return false;
        }
    }

    /**
     * @param Context $context
     * @return int|false
     */
    static public function count($context){

As per PSR2, the static declaration should come after the visibility declaration.

        $found = [];
        if(!preg_match('/\bselect\b/i', $context->sql, $found, PREG_OFFSET_CAPTURE) ||
            count($found)==0){
            \PhpBoot\abort(new \PDOException("can not use count(*) without select"));
        }
        list($chars, $columnBegin) = $found[0];

The assignment to $chars is unused. Consider omitting it like so list($first,,$third).

        $columnBegin = $columnBegin + strlen('select')+1;

        $columnEnd = 0;
        $found = [];
        if(!preg_match('/\bfrom\b/i', $context->sql, $found, PREG_OFFSET_CAPTURE) ||
            count($found)==0){
            $columnEnd = strlen($context->sql);
        }else{
            list($chars, $columnEnd) = $found[0];

The assignment to $chars is unused. Consider omitting it like so list($first,,$third).

        }
        $sql = substr($context->sql, 0, $columnBegin);
        $sql .= ' COUNT(*) as `count` ';
        $sql .= substr($context->sql, $columnEnd);

        $st = $context->connection->prepare($sql);
        if($st->execute($context->params)){
            $res = $st->fetchAll(\PDO::FETCH_ASSOC);
            return intval($res[0]['count']);
        }else{
            return false;
        }

    }
}
class OnDuplicateKeyUpdateImpl

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function set($context, $column, $value){
        if(is_string($column)){
            $this->setExpr($context, $column, $value);
        }else{
            $this->setArgs($context, $column);
        }
    }

    public function setExpr($context, $expr, $args){
        $prefix = '';

$prefix is not used, you could remove the assignment.

        if($this->first){
            $this->first = false;
            $prefix = 'ON DUPLICATE KEY UPDATE ';
        }else{
            $prefix = ',';
        }

        $context->appendSql("$prefix$expr",$prefix == 'ON DUPLICATE KEY UPDATE ');
        $context->appendParams($args);

    }
    public function setArgs($context, $values){

This method seems to be duplicated in your project.

        $set = [];
        $params = [];
        foreach ($values as $k=>$v){
            $k = DB::wrap($k);
            if(is_a($v, Raw::class)){//直接拼接sql，不需要转义
                $set[]= "$k=".$v->get();
            }else{
                $set[]= "$k=?";
                $params[]=$v;
            }
        }
        if($this->first){
            $this->first = false;
            $context->appendSql('ON DUPLICATE KEY UPDATE '.implode(',', $set));
            $context->appendParams($params);
        }else{
            $context->appendSql(','.implode(',', $set),false);
            $context->appendParams($params);
        }
    }
    private $first=true;
}