ModelWithClass::findWhere() - Code Metrics - Inspection of "1. DB security reinforce: warp column name with ``" - caoym/phpboot - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 083d1a...28e483 )

by cao

created 2017-08-08 08:47 UTC

ModelWithClass::findWhere() A

↳ Parent: ModelWithClass

Complexity

Conditions	2
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.686

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	1
nop	2
dl	0
loc	12
ccs	4
cts	9
cp	0.4444
crap	2.686
rs	9.4285
c	0
b	0
f	0

<?php
namespace PhpBoot\ORM;

use Doctrine\Common\Cache\Cache;
use PhpBoot\DB\DB;

class ModelWithClass
{
    /**
     * Model constructor.
     * @param DB $db
     * @param string $entityName
     * @param Cache $cache
     */
    public function __construct(DB $db, $entityName, Cache $cache)

    {
        $this->db = $db;
        $builder = $db->getApp()->get(ModelContainerBuilder::class);
        $this->entity = $builder->build($entityName);
    }

    /**
     * @param string $id
     * @return mixed|null
     */
    public function find($id)
    {
        $row = $this->db->select($this->getColumns())
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            ->from($this->entity->getTable())
            ->where("`{$this->entity->getPK()}` = ?", $id)
            ->getFirst();
        if($row){
            return $this->entity->make($row, false);
        }else{
            return null;
        }
    }

    /**
     * @return int rows deleted
     */
    public function delete($id)
    {
        return $this->db->deleteFrom($this->entity->getTable())
            ->where([$this->entity->getPK()=>$id])
            ->limit(1)
            ->exec()->rows;
    }

    /**
     * where 语法见 @see WhereRule
     * @param array|string $expr
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param mixed|null $_
     * @return \PhpBoot\DB\rules\basic\OrderByRule
     */
    public function deleteWhere($conditions, $_=null)

    {
        $query = $this->db->deleteFrom($this->entity->getTable());
        return call_user_func_array([$query, 'where'], func_get_args());
    }

    /**
     * @return false|int
     */
    public function count()
    {
        return $this->db->select($this->getColumns())
            ->from($this->entity->getTable())
            ->count();
    }

    /**
     * where 语法见 @see WhereRule
     * @param array|string|null $conditions
     * @param string $_
     * @return \PhpBoot\DB\rules\select\GroupByRule
     */
    public function findWhere($conditions=null, $_=null)

    {
        $query =  $this->db->select($this->getColumns())
            ->from($this->entity->getTable());
        $query->context->resultHandler = function ($result){
            foreach ($result as &$i){
                $i = $this->entity->make($i, false);
            }
            return $result;
        };
        return call_user_func_array([$query, 'where'], func_get_args());
    }

    /**
     * where 语法见 @see WhereRule
     * @param array|string $expr
     * @param mixed|null $_
     * @return \PhpBoot\DB\rules\basic\WhereRule
     */
    public function update($expr, $_=null)

    {
        $query =  $this->db->update($this->entity->getTable());
        return call_user_func_array([$query, 'set'], func_get_args());
    }

    protected function getColumns()
    {
        $columns = [];
        foreach ($this->entity->getProperties() as $p){
            $columns[] = $p->name;
        }
        return $columns;
    }
    /**
     * @var ModelContainer
     */
    protected $entity;
    /**
     * @var DB
     */
    protected $db;
}

1		<?php
2		namespace PhpBoot\ORM;
3
4		use Doctrine\Common\Cache\Cache;
5		use PhpBoot\DB\DB;
6
7		class ModelWithClass
8		{
9		/**
10		* Model constructor.
11		* @param DB $db
12		* @param string $entityName
13		* @param Cache $cache
14		*/
15	6	public function __construct(DB $db, $entityName, Cache $cache)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$cache` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
16		{
17	6	$this->db = $db;
18	6	$builder = $db->getApp()->get(ModelContainerBuilder::class);
19	6	$this->entity = $builder->build($entityName);
20	6	}
21
22		/**
23		* @param string $id
24		* @return mixed\|null
25		*/
26	1	public function find($id)
27		{
28	1	$row = $this->db->select($this->getColumns())
		0 ignored issues – show Bug introduced 2017-08-04 16:03 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$row` is correct as `$this->db->select($this-... = ?", $id)->getFirst()` (which targets `PhpBoot\DB\rules\select\GetRule::getFirst()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
29	1	->from($this->entity->getTable())
30	1	->where("`{$this->entity->getPK()}` = ?", $id)
31	1	->getFirst();
32	1	if($row){
33		return $this->entity->make($row, false);
34		}else{
35	1	return null;
36		}
37		}
38
39		/**
40		* @return int rows deleted
41		*/
42	1	public function delete($id)
43		{
44	1	return $this->db->deleteFrom($this->entity->getTable())
45	1	->where([$this->entity->getPK()=>$id])
46	1	->limit(1)
47	1	->exec()->rows;
48		}
49
50		/**
51		* where 语法见 @see WhereRule
52		* @param array\|string $expr
		0 ignored issues – show Bug introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report There is no parameter named `$expr`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
53		* @param mixed\|null $_
54		* @return \PhpBoot\DB\rules\basic\OrderByRule
55		*/
56	1	public function deleteWhere($conditions, $_=null)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$conditions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$_` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57		{
58	1	$query = $this->db->deleteFrom($this->entity->getTable());
59	1	return call_user_func_array([$query, 'where'], func_get_args());
60		}
61
62		/**
63		* @return false\|int
64		*/
65		public function count()
66		{
67		return $this->db->select($this->getColumns())
68		->from($this->entity->getTable())
69		->count();
70		}
71
72		/**
73		* where 语法见 @see WhereRule
74		* @param array\|string\|null $conditions
75		* @param string $_
76		* @return \PhpBoot\DB\rules\select\GroupByRule
77		*/
78	2	public function findWhere($conditions=null, $_=null)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$conditions` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$_` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
79		{
80	2	$query = $this->db->select($this->getColumns())
81	2	->from($this->entity->getTable());
82		$query->context->resultHandler = function ($result){
83		foreach ($result as &$i){
84		$i = $this->entity->make($i, false);
85		}
86		return $result;
87		};
88	2	return call_user_func_array([$query, 'where'], func_get_args());
89		}
90
91		/**
92		* where 语法见 @see WhereRule
93		* @param array\|string $expr
94		* @param mixed\|null $_
95		* @return \PhpBoot\DB\rules\basic\WhereRule
96		*/
97	1	public function update($expr, $_=null)
		0 ignored issues – show Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$expr` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-08 08:50 UTC by Report Bug Copy Issue Report The parameter `$_` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
98		{
99	1	$query = $this->db->update($this->entity->getTable());
100	1	return call_user_func_array([$query, 'set'], func_get_args());
101		}
102
103	3	protected function getColumns()
104		{
105	3	$columns = [];
106	3	foreach ($this->entity->getProperties() as $p){
107	3	$columns[] = $p->name;
108	3	}
109	3	return $columns;
110		}
111		/**
112		* @var ModelContainer
113		*/
114		protected $entity;
115		/**
116		* @var DB
117		*/
118		protected $db;
119		}

caoym / phpboot

GitHub Access Token became invalid

Push — master ( 083d1a...28e483 )

ModelWithClass::findWhere() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like