PhpBoot\DB\rules\update\UpdateSetWhereRule

Complexity

Total Complexity

2

Size/Duplication

Total Lines	20
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

57.14%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	set()	4	4	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 10.

namespace PhpBoot\DB\rules\update;
use PhpBoot\DB\Context;
use PhpBoot\DB\rules\basic\BasicRule;
use PhpBoot\DB\rules\basic\WhereRule;
use PhpBoot\DB\impls\UpdateSetImpl;
use PhpBoot\DB\impls\UpdateImpl;


require_once dirname(__DIR__).'/impls.php';
require_once __DIR__.'/basic.php';

class UpdateRule extends BasicRule
{
    /**
     * update('table')->set('a', 1) => "UPDATE table SET a=1"
     * @param string $table
     * @return \PhpBoot\DB\rules\update\UpdateSetRule
     */
    public function update($table) {
        UpdateImpl::update($this->context, $table);
        return new UpdateSetRule($this->context);
    }
}

class UpdateSetRule extends BasicRule

This class seems to be duplicated in your project.

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function __construct($context){
        parent::__construct($context);
        $this->impl = new UpdateSetImpl();
    }
    /**
     * update('table')->set(['a'=>1]) => "UPDATE table SET a=1"

     * update('table')->set('a=?',1) => "UPDATE table SET a=1"
     * @param array|string $expr
     * @param mixed $_
     * @return UpdateSetWhereRule
     */
    public function set($expr, $_=null) {

The parameter $_ is not used and could be removed.

        $this->impl->set($this->context, $expr, array_slice(func_get_args(), 1));
        return new UpdateSetWhereRule($this->context, $this->impl);
    }
    private $impl;
}

class UpdateSetWhereRule extends WhereRule

This class seems to be duplicated in your project.

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function __construct(Context $context, UpdateSetImpl $impl){
        parent::__construct($context);
        $this->impl = $impl;
    }
    /**
     * update('table')->set(['a'=>1]) => "UPDATE table SET a=1"

     * update('table')->set('a=?',1) => "UPDATE table SET a=1"
     * @param array|string $expr
     * @param mixed $_
     * @return WhereRule
     */
    public function set($expr, $_=null) {

The parameter $_ is not used and could be removed.

        $this->impl->set($this->context, $expr, array_slice(func_get_args(), 1));
        return new UpdateSetWhereRule($this->context, $this->impl);
    }
    private $impl;

Consider using a different property name as you override a private property of the parent class.

}