PhpBoot\Console\ConsoleContainerBuilder

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	25.45 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

88.24%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	14	14	2
A	createContainer()	0	4	1
A	handleAnnotation()	0	5	1
A	postCreateContainer()	0	6	1

<?php
/**
 * Created by PhpStorm.
 * User: caoyangmin
 * Date: 2018/6/14
 * Time: 下午2:10
 */

namespace PhpBoot\Console;


use DI\FactoryInterface;
use Doctrine\Common\Cache\Cache;
use PhpBoot\Annotation\ContainerBuilder;
use DI\InvokerInterface as DIInvokerInterface;
use PhpBoot\Console\Annotations\ClassAnnotationHandler;
use PhpBoot\Console\Annotations\CommandAnnotationHandler;
use PhpBoot\Console\Annotations\CommandNameAnnotationHandler;
use PhpBoot\Console\Annotations\ParamAnnotationHandler;
use PhpBoot\Console\Annotations\ValidateAnnotationHandler;

class ConsoleContainerBuilder extends ContainerBuilder
{
    static $DEFAULT_ANNOTATIONS=[

The visibility should be declared for property $DEFAULT_ANNOTATIONS.

        [ClassAnnotationHandler::class, 'class'],
        [CommandNameAnnotationHandler::class, "class.children[?name=='command']"],
        [CommandAnnotationHandler::class, "methods.*.children[?name=='command'][]"],
        [ParamAnnotationHandler::class, "methods.*.children[?name=='param'][]"],
        [ValidateAnnotationHandler::class, "methods.*.children[].children[?name=='v'][]"],
    ];
    /**
     * @var FactoryInterface
     */
    private $factory;
    /**
     * @var DIInvokerInterface
     */
    private $diInvoker;

    public function __construct(FactoryInterface $factory,

This method seems to be duplicated in your project.

                                DIInvokerInterface $diInvoker,
                                Cache $cache,
                                array $annotations = null
    )
    {
        if($annotations){
            parent::__construct($annotations, $cache);
        }else{
            parent::__construct(self::$DEFAULT_ANNOTATIONS, $cache);
        }
        $this->factory = $factory;
        $this->diInvoker = $diInvoker;
    }

    /**
     * @param string $className
     * @return ConsoleContainer
     */
    protected function createContainer($className)
    {
        return $this->factory->make(ConsoleContainer::class, ['className'=>$className]);
    }

    protected function handleAnnotation($handlerName, $container, $ann)
    {
        $handler = $this->factory->make($handlerName);
        return $this->diInvoker->call($handler, [$container, $ann]);

$handler is of type *, but the function expects a callable.

    }

    protected function postCreateContainer($object)
    {
        parent::postCreateContainer($object);
        /**@var ConsoleContainer $object*/
        $object->postCreate();
    }
}