PhpBoot\Console

Complexity

Total Complexity

11

Size/Duplication

Total Lines	71
Duplicated Lines	35.21 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

33.33%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1
A	loadCommandsFromClass()	0	14	2
C	loadRoutesFromPath()	25	25	8

<?php
/**
 * Created by PhpStorm.
 * User: caoyangmin
 * Date: 2018/6/14
 * Time: 下午6:11
 */

namespace PhpBoot;

use DI\FactoryInterface;
use PhpBoot\Console\ConsoleContainer;
use PhpBoot\Console\ConsoleContainerBuilder;
use PhpBoot\DI\Traits\EnableDIAnnotations;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class Console extends \Symfony\Component\Console\Application
{
    use EnableDIAnnotations;

    /**
     * @inject
     * @var ConsoleContainerBuilder
     */
    protected $consoleContainerBuilder;

    /**
     * @param FactoryInterface $factory
     * @return Console
     * @throws \DI\DependencyException
     * @throws \DI\NotFoundException
     */
    static public function create(FactoryInterface $factory)

As per PSR2, the static declaration should come after the visibility declaration.

    {
        return $factory->make(self::class);
    }
    /**
     * @param $className
     * @throws \Exception
     */
    public function loadCommandsFromClass($className)
    {
        $console = null;

$console is not used, you could remove the assignment.

        $container = null;

$container is not used, you could remove the assignment.

        $container = $this->consoleContainerBuilder->build($className);
        /**@var ConsoleContainer $container*/
        foreach ($container->getCommands() as $name => $command) {
            $command->setCode(function (InputInterface $input, OutputInterface $output)use ($container, $command){
                return $command->invoke($container, $input, $output);
            });
            $this->add($command);
        }
    }

    /**
     * @param $fromPath
     * @param string $namespace
     * @throws \Exception
     */
    public function loadRoutesFromPath($fromPath, $namespace = '')

This method seems to be duplicated in your project.

    {
        $dir = @dir($fromPath) or abort("dir $fromPath not exist");

Using logical operators such as or instead of || is generally not recommended.

        $getEach = function () use ($dir) {
            $name = $dir->read();
            if (!$name) {
                return $name;
            }
            return $name;
        };

        while (!!($entry = $getEach())) {
            if ($entry == '.' || $entry == '..') {
                continue;
            }
            $path = $fromPath . '/' . str_replace('\\', '/', $entry);
            if (is_file($path) && substr_compare($entry, '.php', strlen($entry) - 4, 4, true) == 0) {
                $class_name = $namespace . '\\' . substr($entry, 0, strlen($entry) - 4);
                $this->loadCommandsFromClass($class_name);
            } else {

This else statement is empty and can be removed.

                //\Log::debug($path.' ignored');

67% of this comment could be valid code. Did you maybe forget this after debugging?

            }
        }
    }

}