caoym / phpboot

src/Console.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use PhpBoot\Console\ConsoleContainer;
 use PhpBoot\Console\ConsoleContainerBuilder;
 use PhpBoot\DI\Traits\EnableDIAnnotations;
-use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         return $factory->make(self::class);
     }
     /**
-     * @param $className
+     * @param string $className
      * @throws \Exception
      */
     public function loadCommandsFromClass($className)

Spacing +5 added lines, -5 removed lines

@@ -55,7 +55,7 @@ 
         $container = $this->consoleContainerBuilder->build($className);
         /**@var ConsoleContainer $container*/
         foreach ($container->getCommands() as $name => $command) {
-            $command->setCode(function (InputInterface $input, OutputInterface $output)use ($container, $command){
+            $command->setCode(function(InputInterface $input, OutputInterface $output)use ($container, $command){
                 return $this->diInvoker->call([$command, 'invoke'], ['container'=>$container, 'input'=>$input, 'output'=>$output]);
             });
             $this->add($command);
@@ -71,7 +71,7 @@ 
     {
         $dir = @dir($fromPath) or abort("dir $fromPath not exist");
 
-        $getEach = function () use ($dir) {
+        $getEach = function() use ($dir) {
             $name = $dir->read();
             if (!$name) {
                 return $name;
@@ -83,11 +83,11 @@ 
             if ($entry == '.' || $entry == '..') {
                 continue;
             }
-            $path = $fromPath . '/' . str_replace('\\', '/', $entry);
+            $path = $fromPath.'/'.str_replace('\\', '/', $entry);
             if (is_file($path) && substr_compare($entry, '.php', strlen($entry) - 4, 4, true) == 0) {
-                $class_name = $namespace . '\\' . substr($entry, 0, strlen($entry) - 4);
+                $class_name = $namespace.'\\'.substr($entry, 0, strlen($entry) - 4);
                 $this->loadCommandsFromClass($class_name);
-            } else {
+            }else {
                 //\Log::debug($path.' ignored');
             }
         }

src/Console/Annotations/CommandAnnotationHandler.php

Unused Use Statements -7 removed lines

@@ -2,17 +2,10 @@
 
 namespace PhpBoot\Console\Annotations;
 
-use DI\InvokerInterface;
-use FastRoute\RouteParser\Std;
 use PhpBoot\Console\Command;
 use PhpBoot\Console\ConsoleContainer;
 use PhpBoot\Entity\ContainerFactory;
 use PhpBoot\Entity\EntityContainerBuilder;
-use PhpBoot\Metas\ReturnMeta;
-use PhpBoot\Annotation\AnnotationBlock;
-use PhpBoot\Annotation\AnnotationTag;
-use PhpBoot\Entity\MixedTypeContainer;
-use PhpBoot\Exceptions\AnnotationSyntaxException;
 use PhpBoot\Metas\ParamMeta;
 use PhpBoot\Utils\AnnotationParams;
 

Spacing +5 added lines, -5 removed lines

@@ -25,7 +25,7 @@ 
         $name = $params->getParam(0, $target);
 
         //获取方法参数信息
-        $rfl =  new \ReflectionClass($container->getClassName());
+        $rfl = new \ReflectionClass($container->getClassName());
         $method = $rfl->getMethod($target);
         $methodParams = $method->getParameters();
 
@@ -35,19 +35,19 @@ 
 
         //设置参数列表
         $paramsMeta = [];
-        foreach ($methodParams as $param){
+        foreach ($methodParams as $param) {
             $paramName = $param->getName();
             $source = "argv.$paramName";
             $paramClass = $param->getClass();
-            if($paramClass){
+            if ($paramClass) {
                 $paramClass = $paramClass->getName();
             }
             $entityContainer = ContainerFactory::create($entityBuilder, $paramClass);
             $meta = new ParamMeta($paramName,
                 $source,
-                $paramClass?:'mixed',
+                $paramClass ?: 'mixed',
                 $param->isOptional(),
-                $param->isOptional()?$param->getDefaultValue():null,
+                $param->isOptional() ? $param->getDefaultValue() : null,
                 $param->isPassedByReference(),
                 null,
                 '',

src/Console/Command.php

Doc Comments +3 added lines

@@ -64,6 +64,9 @@
         }
     }
 
+    /**
+     * @param string|null $name
+     */
     public function getParamMeta($name)
     {
         foreach ($this->paramMetas as $meta){

Braces +3 added lines, -3 removed lines

@@ -105,13 +105,13 @@ 
                 }
                 if($meta->container){
                     $inputs[$meta->name] = $meta->container->make($source);
-                }else{
+                } else{
                     $inputs[$meta->name] = $source;
                 }
                 if($meta->validation){
                     $vld->rule($meta->validation, $meta->name);
                 }
-            }else{
+            } else{
                 $meta->isOptional or \PhpBoot\abort(new \InvalidArgumentException("the parameter \"{$meta->source}\" is missing"));
                 $inputs[$meta->name] = $meta->default;
             }
@@ -130,7 +130,7 @@ 
         foreach ($this->paramMetas as $meta){
             if($meta->isPassedByReference){
                 $params[$pos] = null;
-            }else{
+            } else{
                 $params[$pos] = $inputs[$meta->name];
             }
             $pos++;

Spacing +22 added lines, -22 removed lines

@@ -35,7 +35,7 @@ 
 
     public function __construct($actionName, $name)
     {
-        parent::__construct($name?:$actionName);
+        parent::__construct($name ?: $actionName);
         $this->actionName = $actionName;
     }
     /**
@@ -48,14 +48,14 @@ 
 
     public function postCreate(ConsoleContainer $container)
     {
-        if($container->getModuleName()){
+        if ($container->getModuleName()) {
             $this->setName($container->getModuleName().'.'.$this->getName());
         }
 
-        foreach ($this->paramMetas as $paramMeta){
-            $mode = $paramMeta->isOptional?InputArgument::OPTIONAL:InputArgument::REQUIRED;
-            if($paramMeta->container instanceof ArrayContainer || $paramMeta->container instanceof EntityContainer){
-                $mode = $mode|InputArgument::IS_ARRAY;
+        foreach ($this->paramMetas as $paramMeta) {
+            $mode = $paramMeta->isOptional ?InputArgument::OPTIONAL : InputArgument::REQUIRED;
+            if ($paramMeta->container instanceof ArrayContainer || $paramMeta->container instanceof EntityContainer) {
+                $mode = $mode | InputArgument::IS_ARRAY;
             }
             $this->addArgument($paramMeta->name,
                 $mode,
@@ -67,8 +67,8 @@ 
 
     public function getParamMeta($name)
     {
-        foreach ($this->paramMetas as $meta){
-            if($meta->name == $name){
+        foreach ($this->paramMetas as $meta) {
+            if ($meta->name == $name) {
                 return $meta;
             }
         }
@@ -84,40 +84,40 @@ 
      * @throws \DI\DependencyException
      * @throws \DI\NotFoundException
      */
-    public function invoke(FactoryInterface $factory,ConsoleContainer $container, InputInterface $input, OutputInterface $output)
+    public function invoke(FactoryInterface $factory, ConsoleContainer $container, InputInterface $input, OutputInterface $output)
     {
         $params = [];
         $reference = [];
-        $this->bindInput($input, $params,$reference);
+        $this->bindInput($input, $params, $reference);
         $code = call_user_func_array([$container->getInstance($factory), $this->actionName], $params);
         return $code;
     }
 
-    public function bindInput(InputInterface $input, array &$params, array &$reference){
+    public function bindInput(InputInterface $input, array &$params, array &$reference) {
         $vld = new Validator();
         $req = ['argv'=>$input->getArguments()];
         $requestArray = new ArrayAdaptor($req);
         $inputs = [];
-        foreach ($this->paramMetas as $k=>$meta){
-            if($meta->isPassedByReference){
+        foreach ($this->paramMetas as $k=>$meta) {
+            if ($meta->isPassedByReference) {
                 // param PassedByReference is used to output
                 continue;
             }
             $source = \JmesPath\search($meta->source, $requestArray);
-            if ($source !== null){
+            if ($source !== null) {
                 $source = ArrayAdaptor::strip($source);
-                if($source instanceof ParameterBag){
+                if ($source instanceof ParameterBag) {
                     $source = $source->all();
                 }
-                if($meta->container){
+                if ($meta->container) {
                     $inputs[$meta->name] = $meta->container->make($source);
-                }else{
+                }else {
                     $inputs[$meta->name] = $source;
                 }
-                if($meta->validation){
+                if ($meta->validation) {
                     $vld->rule($meta->validation, $meta->name);
                 }
-            }else{
+            }else {
                 $meta->isOptional or \PhpBoot\abort(new \InvalidArgumentException("the parameter \"{$meta->source}\" is missing"));
                 $inputs[$meta->name] = $meta->default;
             }
@@ -133,10 +133,10 @@ 
         );
 
         $pos = 0;
-        foreach ($this->paramMetas as $meta){
-            if($meta->isPassedByReference){
+        foreach ($this->paramMetas as $meta) {
+            if ($meta->isPassedByReference) {
                 $params[$pos] = null;
-            }else{
+            }else {
                 $params[$pos] = $inputs[$meta->name];
             }
             $pos++;

src/Console/ConsoleContainerBuilder.php

Spacing +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
 
 class ConsoleContainerBuilder extends ContainerBuilder
 {
-    static $DEFAULT_ANNOTATIONS=[
+    static $DEFAULT_ANNOTATIONS = [
         [ClassAnnotationHandler::class, 'class'],
         [CommandNameAnnotationHandler::class, "class.children[?name=='command']"],
         [CommandAnnotationHandler::class, "methods.*.children[?name=='command'][]"],
@@ -43,9 +43,9 @@ 
                                 array $annotations = null
     )
     {
-        if($annotations){
+        if ($annotations) {
             parent::__construct($annotations, $cache);
-        }else{
+        }else {
             parent::__construct(self::$DEFAULT_ANNOTATIONS, $cache);
         }
         $this->factory = $factory;

Braces +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     {
         if($annotations){
             parent::__construct($annotations, $cache);
-        }else{
+        } else{
             parent::__construct(self::$DEFAULT_ANNOTATIONS, $cache);
         }
         $this->factory = $factory;

src/Console/Annotations/ParamAnnotationHandler.php

Spacing +9 added lines, -9 removed lines

@@ -22,17 +22,17 @@ 
         $paramType = null;
         $paramName = null;
         $paramDoc = '';
-        if(substr($text, 0, 1) == '$'){ //带$前缀的是变量
+        if (substr($text, 0, 1) == '$') { //带$前缀的是变量
             $params = new AnnotationParams($text, 2);
             $paramName = substr($params->getParam(0), 1);
             $paramDoc = $params->getRawParam(1, '');
-        }else{
+        }else {
             $params = new AnnotationParams($text, 3);
-            if ($params->count() >=2 && substr($params->getParam(1), 0, 1) == '$'){
+            if ($params->count()>=2 && substr($params->getParam(1), 0, 1) == '$') {
                 $paramType = $params->getParam(0); //TODO 检测类型是否合法
                 $paramName = substr($params->getParam(1), 1);
                 $paramDoc = $params->getRawParam(2, '');
-            }else{
+            }else {
                 \PhpBoot\abort(new AnnotationSyntaxException("@param $text syntax error"));
             }
         }
@@ -45,15 +45,15 @@ 
      */
     public function __invoke(ConsoleContainer $container, $ann, EntityContainerBuilder $entityBuilder)
     {
-        if(!$ann->parent){
+        if (!$ann->parent) {
             //Logger::debug("The annotation \"@{$ann->name} {$ann->description}\" of {$container->getClassName()} should be used with parent route");
             return;
         }
         $target = $ann->parent->name;
         $command = $container->getCommand($target);
-        if(!$command){
+        if (!$command) {
             //Logger::debug("The annotation \"@{$ann->name} {$ann->description}\" of {$container->getClassName()}::$target should be used with parent route");
-            return ;
+            return;
         }
         $className = $container->getClassName();
 
@@ -62,8 +62,8 @@ 
         $paramMeta = $command->getParamMeta($paramName);
         $paramMeta or \PhpBoot\abort(new AnnotationSyntaxException("$className::$target param $paramName not exist "));
         //TODO 检测声明的类型和注释的类型是否匹配
-        if($paramType){
-            $paramMeta->type = TypeHint::normalize($paramType, $className);//or \PhpBoot\abort(new AnnotationSyntaxException("{$container->getClassName()}::{$ann->parent->name} @{$ann->name} syntax error, param $paramName unknown type:$paramType "));
+        if ($paramType) {
+            $paramMeta->type = TypeHint::normalize($paramType, $className); //or \PhpBoot\abort(new AnnotationSyntaxException("{$container->getClassName()}::{$ann->parent->name} @{$ann->name} syntax error, param $paramName unknown type:$paramType "));
             $container = ContainerFactory::create($entityBuilder, $paramMeta->type);
             $paramMeta->container = $container;
         }

Braces +2 added lines, -2 removed lines

@@ -25,13 +25,13 @@
             $params = new AnnotationParams($text, 2);
             $paramName = substr($params->getParam(0), 1);
             $paramDoc = $params->getRawParam(1, '');
-        }else{
+        } else{
             $params = new AnnotationParams($text, 3);
             if ($params->count() >=2 && substr($params->getParam(1), 0, 1) == '$'){
                 $paramType = $params->getParam(0); //TODO 检测类型是否合法
                 $paramName = substr($params->getParam(1), 1);
                 $paramDoc = $params->getRawParam(2, '');
-            }else{
+            } else{
                 \PhpBoot\abort(new AnnotationSyntaxException("@param $text syntax error"));
             }
         }

src/Console/Annotations/ValidateAnnotationHandler.php

Spacing +7 added lines, -7 removed lines

@@ -18,29 +18,29 @@
      */
     public function __invoke(ConsoleContainer $container, $ann)
     {
-        if(!$ann->parent || !$ann->parent->parent){
+        if (!$ann->parent || !$ann->parent->parent) {
             Logger::debug("The annotation \"@{$ann->name} {$ann->description}\" of {$container->getClassName()} should be used with parent parent");
             return;
         }
         $target = $ann->parent->parent->name;
         $command = $container->getCommand($target);
-        if(!$command){
+        if (!$command) {
             Logger::debug("The annotation \"@{$ann->name} {$ann->description}\" of {$container->getClassName()}::$target should be used with parent parent");
-            return ;
+            return;
         }
         $params = new AnnotationParams($ann->description, 2);
 
         count($params)>0 or \PhpBoot\abort(new AnnotationSyntaxException("The annotation \"@{$ann->name} {$ann->description}\" of {$container->getClassName()}::$target require 1 param, {$params->count()} given"));
 
-        if($ann->parent->name == 'param'){
+        if ($ann->parent->name == 'param') {
             list($paramType, $paramName, $paramDoc) = ParamAnnotationHandler::getParamInfo($ann->parent->description);
 
             $paramMeta = $command->getParamMeta($paramName);
-            if($params->count()>1){
+            if ($params->count()>1) {
                 $paramMeta->validation = [$params[0], $params[1]];
-            }else{
+            }else {
                 $paramMeta->validation = $params[0];
-                if($paramMeta->validation) {
+                if ($paramMeta->validation) {
                     $v = new Validator();
                     $v->rule($paramMeta->validation, $paramMeta->name);
                     if ($v->hasRule('optional', $paramMeta->name)) {

Braces +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             $paramMeta = $command->getParamMeta($paramName);
             if($params->count()>1){
                 $paramMeta->validation = [$params[0], $params[1]];
-            }else{
+            } else{
                 $paramMeta->validation = $params[0];
                 if($paramMeta->validation) {
                     $v = new Validator();

src/Console/ConsoleContainer.php

Spacing +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
 
     public function getCommand($target)
     {
-        return isset($this->commands[$target])?$this->commands[$target]:null;
+        return isset($this->commands[$target]) ? $this->commands[$target] : null;
     }
     /**
      * @return string
@@ -97,7 +97,7 @@ 
     }
     public function postCreate()
     {
-        foreach ($this->commands as $command){
+        foreach ($this->commands as $command) {
             $command->postCreate($this);
         }
     }
@@ -113,8 +113,8 @@ 
      */
     public function getInstance(FactoryInterface $factory)
     {
-        if(!$this->instance ){
-            $this->instance  = $factory->make($this->getClassName());
+        if (!$this->instance) {
+            $this->instance = $factory->make($this->getClassName());
         }
         return $this->instance;
     }

src/Lock/LocalAutoLock.php

Spacing +20 added lines, -20 removed lines

@@ -8,20 +8,20 @@ 
  */
 class LocalAutoLock
 {
-    static function lock($key, $seconds, callable $success, callable $error=null){
+    static function lock($key, $seconds, callable $success, callable $error = null) {
         $key = 'lock:'.$key;
-        if(function_exists('apc_add')){
+        if (function_exists('apc_add')) {
             $lock = new ApcLock();
-        }else{
+        }else {
             $lock = new FileLock();
         }
-        try{
-            if(!isset(self::$currentLock[$key])){
+        try {
+            if (!isset(self::$currentLock[$key])) {
                 self::$currentLock[$key] = 0;
             }
-            if(self::$currentLock[$key] == 0){  //未加锁
-                if(!$lock->lock($key, $seconds)){ //加锁失败
-                    if($error){
+            if (self::$currentLock[$key] == 0) {  //未加锁
+                if (!$lock->lock($key, $seconds)) { //加锁失败
+                    if ($error) {
                         return $error();
                     }
                     return;
@@ -29,37 +29,37 @@ 
             }
             //嵌套加锁
             self::$currentLock[$key]++;
-        }catch (\Exception $e){
-            if($error){
+        }catch (\Exception $e) {
+            if ($error) {
                 return $error();
             }
             return;
         }
         $res = null;
-        try{
+        try {
             $res = $success();
-        }catch (\Exception $e){
+        }catch (\Exception $e) {
             self::$currentLock[$key]--;
-            if(self::$currentLock[$key] == 0){
-                try{
+            if (self::$currentLock[$key] == 0) {
+                try {
                     $lock->unlock($key);
-                }catch (\Exception $e){
+                }catch (\Exception $e) {
 
                 }
             }
             throw $e;
         }
         self::$currentLock[$key]--;
-        if(self::$currentLock[$key] == 0){
-            try{
+        if (self::$currentLock[$key] == 0) {
+            try {
                 $lock->unlock($key);
-            }catch (\Exception $e){
+            }catch (\Exception $e) {
 
             }
         }
         return $res;
     }
 
-    private $cache=[];
-    static private $currentLock=[];
+    private $cache = [];
+    static private $currentLock = [];
 }
\ No newline at end of file

Braces +5 added lines, -5 removed lines

@@ -12,7 +12,7 @@ 
         $key = 'lock:'.$key;
         if(function_exists('apc_add')){
             $lock = new ApcLock();
-        }else{
+        } else{
             $lock = new FileLock();
         }
         try{
@@ -29,7 +29,7 @@ 
             }
             //嵌套加锁
             self::$currentLock[$key]++;
-        }catch (\Exception $e){
+        } catch (\Exception $e){
             if($error){
                 return $error();
             }
@@ -38,12 +38,12 @@ 
         $res = null;
         try{
             $res = $success();
-        }catch (\Exception $e){
+        } catch (\Exception $e){
             self::$currentLock[$key]--;
             if(self::$currentLock[$key] == 0){
                 try{
                     $lock->unlock($key);
-                }catch (\Exception $e){
+                } catch (\Exception $e){
 
                 }
             }
@@ -53,7 +53,7 @@ 
         if(self::$currentLock[$key] == 0){
             try{
                 $lock->unlock($key);
-            }catch (\Exception $e){
+            } catch (\Exception $e){
 
             }
         }

src/Utils/SafeFileWriter.php

Spacing +3 added lines, -3 removed lines

@@ -16,15 +16,15 @@
      * @param boolean $overwrite 是否覆盖已有文件
      * @return boolean
      */
-    static public function write($path, $data, $overwrite = true){
+    static public function write($path, $data, $overwrite = true) {
         $path = str_replace('\\', '/', $path);
         $fileDir = dirname($path);
         $tmpFile = tempnam($fileDir, 'safe_writer_');
         false !== @file_put_contents($tmpFile, $data) or \PhpBoot\abort("write to file: $tmpFile failed");
-        if($overwrite){
+        if ($overwrite) {
             @unlink($path); //删除原始文件
         }
-        if(!rename($tmpFile, $path)){
+        if (!rename($tmpFile, $path)) {
             @unlink($tmpFile); //删除原始文件
             \PhpBoot\abort("write to file: $tmpFile failed");
             return false;