View::set() - Code Metrics - Inspection of "Prepare to tag" - canax/view - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2a3466...2685c9 )

by Mikael

created 2018-08-01 12:36 UTC

View::set() B

↳ Parent: View

Complexity

Conditions	6
Paths	17

Size

Total Lines

Duplication

Lines	32
Ratio	100 %

Code Coverage

Tests	7
CRAP Score	16.6682

Importance

Changes

Metric	Value
cc	6
nc	17
nop	4
dl	32
loc	32
ccs	7
cts	21
cp	0.3333
crap	16.6682
rs	8.7857
c	0
b	0
f	0

<?php

namespace Anax\View;

use \Anax\View\ViewRenderFile;
use \Anax\View\Exception;

/**
 * A view connected to a template file.
 */
class View

{
    /**
     * @var $template     Template file or array
     * @var $templateData Data to send to template file
     * @var $sortOrder    For sorting views
     * @var $type         Type of view
     */
    private $template;
    private $templateData = [];
    private $sortOrder;
    private $type;



    /**
     * Set values for the view.
     *
     * @param array|string $template the template file, or array
     * @param array        $data     variables to make available to the
     *                               view, default is empty
     * @param integer      $sort     which order to display the views,
     *                               if suitable
     * @param string       $type     which type of view
     *
     * @return self
     */
    public function set($template, $data = [], $sort = 0, $type = "file")
    {
        if (is_array($template)) {
            if (isset($template["callback"])) {
                $type = "callback";
                $this->template = $template;
            } else {
                $this->template = $template["template"];
            }

            $this->templateData = isset($template["data"])
                ? $template["data"]
                : $data;

            $this->sortOrder = isset($template["sort"])
                ? $template["sort"]
                : $sort;

            $this->type = isset($template["type"])
                ? $template["type"]
                : $type;

            return;
        }

        $this->template     = $template;
        $this->templateData = $data;
        $this->sortOrder    = $sort;
        $this->type         = $type;

        return $this;
    }



    /**
     * Render the view.
     *
     * @param object $app optional with access to the framework resources.
     *
     * @return void
     */
    public function render($app = null)
    {
        switch ($this->type) {
            case "file":
                if (!$app) {
                    throw new Exception("View missing \$app.");
                }
                $viewRender = new ViewRenderFile();
                $viewRender->setApp($app);
                $viewRender->render($this->template, $this->templateData);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                break;

            case "callback":
                if (!isset($this->template["callback"]) || !is_callable($this->template["callback"])) {
                    throw new Exception("View missing callback.");
                }

                echo call_user_func($this->template["callback"]);

                break;

            case "string":
                echo $this->template;

                break;

            default:
                throw new Exception("Not a valid template type: {$this->type}");
        }
    }



    /**
     * Give the sort order for this view.
     *
     * @return int
     */
    public function sortOrder()
    {
        return $this->sortOrder;
    }
}


1			<?php
2
3			namespace Anax\View;
4
5			use \Anax\View\ViewRenderFile;
6			use \Anax\View\Exception;
7
8			/**
9			* A view connected to a template file.
10			*/
11		View Code Duplication	class View
			0 ignored issues – show Duplication introduced 2017-08-10 15:22 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12			{
13			/**
14			* @var $template Template file or array
15			* @var $templateData Data to send to template file
16			* @var $sortOrder For sorting views
17			* @var $type Type of view
18			*/
19			private $template;
20			private $templateData = [];
21			private $sortOrder;
22			private $type;
23
24
25
26			/**
27			* Set values for the view.
28			*
29			* @param array\|string $template the template file, or array
30			* @param array $data variables to make available to the
31			* view, default is empty
32			* @param integer $sort which order to display the views,
33			* if suitable
34			* @param string $type which type of view
35			*
36			* @return self
37			*/
38	3		public function set($template, $data = [], $sort = 0, $type = "file")
39			{
40	3		if (is_array($template)) {
41			if (isset($template["callback"])) {
42			$type = "callback";
43			$this->template = $template;
44			} else {
45			$this->template = $template["template"];
46			}
47
48			$this->templateData = isset($template["data"])
49			? $template["data"]
50			: $data;
51
52			$this->sortOrder = isset($template["sort"])
53			? $template["sort"]
54			: $sort;
55
56			$this->type = isset($template["type"])
57			? $template["type"]
58			: $type;
59
60			return;
61			}
62
63	3		$this->template = $template;
64	3		$this->templateData = $data;
65	3		$this->sortOrder = $sort;
66	3		$this->type = $type;
67
68	3		return $this;
69			}
70
71
72
73			/**
74			* Render the view.
75			*
76			* @param object $app optional with access to the framework resources.
77			*
78			* @return void
79			*/
80	3		public function render($app = null)
81			{
82	3		switch ($this->type) {
83			case "file":
84	1		if (!$app) {
85	1		throw new Exception("View missing \$app.");
86			}
87			$viewRender = new ViewRenderFile();
88			$viewRender->setApp($app);
89			$viewRender->render($this->template, $this->templateData);
			0 ignored issues – show Bug introduced 2017-03-27 00:20 UTC by Report Bug Copy Issue Report It seems like `$this->template` can also be of type `array<string,?,{"callback":"?"}>`; however, `Anax\View\ViewRenderFile::render()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
90			break;
91
92			case "callback":
93			if (!isset($this->template["callback"]) \|\| !is_callable($this->template["callback"])) {
94			throw new Exception("View missing callback.");
95			}
96
97			echo call_user_func($this->template["callback"]);
98
99			break;
100
101			case "string":
102	1		echo $this->template;
103
104	1		break;
105
106			default:
107	1		throw new Exception("Not a valid template type: {$this->type}");
108			}
109	1		}
110
111
112
113			/**
114			* Give the sort order for this view.
115			*
116			* @return int
117			*/
118			public function sortOrder()
119			{
120			return $this->sortOrder;
121			}
122			}
123

canax / view

Push — master ( 2a3466...2685c9 )

View::set() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like