Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php | ||
| 12 | class Route | ||
| 13 | { | ||
| 14 | /** | ||
| 15 | * @var string $name a name for this route. | ||
| 16 | * @var string $info description of route. | ||
| 17 | * @var array $method the method(s) to support | ||
| 18 | * @var string $methodMatched the matched method. | ||
| 19 | * @var string $mount where to mount the path | ||
| 20 | * @var string $path the path rule for this route | ||
| 21 | * @var string $pathMatched the matched path. | ||
| 22 | * @var callable $handler the callback to handle this route | ||
| 23 | * @var null|array $arguments arguments for the callback, extracted | ||
| 24 | * from path | ||
| 25 | */ | ||
| 26 | private $name; | ||
| 27 | private $info; | ||
| 28 | private $method; | ||
| 29 | private $methodMatched; | ||
| 30 | private $mount; | ||
| 31 | private $path; | ||
| 32 | private $pathMatched; | ||
| 33 | private $handler; | ||
| 34 | private $arguments = []; | ||
| 35 | |||
| 36 | |||
| 37 | |||
| 38 | /** | ||
| 39 | * Set values for route. | ||
| 40 | * | ||
| 41 | * @param string|array $method as request method to support | ||
| 42 | * @param string $mount where to mount the path | ||
| 43 | * @param string $path for this route | ||
| 44 | * @param string|array|callable $handler for this path, callable or equal | ||
| 45 | * @param string $info description of the route | ||
| 46 | * | ||
| 47 | * @return $this | ||
| 48 | */ | ||
| 49 | 164 | public function set( | |
| 71 | |||
| 72 | |||
| 73 | |||
| 74 | /** | ||
| 75 | * Check if the route matches a query and request method. | ||
| 76 | * | ||
| 77 | * @param string $query to match against | ||
| 78 | * @param string $method as request method | ||
| 79 | * | ||
| 80 | * @return boolean true if query matches the route | ||
| 81 | */ | ||
| 82 | 147 | public function match(string $query, string $method = null) | |
| 103 | |||
| 104 | |||
| 105 | |||
| 106 | /** | ||
| 107 | * Handle the action for the route. | ||
| 108 | * | ||
| 109 | * @param string $path the matched path | ||
| 110 | * @param ContainerInjectableInterface $di container with services | ||
| 111 | * | ||
| 112 | * @return mixed | ||
| 113 | */ | ||
| 114 | 142 | public function handle( | |
| 129 | |||
| 130 | |||
| 131 | |||
| 132 | /** | ||
| 133 | * Get the matched basename of the path, its the part without the mount | ||
| 134 | * point. | ||
| 135 | * | ||
| 136 | * @return string|null | ||
| 137 | */ | ||
| 138 | 3 | public function getMatchedPath() | |
| 150 | |||
| 151 | |||
| 152 | |||
| 153 | /** | ||
| 154 | * Set the name of the route. | ||
| 155 | * | ||
| 156 | * @param string $name set a name for the route | ||
| 157 | * | ||
| 158 | * @return $this | ||
| 159 | */ | ||
| 160 | 1 | public function setName($name) | |
| 165 | |||
| 166 | |||
| 167 | |||
| 168 | /** | ||
| 169 | * Set the path that matched this route. | ||
| 170 | * | ||
| 171 | * @param string $path to set | ||
| 172 | * | ||
| 173 | * @return $this | ||
| 174 | */ | ||
| 175 | 21 | public function setMatchedPath($path) | |
| 180 | |||
| 181 | |||
| 182 | |||
| 183 | /** | ||
| 184 | * Get information of the route. | ||
| 185 | * | ||
| 186 | * @return null|string as route information. | ||
| 187 | */ | ||
| 188 | 2 | public function getInfo() | |
| 192 | |||
| 193 | |||
| 194 | |||
| 195 | /** | ||
| 196 | * Get the path for the route. | ||
| 197 | * | ||
| 198 | * @return string | ||
| 199 | */ | ||
| 200 | 1 | public function getPath() | |
| 204 | |||
| 205 | |||
| 206 | |||
| 207 | /** | ||
| 208 | * Get the absolute $path by adding $mount. | ||
| 209 | * | ||
| 210 | * @return string|null as absolute path for this route. | ||
| 211 | */ | ||
| 212 | 147 | public function getAbsolutePath() | |
| 224 | |||
| 225 | |||
| 226 | |||
| 227 | /** | ||
| 228 | * Get the request method for the route. | ||
| 229 | * | ||
| 230 | * @return string representing the request method supported | ||
| 231 | */ | ||
| 232 | 1 | public function getRequestMethod() : string | |
| 238 | } | ||
| 239 | 
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.