Route::set() - Code Metrics - Inspection of "Enhancing unittest" - canax/router - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cebcdc...df6a12 )

by Mikael

created 2017-03-07 10:53 UTC

Route::set() A

↳ Parent: Route

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	4
nc	1
nop	2
crap	1

<?php

namespace Anax\Route;

/**
 * A container for routes.
 *
 */
class Route
{

    /**
    * Properties
    *
    */
    private $name;   // A name for this route
    private $rule;   // The rule for this route
    private $action; // The controller action to handle this route



    /**
     * Set values for route.
     *
     * @param string   $rule   for this route
     * @param callable $action callable to implement a controller for the route
     *
     * @return $this
     */
    public function set($rule, $action)
    {
        $this->rule = $rule;
        $this->action = $action;

        return $this;
    }



    /**
     * Check if the route matches a query
     *
     * @param string $query to match against
     *
     * @return boolean true if query matches the route
     */
    public function match($query)
    {
        $ruleParts  = explode('/', $this->rule);
        $queryParts = explode('/', $query);
        $ruleCount = max(count($ruleParts), count($queryParts));

        // If default route, match anything
        if ($this->rule == "*") {
            return true;
        }

        $match = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        for ($i = 0; $i < $ruleCount; $i++) {
            $rulePart  = isset($ruleParts[$i])  ? $ruleParts[$i]  : null;
            $queryPart = isset($queryParts[$i]) ? $queryParts[$i] : null;

            // Support various rules for matching the parts
            $first = isset($rulePart[0]) ? $rulePart[0] : '';
            switch ($first) {
                case '*':
                    $match = true;
                    break;
                
                default:
                    $match = ($rulePart == $queryPart);
                    break;
            }

            // Continue as long as each part matches
            if (!$match) {
                return false;
            }
        }

        return true;
    }



    /**
     * Handle the action for the route.
     *
     * @return void
     */
    public function handle()
    {
        return call_user_func($this->action);
    }



    /**
     * Set the name of the route.
     *
     * @param string $name set a name for the route
     *
     * @return $this
     */
    public function setName($name)
    {
        $this->name = $name;
        return $this;
    }



    /**
     * Get the rule for the route.
     *
     * @return string
     */
    public function getRule()
    {
        return $this->rule;
    }
}


1		<?php
2
3		namespace Anax\Route;
4
5		/**
6		* A container for routes.
7		*
8		*/
9		class Route
10		{
11
12		/**
13		* Properties
14		*
15		*/
16		private $name; // A name for this route
17		private $rule; // The rule for this route
18		private $action; // The controller action to handle this route
19
20
21
22		/**
23		* Set values for route.
24		*
25		* @param string $rule for this route
26		* @param callable $action callable to implement a controller for the route
27		*
28		* @return $this
29		*/
30	9	public function set($rule, $action)
31		{
32	9	$this->rule = $rule;
33	9	$this->action = $action;
34
35	9	return $this;
36		}
37
38
39
40		/**
41		* Check if the route matches a query
42		*
43		* @param string $query to match against
44		*
45		* @return boolean true if query matches the route
46		*/
47	9	public function match($query)
48		{
49	9	$ruleParts = explode('/', $this->rule);
50	9	$queryParts = explode('/', $query);
51	9	$ruleCount = max(count($ruleParts), count($queryParts));
52
53		// If default route, match anything
54	9	if ($this->rule == "*") {
55	2	return true;
56		}
57
58	7	$match = false;
		0 ignored issues – show Unused Code introduced 2017-03-03 15:59 UTC by Report Bug Copy Issue Report `$match` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
59	7	for ($i = 0; $i < $ruleCount; $i++) {
60	7	$rulePart = isset($ruleParts[$i]) ? $ruleParts[$i] : null;
61	7	$queryPart = isset($queryParts[$i]) ? $queryParts[$i] : null;
62
63		// Support various rules for matching the parts
64	7	$first = isset($rulePart[0]) ? $rulePart[0] : '';
65		switch ($first) {
66	7	case '*':
67	1	$match = true;
68	1	break;
69
70	7	default:
71	7	$match = ($rulePart == $queryPart);
72	7	break;
73	7	}
74
75		// Continue as long as each part matches
76	7	if (!$match) {
77	4	return false;
78		}
79	7	}
80
81	7	return true;
82		}
83
84
85
86		/**
87		* Handle the action for the route.
88		*
89		* @return void
90		*/
91	5	public function handle()
92		{
93	5	return call_user_func($this->action);
94		}
95
96
97
98		/**
99		* Set the name of the route.
100		*
101		* @param string $name set a name for the route
102		*
103		* @return $this
104		*/
105		public function setName($name)
106		{
107		$this->name = $name;
108		return $this;
109		}
110
111
112
113		/**
114		* Get the rule for the route.
115		*
116		* @return string
117		*/
118		public function getRule()
119		{
120		return $this->rule;
121		}
122		}
123

canax / router

Push — master ( cebcdc...df6a12 )

Route::set() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like