Anax\Route\RouterInjectable

Complexity

Total Complexity

15

Size/Duplication

Total Lines	152
Duplicated Lines	14.47 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

84.09%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getAll()	0	4	1
A	getInternal()	0	4	1
A	add()	13	13	2
A	addDefault()	9	9	1
A	addInternal()	0	7	1
A	handleInternal()	0	8	2
C	handle()	0	25	7

<?php

namespace Anax\Route;

/**
 * A container for routes.
 *
 */
class RouterInjectable
{
    /**
     * Properties
     *
     */
    private $routes         = [];    // All the routes
    private $internalRoutes = [];    // All internal routes
    private $defaultRoute   = null;  // A default route to catch all



    /**
     * Get all routes.
     *
     * @return array with all routes.
     */
    public function getAll()
    {
        return $this->routes;
    }



    /**
     * Get all internal routes.
     *
     * @return array with internal routes.
     */
    public function getInternal()
    {
        return $this->internalRoutes;
    }



    /**
     * Add a route to the router.
     *
     * @param string $rule   for this route
     * @param mixed  $action null, string or callable to implement a controller for the route
     *
     * @return class as new route
     */
    public function add($rule, $action = null)

This method seems to be duplicated in your project.

    {
        $route = new Route();
        $route->set($rule, $action);

$action is of type *, but the function expects a callable.

        $this->routes[] = $route;

        // Set as default route
        if ($rule == "*") {
            $this->defaultRoute = $route;
        }

        return $route;
    }



    /**
     * Add a default route to the router, to use when all other routes fail.
     *
     * @param mixed  $action null, string or callable to implement a controller for the route
     *
     * @return class as new route
     */
    public function addDefault($action)

This method seems to be duplicated in your project.

    {
        $route = new Route();
        $route->set("*", $action);

$action is of type *, but the function expects a callable.

        $this->routes[] = $route;
        $this->defaultRoute = $route;

        return $route;
    }



    /**
     * Add an internal (not exposed to url-matching) route to the router.
     *
     * @param string $rule   for this route
     * @param mixed  $action null, string or callable to implement a controller for the route
     *
     * @return class as new route
     */
    public function addInternal($rule, $action = null)
    {
        $route = new Route();
        $route->set($rule, $action);

$action is of type *, but the function expects a callable.

        $this->internalRoutes[$rule] = $route;
        return $route;
    }



    /**
     * Add an internal (not exposed to url-matching) route to the router.
     *
     * @param string $rule   for this route
     * @param mixed  $action null, string or callable to implement a

There is no parameter named $action. Was it maybe removed?

     *                       controller for the route
     *
     * @return void
     */
    public function handleInternal($rule)
    {
        if (!isset($this->internalRoutes[$rule])) {
            throw new NotFoundException("No internal route to handle: " . $rule);
        }
        $route = $this->internalRoutes[$rule];
        $route->handle();
    }



    /**
     * Handle the routes and match them towards the request, dispatch them
     * when a match is made. Each route handler may throw exceptions that
     * may redirect to an internal route for error handling.
     *
     * @param string $query   the query/route to match a handler for.
     *
     * @return mixed content returned from route.
     */
    public function handle($query)
    {
        try {
            // Match predefined routes
            foreach ($this->routes as $route) {
                if ($route->match($query)) {
                    return $route->handle();
                }
            }

            // Use the "catch-all" route
            if ($this->defaultRoute) {
                return $this->defaultRoute->handle();
            }

            // No route was matched
            $this->handleInternal("404");
        } catch (ForbiddenException $e) {
            $this->handleInternal("403");
        } catch (NotFoundException $e) {
            $this->handleInternal("404");
        } catch (InternalErrorException $e) {
            $this->handleInternal("500");
        }
    }
}