Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Route |
||
13 | { |
||
14 | /** |
||
15 | * @var string $name a name for this route. |
||
16 | * @var string $info description of route. |
||
17 | * @var array $method the method(s) to support |
||
18 | * @var string $methodMatched the matched method. |
||
19 | * @var string $mount where to mount the path |
||
20 | * @var string $path the path rule for this route |
||
21 | * @var string $pathMatched the matched path. |
||
22 | * @var callable $handler the callback to handle this route |
||
23 | * @var null|array $arguments arguments for the callback, extracted |
||
24 | * from path |
||
25 | */ |
||
26 | private $name; |
||
27 | private $info; |
||
28 | private $method; |
||
29 | private $methodMatched; |
||
30 | private $mount; |
||
31 | private $path; |
||
32 | private $pathMatched; |
||
33 | private $handler; |
||
34 | private $arguments = []; |
||
35 | |||
36 | |||
37 | |||
38 | /** |
||
39 | * Set values for route. |
||
40 | * |
||
41 | * @param string|array $method as request method to support |
||
42 | * @param string $mount where to mount the path |
||
43 | * @param string $path for this route |
||
44 | * @param string|array|callable $handler for this path, callable or equal |
||
45 | * @param string $info description of the route |
||
46 | * |
||
47 | * @return $this |
||
48 | */ |
||
49 | 163 | public function set( |
|
71 | |||
72 | |||
73 | |||
74 | /** |
||
75 | * Check if the route matches a query and request method. |
||
76 | * |
||
77 | * @param string $query to match against |
||
78 | * @param string $method as request method |
||
79 | * |
||
80 | * @return boolean true if query matches the route |
||
81 | */ |
||
82 | 146 | public function match(string $query, string $method = null) |
|
103 | |||
104 | |||
105 | |||
106 | /** |
||
107 | * Handle the action for the route. |
||
108 | * |
||
109 | * @param string $path the matched path |
||
110 | * @param ContainerInjectableInterface $di container with services |
||
111 | * |
||
112 | * @return mixed |
||
113 | */ |
||
114 | 141 | public function handle( |
|
142 | |||
143 | |||
144 | |||
145 | /** |
||
146 | * Set the path that matched this route. |
||
147 | * |
||
148 | * @param string $path to set |
||
149 | * |
||
150 | * @return $this |
||
151 | */ |
||
152 | 21 | public function setMatchedPath($path) |
|
153 | { |
||
154 | 21 | $this->pathMatched = $path; |
|
155 | 21 | return $this; |
|
156 | } |
||
157 | |||
158 | |||
159 | |||
160 | /** |
||
161 | * Get the matched basename of the path, its the part without the mount |
||
162 | * point. |
||
163 | * |
||
164 | * @return string|null |
||
165 | */ |
||
166 | 3 | public function getMatchedPath() |
|
167 | { |
||
168 | 3 | $path = $this->pathMatched; |
|
169 | 3 | View Code Duplication | if ($this->mount) { |
170 | 1 | $len = strlen($this->mount); |
|
171 | 1 | if (substr($path, 0, $len) == $this->mount) { |
|
172 | 1 | $path = ltrim(substr($path, $len), "/"); |
|
173 | } |
||
174 | } |
||
175 | |||
176 | 3 | return $path; |
|
177 | } |
||
178 | |||
179 | |||
180 | |||
181 | /** |
||
182 | * Set the name of the route. |
||
183 | * |
||
184 | * @param string $name set a name for the route |
||
185 | * |
||
186 | * @return $this |
||
187 | */ |
||
188 | 1 | public function setName($name) |
|
189 | { |
||
190 | 1 | $this->name = $name; |
|
191 | 1 | return $this; |
|
192 | } |
||
193 | |||
194 | |||
195 | |||
196 | /** |
||
197 | * Get information of the route. |
||
198 | * |
||
199 | * @return null|string as route information. |
||
200 | */ |
||
201 | 2 | public function getInfo() |
|
205 | |||
206 | |||
207 | |||
208 | /** |
||
209 | * Get the path for the route. |
||
210 | * |
||
211 | * @return string |
||
212 | */ |
||
213 | 1 | public function getPath() |
|
217 | |||
218 | |||
219 | |||
220 | /** |
||
221 | * Get the absolute $path by adding $mount. |
||
222 | * |
||
223 | * @return string|null as absolute path for this route. |
||
224 | */ |
||
225 | 146 | public function getAbsolutePath() |
|
237 | |||
238 | |||
239 | |||
240 | /** |
||
241 | * Get the request method for the route. |
||
242 | * |
||
243 | * @return string representing the request method supported |
||
244 | */ |
||
245 | 1 | public function getRequestMethod() : string |
|
251 | |||
252 | |||
253 | |||
254 | /** |
||
255 | * Get the handler type as a informative string. |
||
256 | * |
||
257 | * @param ContainerInjectableInterface $di container with services |
||
258 | * |
||
259 | * @return string representing the handler. |
||
260 | */ |
||
261 | public function getHandlerType(ContainerInterface $di = null) : string |
||
266 | } |
||
267 |
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.