Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Request often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Request, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | class Request |
||
10 | { |
||
11 | /** |
||
12 | * @var string $requestUri Request URI from $_SERVER. |
||
13 | * @var string $scriptName Scriptname from $_SERVER, actual scriptname part. |
||
14 | * @var string $path Scriptname from $_SERVER, path-part. |
||
15 | */ |
||
16 | private $requestUri; |
||
17 | private $scriptName; |
||
18 | private $path; |
||
19 | |||
20 | |||
21 | |||
22 | /** |
||
23 | * @var string $route The route. |
||
24 | * @var array $routeParts The route as an array. |
||
25 | */ |
||
26 | private $route; |
||
27 | private $routeParts; |
||
28 | |||
29 | |||
30 | |||
31 | /** |
||
32 | * @var string $currentUrl Current url. |
||
33 | * @var string $siteUrl Url to this site, http://dbwebb.se. |
||
34 | * @var string $baseUrl Url to root dir, |
||
35 | * siteUrl . /some/installation/directory/. |
||
36 | */ |
||
37 | private $currentUrl; |
||
38 | private $siteUrl; |
||
39 | private $baseUrl; |
||
40 | |||
41 | |||
42 | |||
43 | /** |
||
44 | * @var array $server Mapped to $_SERVER. |
||
45 | * @var array $get Mapped to $_GET. |
||
46 | * @var array $post Mapped to $_POST. |
||
47 | * @var array $body Mapped to request body, defaults to php://input. |
||
48 | */ |
||
49 | private $server; |
||
50 | private $get; |
||
51 | private $post; |
||
52 | private $body; |
||
53 | |||
54 | |||
55 | |||
56 | /** |
||
57 | * Constructor. |
||
58 | */ |
||
59 | 49 | public function __construct() |
|
63 | |||
64 | |||
65 | |||
66 | /** |
||
67 | * Read info from the globals. |
||
68 | * |
||
69 | * @param array $globals use to initiate globals with values. |
||
70 | * |
||
71 | * @return void |
||
72 | */ |
||
73 | 49 | public function setGlobals($globals = []) |
|
91 | |||
92 | |||
93 | |||
94 | /** |
||
95 | * Read info from the globals. |
||
96 | * |
||
97 | * @param array $globals use to initiate globals with values. |
||
|
|||
98 | * |
||
99 | * @return void |
||
100 | */ |
||
101 | 4 | public function unsetGlobals() |
|
107 | |||
108 | |||
109 | |||
110 | /** |
||
111 | * Init the request class by reading information from the request. |
||
112 | * |
||
113 | * @return $this |
||
114 | */ |
||
115 | 19 | public function init() |
|
143 | |||
144 | |||
145 | |||
146 | /** |
||
147 | * Get site url including scheme, host and port. |
||
148 | * |
||
149 | * @return string |
||
150 | */ |
||
151 | 9 | public function getSiteUrl() |
|
155 | |||
156 | |||
157 | |||
158 | /** |
||
159 | * Get base url including site url and path to current index.php. |
||
160 | * |
||
161 | * @return string |
||
162 | */ |
||
163 | 9 | public function getBaseUrl() |
|
167 | |||
168 | |||
169 | |||
170 | /** |
||
171 | * Get script name, index.php or other. |
||
172 | * |
||
173 | * @return string |
||
174 | */ |
||
175 | 2 | public function getScriptName() |
|
176 | { |
||
177 | 2 | return $this->scriptName; |
|
178 | } |
||
179 | |||
180 | |||
181 | |||
182 | /** |
||
183 | * Get route path parts in an array. |
||
184 | * |
||
185 | * @return array with route in its parts |
||
186 | */ |
||
187 | 1 | public function getRouteParts() |
|
188 | { |
||
189 | 1 | return $this->routeParts; |
|
190 | } |
||
191 | |||
192 | |||
193 | |||
194 | /** |
||
195 | * Get route path as a string. |
||
196 | * |
||
197 | * @return string as the current extracted route |
||
198 | */ |
||
199 | 6 | public function getRoute() |
|
203 | |||
204 | |||
205 | |||
206 | /** |
||
207 | * Get the request method. |
||
208 | * |
||
209 | * @return string as the request method |
||
210 | */ |
||
211 | 1 | public function getMethod() |
|
215 | |||
216 | |||
217 | |||
218 | /** |
||
219 | * Extract the part containing the route. |
||
220 | * |
||
221 | * @todo Should be private, or useful in test? |
||
222 | * |
||
223 | * @return string as the current extracted route |
||
224 | */ |
||
225 | 19 | public function extractRoute() |
|
226 | { |
||
227 | 19 | $requestUri = $this->requestUri; |
|
228 | 19 | $scriptPath = $this->path; |
|
229 | 19 | $scriptFile = $this->scriptName; |
|
230 | |||
231 | // Compare REQUEST_URI and SCRIPT_NAME as long they match, |
||
232 | // leave the rest as current request. |
||
233 | 19 | $i = 0; |
|
234 | 19 | $len = min(strlen($requestUri), strlen($scriptPath)); |
|
235 | 19 | while ($i < $len |
|
236 | 19 | && $requestUri[$i] == $scriptPath[$i] |
|
237 | ) { |
||
238 | 14 | $i++; |
|
239 | } |
||
240 | 19 | $route = trim(substr($requestUri, $i), "/"); |
|
241 | |||
242 | // Does the request start with script-name - remove it. |
||
243 | 19 | $len1 = strlen($route); |
|
244 | 19 | $len2 = strlen($scriptFile); |
|
245 | |||
246 | 19 | if ($len2 <= $len1 |
|
247 | 19 | && substr_compare($scriptFile, $route, 0, $len2, true) === 0 |
|
248 | ) { |
||
249 | 14 | $route = substr($route, $len2 + 1); |
|
250 | } |
||
251 | |||
252 | // Remove the ?-part from the query when analysing controller/metod/arg1/arg2 |
||
253 | 19 | $queryPos = strpos($route, "?"); |
|
254 | 19 | if ($queryPos !== false) { |
|
255 | 1 | $route = substr($route, 0, $queryPos); |
|
256 | } |
||
257 | |||
258 | 19 | $route = ($route === false) ? "" : $route; |
|
259 | |||
260 | 19 | $this->route = $route; |
|
261 | 19 | $this->routeParts = explode("/", trim($route, "/")); |
|
262 | |||
263 | 19 | return $this->route; |
|
264 | } |
||
265 | |||
266 | |||
267 | |||
268 | /** |
||
269 | * Get the current url. |
||
270 | * |
||
271 | * @param boolean $queryString attach query string, default is true. |
||
272 | * |
||
273 | * @return string as current url. |
||
274 | */ |
||
275 | 34 | public function getCurrentUrl($queryString = true) |
|
304 | |||
305 | |||
306 | |||
307 | /** |
||
308 | * Get a value from the _SERVER array and use default if it is not set. |
||
309 | * |
||
310 | * @param string $key to check if it exists in the $_SERVER variable, |
||
311 | * or empty to get whole array. |
||
312 | * @param mixed $default value to return as default |
||
313 | * |
||
314 | * @return mixed |
||
315 | */ |
||
316 | 38 | public function getServer($key = null, $default = null) |
|
324 | |||
325 | |||
326 | |||
327 | /** |
||
328 | * Set variable in the server array. |
||
329 | * |
||
330 | * @param mixed $key the key an the , or an key-value array |
||
331 | * @param string $value the value of the key |
||
332 | * |
||
333 | * @return self |
||
334 | */ |
||
335 | 27 | View Code Duplication | public function setServer($key, $value = null) : object |
344 | |||
345 | |||
346 | |||
347 | /** |
||
348 | * Check if the value from the _GET array exists. |
||
349 | * |
||
350 | * @param string $key to check if it exists in the $_GET variable |
||
351 | * |
||
352 | * @return boolean |
||
353 | */ |
||
354 | 1 | public function hasGet($key) |
|
358 | |||
359 | |||
360 | |||
361 | /** |
||
362 | * Get a value from the _GET array and use default if it is not set. |
||
363 | * |
||
364 | * @param string $key to check if it exists in the $_GET variable, |
||
365 | * or empty to get whole array. |
||
366 | * @param mixed $default value to return as default |
||
367 | * |
||
368 | * @return mixed |
||
369 | */ |
||
370 | 3 | View Code Duplication | public function getGet($key = null, $default = null) |
378 | |||
379 | |||
380 | |||
381 | /** |
||
382 | * Set variable in the get array. |
||
383 | * |
||
384 | * @param mixed $key the key an the value, or an key-value array |
||
385 | * @param string $value the value of the key |
||
386 | * |
||
387 | * @return self |
||
388 | */ |
||
389 | 2 | View Code Duplication | public function setGet($key, $value = null) : object |
398 | |||
399 | |||
400 | |||
401 | /** |
||
402 | * Get a value from the _POST array and use default if it is not set. |
||
403 | * |
||
404 | * @param string $key to check if it exists in the $_POST variable, |
||
405 | * or empty to get whole array. |
||
406 | * @param mixed $default value to return as default |
||
407 | * |
||
408 | * @return mixed |
||
409 | */ |
||
410 | 3 | View Code Duplication | public function getPost($key = null, $default = null) |
418 | |||
419 | |||
420 | |||
421 | /** |
||
422 | * Set variable in the post array. |
||
423 | * |
||
424 | * @param mixed $key the key an the value, or an key-value array |
||
425 | * @param string $value the value of the key |
||
426 | * |
||
427 | * @return self |
||
428 | */ |
||
429 | 2 | View Code Duplication | public function setPost($key, $value = null) : object |
438 | |||
439 | |||
440 | |||
441 | /** |
||
442 | * Set the request body (useful for unit testing). |
||
443 | * |
||
444 | * @return self |
||
445 | */ |
||
446 | 3 | public function setBody($body) |
|
450 | |||
451 | |||
452 | |||
453 | /** |
||
454 | * Get the request body. |
||
455 | * |
||
456 | * @return mixed |
||
457 | */ |
||
458 | 3 | public function getBody() |
|
464 | |||
465 | |||
466 | |||
467 | /** |
||
468 | * Get the request body from the HTTP request and treat it as |
||
469 | * JSON data, return null if request body is empty. |
||
470 | * |
||
471 | * @throws \JsonException when request body is invalid JSON. |
||
472 | * |
||
473 | * @return mixed as the JSON converted content or null if body is empty. |
||
474 | */ |
||
475 | 2 | public function getBodyAsJson() |
|
485 | } |
||
486 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italy
is not defined by the methodfinale(...)
.The most likely cause is that the parameter was removed, but the annotation was not.