Anax\HTMLForm\FormElementCheckboxMultiple

Complexity

Total Complexity

7

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Test Coverage

Coverage

89.29%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getHTML()	0	31	4
A	__construct()	0	7	2
A	value()	0	3	1

<?php

namespace Anax\HTMLForm;

/**
 * Form element
 */
class FormElementCheckboxMultiple extends FormElement
{

    /**
     * Constructor
     *
     * @param string $name       of the element.
     * @param array  $attributes to set to the element. Default is an empty array.
     */
    public function __construct($name, $attributes = [])
    {
        parent::__construct($name, $attributes);
        $this['type'] = 'checkbox-multiple';
        
        if (!isset($this['values'])) {
            throw new Exception("Missing values for the checkbox.");
        }
    }



    /**
     * Get the value of the form element.
     *
     * @return array the checked values of the form element.
     */
    public function value()
    {
        return $this['checked'];
    }



    /**
     * Get HTML code for a element.
     *
     * @return string HTML code for the element.
     *
     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
     */
    public function getHTML()
    {
        $details = $this->getHTMLDetails();
        extract($details);

$details of type Anax\HTMLForm\HTML is incompatible with the type array expected by parameter $var_array of extract().

        $type = "type='checkbox'";
        $name = " name='{$this['name']}[]'";
        $ret = null;
        $checkedValues = is_array($this['checked']) ? $this['checked'] : [];

        foreach ($this['values'] as $val) {
            $id .= $val;
            $item = $onlyValue  = htmlentities($val, ENT_QUOTES, $this->characterEncoding);
            $value = " value='{$onlyValue}'";
            $checked = in_array($val, $checkedValues)

It seems like $checkedValues can also be of type null; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

                ? " checked='checked'"
                : null;

            $ret .= <<<EOD
<p>
<input id='$id'{$type}{$class}{$name}{$value}{$autofocus}{$readonly}{$checked}{$title} />
<label for='$id'>$item</label>
{$messages}
</p>
EOD;
        }
        return <<<EOD

The expression return '<div> <p>'.$label.'</p> '.$ret.' <p class='cf-desc'>'.$description.'</p> </div>' returns the type string which is incompatible with the return type mandated by Anax\HTMLForm\FormElement::getHTML() of Anax\HTMLForm\HTML.

<div>
<p>{$label}</p>
{$ret}
<p class='cf-desc'>{$description}</p>
</div>
EOD;
    }
}