DIMagicTrait - Code Metrics - Inspection of "remove unneded interface" - canax/di - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 94992f...8033b7 )

by Mikael

created 2017-09-11 21:00 UTC

DIMagicTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

50%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
lcom	0
cbo	0
dl	0
loc	29
ccs	2
cts	4
cp	0.5
rs	10
c	1
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__get()	0	4	1
A	__call()	0	4	1

<?php

namespace Anax\DI;

use Anax\DI\Exception\Exception;

/**
 * Trait to use to make a DI container use magic for
 * getting services. A class using a DI container can
 * access $this->di->session; as an alternative to
 * $this->di->get("session");
 */
trait DIMagicTrait
{
    /**
     * Magic method to get a service.
     *
     * @param string $service name of the service.
     *
     * @return mixed as the service requested.
     */
    public function __get($service)
    {
        return $this->get($service);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }



    /**
     * Magic method to get and call a service.
     *
     * @param string $service name of the service.
     * @param array  $arguments currently NOT USED.
     *
     * @return mixed as the service requested.
     */
    public function __call($service, $arguments = [])
    {
        return $this->get($service);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}


1		<?php
2
3		namespace Anax\DI;
4
5		use Anax\DI\Exception\Exception;
6
7		/**
8		* Trait to use to make a DI container use magic for
9		* getting services. A class using a DI container can
10		* access $this->di->session; as an alternative to
11		* $this->di->get("session");
12		*/
13		trait DIMagicTrait
14		{
15		/**
16		* Magic method to get a service.
17		*
18		* @param string $service name of the service.
19		*
20		* @return mixed as the service requested.
21		*/
22		public function __get($service)
23		{
24		return $this->get($service);
		0 ignored issues – show Documentation Bug introduced 2017-09-11 21:04 UTC by Report Bug Copy Issue Report The method `get` does not exist on `object<Anax\DI\DIMagicTrait>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
25		}
26
27
28
29		/**
30		* Magic method to get and call a service.
31		*
32		* @param string $service name of the service.
33		* @param array $arguments currently NOT USED.
34		*
35		* @return mixed as the service requested.
36		*/
37	1	public function __call($service, $arguments = [])
38		{
39	1	return $this->get($service);
		0 ignored issues – show Documentation Bug introduced 2017-09-11 21:04 UTC by Report Bug Copy Issue Report The method `get` does not exist on `object<Anax\DI\DIMagicTrait>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
40		}
41		}
42

canax / di

Push — master ( 94992f...8033b7 )

DIMagicTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like